From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cn.fujitsu.com ([59.151.112.132]:9582 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751414AbaLHBsB (ORCPT ); Sun, 7 Dec 2014 20:48:01 -0500 Message-ID: <54850290.2070201@cn.fujitsu.com> Date: Mon, 8 Dec 2014 09:44:48 +0800 From: Xiaoguang Wang MIME-Version: 1.0 Subject: Re: [PATCH] ext4/004: add dump/restore test References: <1416910869-28538-1-git-send-email-wangxg.fnst@cn.fujitsu.com> <20141206214040.GA27484@thunk.org> In-Reply-To: <20141206214040.GA27484@thunk.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: fstests-owner@vger.kernel.org To: Theodore Ts'o Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org List-ID: Hi, On 12/07/2014 05:40 AM, Theodore Ts'o wrote: > On Tue, Nov 25, 2014 at 06:21:09PM +0800, Xiaoguang Wang wrote: >> This test case will first use fsstress to fill a file system, then >> dump it to standard output and restore it from standard input, finally >> check that the original contents and the new contents generated by >> restore tool will be same. >> >> Signed-off-by: Xiaoguang Wang > > One question --- what is the intent of this test? Is it to test the > kernel, or the dump/restore program? I have not bothered putting > regression tests for e2fsprogs in xfstests, because if I'm developing > e2fsprogs, it actually makes much more sense to put the regression > tests in the e2fsprogs git tree. Yeah, my intent is to test dump/restore program, and indeed I imitate that how xfs to test xfsdump/xfsrestore, xfs puts xfsdump/xfsrestore tests in corresponding xfs directory. Regards, Xiaoguang Wang > > If this is because it's more convenient to put this in xfsprogs > because it has fsstress, maybe we should adjust the groups that it is > in so that it's not in auto or quick, but some other group? Or add it > to some group like "userspace" so I can exclude it when I'm mostly > interested in testing development kernels? > > Thanks, > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiaoguang Wang Subject: Re: [PATCH] ext4/004: add dump/restore test Date: Mon, 8 Dec 2014 09:44:48 +0800 Message-ID: <54850290.2070201@cn.fujitsu.com> References: <1416910869-28538-1-git-send-email-wangxg.fnst@cn.fujitsu.com> <20141206214040.GA27484@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: , To: "Theodore Ts'o" Return-path: Received: from cn.fujitsu.com ([59.151.112.132]:9582 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751414AbaLHBsB (ORCPT ); Sun, 7 Dec 2014 20:48:01 -0500 In-Reply-To: <20141206214040.GA27484@thunk.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: Hi, On 12/07/2014 05:40 AM, Theodore Ts'o wrote: > On Tue, Nov 25, 2014 at 06:21:09PM +0800, Xiaoguang Wang wrote: >> This test case will first use fsstress to fill a file system, then >> dump it to standard output and restore it from standard input, finally >> check that the original contents and the new contents generated by >> restore tool will be same. >> >> Signed-off-by: Xiaoguang Wang > > One question --- what is the intent of this test? Is it to test the > kernel, or the dump/restore program? I have not bothered putting > regression tests for e2fsprogs in xfstests, because if I'm developing > e2fsprogs, it actually makes much more sense to put the regression > tests in the e2fsprogs git tree. Yeah, my intent is to test dump/restore program, and indeed I imitate that how xfs to test xfsdump/xfsrestore, xfs puts xfsdump/xfsrestore tests in corresponding xfs directory. Regards, Xiaoguang Wang > > If this is because it's more convenient to put this in xfsprogs > because it has fsstress, maybe we should adjust the groups that it is > in so that it's not in auto or quick, but some other group? Or add it > to some group like "userspace" so I can exclude it when I'm mostly > interested in testing development kernels? > > Thanks, > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >