Re: [libvirt] [PATCH] libxl: Set path to console on domain startup

["Ján Tomko" <jtomko@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1197 bytes --]

On 12/05/2014 05:30 PM, Anthony PERARD wrote:
> Hi,
> 
> I'm trying to fix an issue when using OpenStack with libvirt+xen (libxenlight).
> OpenStack cannot access the console output of a Xen PV guest, because the XML
> generated by libvirt for a domain is missing the path to the pty. The path
> actually appear in the XML once one call virDomainOpenConsole().
> 
> The patch intend to get the path to the pty without having to call
> virDomainOpenConsole, so I've done the work in libxlDomainStart(). So I have a
> few question:
> Is libxlDomainStart will be called on restore/migrate/reboot?
> I guest the function libxlDomainOpenConsole() would not need to do the same
> work if the console path is settup properly.
> 
> There is a bug report about this:
> https://bugzilla.redhat.com/show_bug.cgi?id=1170743
> 

Hi,

you can leave the bugzilla link in the commit message, if somebody ever needs
more context.

(And the patch looks good to me, but I'm no libxl expert)

Jan

> Regards,
> 
> Anthony PERARD (1):
>   libxl: Set path to console on domain startup.
> 
>  src/libxl/libxl_domain.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel