From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Tunin Subject: Re: [PATCH v3 1/2] acpi: Add "acpi_osi=" for ASUS X200MA to enable, brightness keys Date: Thu, 18 Dec 2014 16:28:24 +0300 Message-ID: <5492D678.9040308@gmail.com> References: <5492C5A3.8090700@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-lb0-f177.google.com ([209.85.217.177]:52882 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbaLRN21 (ORCPT ); Thu, 18 Dec 2014 08:28:27 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Josh Boyer Cc: "linux-acpi@vger.kernel.org" , linux-kernel , "stable@vger.kernel.org" , Aaron Lu , Matthew Garrett Josh, I agree, that a better approach is to implement opregion in a right way= =2E But it will take some time. In the meantime this kind of quirks solve t= he problem. And it is quite safe. 18.12.2014 16:25, Josh Boyer =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On Thu, Dec 18, 2014 at 7:16 AM, Dmitry Tunin wrote: >> Add "acpi_osi=3D" quirk for ASUS X200MA >> More information can be found in UX302LA bugreport >> https://bugzilla.kernel.org/show_bug.cgi?id=3D70241 >> >> X200MA is affected by th e same bug and the solution has been tested >> >> I reported it to launchpad too >> https://bugs.launchpad.net/ubuntu/bug/1400068 >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Dmitry Tunin >> > > The UX301LA models have the same setup, with 16 devices instead of 8. > I discussed this with Matthew Garrett a bit and a more ideal approach > is to actually enumerate all 16 devices between the firmware and i915 > driver. The problem we have is that the intel opregion spec that > hasn't been updated since 2008 doesn't cover the additional 8 devices= =2E > Anyway, that is being tracked here: > > https://bugs.freedesktop.org/show_bug.cgi?id=3D81762 > >> --- >> drivers/acpi/blacklist.c | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c >> index 7556e7c..f78ed08 100644 >> --- a/drivers/acpi/blacklist.c >> +++ b/drivers/acpi/blacklist.c >> @@ -162,6 +162,17 @@ static int __init dmi_disable_osi_win8(const st= ruct >> dmi_system_id *d) >> acpi_osi_setup("!Windows 2012"); >> return 0; >> } >> +/* >> + * Some ASUS models firmware declares 16 devices instead of 8 >> + * 'acpi_osi=3D' kernel parameter fixes it >> + * Without this parameters brightness keys Fn+F5 and F6 do not work >> + */ >> +static int __init dmi_disable_osi_all(const struct dmi_system_id *d= ) >> +{ >> + printk(KERN_NOTICE PREFIX "DMI detected: %s\n", d->ident); >> + acpi_osi_setup(""); >> + return 0; >> +} > > What does this do to the rest of the function keys? Does everything > else still work as expected, including suspend and resume? > >> static struct dmi_system_id acpi_osi_dmi_table[] __initdata =3D { >> { >> @@ -371,6 +382,15 @@ static struct dmi_system_id acpi_osi_dmi_table[= ] >> __initdata =3D { >> DMI_MATCH(DMI_PRODUCT_NAME, "1015PX"), >> }, >> }, >> + /* Without this brightness keys do not work */ >> + { >> + .callback =3D dmi_disable_osi_all, >> + .ident =3D "ASUSTeK COMPUTER INC. X200MA", >> + .matches =3D { >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC= =2E"), >> + DMI_MATCH(DMI_PRODUCT_NAME, "X200MA"), >> + }, >> + }, >> {} >> }; >> >> -- >> 1.9.1 >> -- >> To unsubscribe from this list: send the line "unsubscribe stable" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752474AbaLRN23 (ORCPT ); Thu, 18 Dec 2014 08:28:29 -0500 Received: from mail-lb0-f177.google.com ([209.85.217.177]:52882 "EHLO mail-lb0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752442AbaLRN21 (ORCPT ); Thu, 18 Dec 2014 08:28:27 -0500 Message-ID: <5492D678.9040308@gmail.com> Date: Thu, 18 Dec 2014 16:28:24 +0300 From: Dmitry Tunin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Josh Boyer CC: "linux-acpi@vger.kernel.org" , linux-kernel , "stable@vger.kernel.org" , Aaron Lu , Matthew Garrett Subject: Re: [PATCH v3 1/2] acpi: Add "acpi_osi=" for ASUS X200MA to enable, brightness keys References: <5492C5A3.8090700@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Josh, I agree, that a better approach is to implement opregion in a right way. But it will take some time. In the meantime this kind of quirks solve the problem. And it is quite safe. 18.12.2014 16:25, Josh Boyer пишет: > On Thu, Dec 18, 2014 at 7:16 AM, Dmitry Tunin wrote: >> Add "acpi_osi=" quirk for ASUS X200MA >> More information can be found in UX302LA bugreport >> https://bugzilla.kernel.org/show_bug.cgi?id=70241 >> >> X200MA is affected by th e same bug and the solution has been tested >> >> I reported it to launchpad too >> https://bugs.launchpad.net/ubuntu/bug/1400068 >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Dmitry Tunin >> > > The UX301LA models have the same setup, with 16 devices instead of 8. > I discussed this with Matthew Garrett a bit and a more ideal approach > is to actually enumerate all 16 devices between the firmware and i915 > driver. The problem we have is that the intel opregion spec that > hasn't been updated since 2008 doesn't cover the additional 8 devices. > Anyway, that is being tracked here: > > https://bugs.freedesktop.org/show_bug.cgi?id=81762 > >> --- >> drivers/acpi/blacklist.c | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c >> index 7556e7c..f78ed08 100644 >> --- a/drivers/acpi/blacklist.c >> +++ b/drivers/acpi/blacklist.c >> @@ -162,6 +162,17 @@ static int __init dmi_disable_osi_win8(const struct >> dmi_system_id *d) >> acpi_osi_setup("!Windows 2012"); >> return 0; >> } >> +/* >> + * Some ASUS models firmware declares 16 devices instead of 8 >> + * 'acpi_osi=' kernel parameter fixes it >> + * Without this parameters brightness keys Fn+F5 and F6 do not work >> + */ >> +static int __init dmi_disable_osi_all(const struct dmi_system_id *d) >> +{ >> + printk(KERN_NOTICE PREFIX "DMI detected: %s\n", d->ident); >> + acpi_osi_setup(""); >> + return 0; >> +} > > What does this do to the rest of the function keys? Does everything > else still work as expected, including suspend and resume? > >> static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { >> { >> @@ -371,6 +382,15 @@ static struct dmi_system_id acpi_osi_dmi_table[] >> __initdata = { >> DMI_MATCH(DMI_PRODUCT_NAME, "1015PX"), >> }, >> }, >> + /* Without this brightness keys do not work */ >> + { >> + .callback = dmi_disable_osi_all, >> + .ident = "ASUSTeK COMPUTER INC. X200MA", >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), >> + DMI_MATCH(DMI_PRODUCT_NAME, "X200MA"), >> + }, >> + }, >> {} >> }; >> >> -- >> 1.9.1 >> -- >> To unsubscribe from this list: send the line "unsubscribe stable" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html