From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v1 for-4.6 1/2] xen/pvh: check permissions
 when adding MMIO regions
Date: Thu, 18 Dec 2014 19:05:09 +0000
Message-ID: <54932565.2020801@citrix.com>
References: <1418927225-60266-1-git-send-email-roger.pau@citrix.com>
	<1418927225-60266-2-git-send-email-roger.pau@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1Y1gOo-0002Xk-Dd
	for xen-devel@lists.xenproject.org; Thu, 18 Dec 2014 19:06:10 +0000
In-Reply-To: <1418927225-60266-2-git-send-email-roger.pau@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roger Pau Monne <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

T24gMTgvMTIvMTQgMTg6MjcsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBDaGVjayB0aGF0IE1N
SU8gcmVnaW9ucyBhZGRlZCB0byBQVkggRG9tMCBhcmUgYWxsb3dlZC4gUHJldmlvdXNseSBhIFBW
SCBEb20wCj4gd291bGQgaGF2ZSBhY2Nlc3MgdG8gdGhlIGZ1bGwgTU1JTyByYW5nZS4KPgo+IFNp
Z25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgo+IENj
OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+Cj4gQ2M6IEFuZHJldyBDb29wZXIgPGFu
ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4gLS0tCj4gIHhlbi9hcmNoL3g4Ni9kb21haW5fYnVp
bGQuYyB8IDMxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5n
ZWQsIDMxIGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWlu
X2J1aWxkLmMgYi94ZW4vYXJjaC94ODYvZG9tYWluX2J1aWxkLmMKPiBpbmRleCA3YTZhZmVhLi5h
YTNiZjBmIDEwMDY0NAo+IC0tLSBhL3hlbi9hcmNoL3g4Ni9kb21haW5fYnVpbGQuYwo+ICsrKyBi
L3hlbi9hcmNoL3g4Ni9kb21haW5fYnVpbGQuYwo+IEBAIC0zMTIsMTYgKzMxMiw0NyBAQCBzdGF0
aWMgX19pbml0IHZvaWQgcHZoX2FkZF9tZW1fbWFwcGluZyhzdHJ1Y3QgZG9tYWluICpkLCB1bnNp
Z25lZCBsb25nIGdmbiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
dW5zaWduZWQgbG9uZyBtZm4sIHVuc2lnbmVkIGxvbmcgbnJfbWZucykKPiAgewo+ICAgICAgdW5z
aWduZWQgbG9uZyBpOwo+ICsgICAgeGVubWVtX2FjY2Vzc190IGRlZl9hY2Nlc3M7Cj4gKyAgICBi
b29sX3Qgcl9vbmx5ID0gZmFsc2U7Cj4gICAgICBpbnQgcmM7Cj4gIAo+ICAgICAgZm9yICggaSA9
IDA7IGkgPCBucl9tZm5zOyBpKysgKQo+ICAgICAgewo+ICsgICAgICAgIGlmICggIWlvbWVtX2Fj
Y2Vzc19wZXJtaXR0ZWQoZCwgbWZuICsgaSwgbWZuICsgaSkgKQo+ICsgICAgICAgICAgICBnb3Rv
IG5leHQ7Cj4gKwo+ICsgICAgICAgIGlmICggcmFuZ2VzZXRfY29udGFpbnNfc2luZ2xldG9uKG1t
aW9fcm9fcmFuZ2VzLCBtZm4gKyBpKSAmJiAhcl9vbmx5ICkKPiArICAgICAgICB7Cj4gKyAgICAg
ICAgICAgIHJjID0gcDJtX2dldF9tZW1fYWNjZXNzKGQsIH4wdWwsICZkZWZfYWNjZXNzKTsKPiAr
ICAgICAgICAgICAgQlVHX09OKHJjKTsKPiArICAgICAgICAgICAgLyogU2V0IGRlZmF1bHQgYWNj
ZXNzIHRvIHJlYWQtb25seSAqLwo+ICsgICAgICAgICAgICByYyA9IHAybV9zZXRfbWVtX2FjY2Vz
cyhkLCB+MHVsLCAwLCAwLCAwLCBYRU5NRU1fYWNjZXNzX3IpOwo+ICsgICAgICAgICAgICBCVUdf
T04ocmMpOwo+ICsgICAgICAgICAgICByX29ubHkgPSB0cnVlOwo+ICsgICAgICAgIH0KPiArICAg
ICAgICBlbHNlIGlmICggcl9vbmx5ICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIC8qIFNl
dCB0aGUgZGVmYXVsdCBiYWNrICovCj4gKyAgICAgICAgICAgIHJjID0gcDJtX3NldF9tZW1fYWNj
ZXNzKGQsIH4wdWwsIDAsIDAsIDAsIGRlZl9hY2Nlc3MpOwo+ICsgICAgICAgICAgICBCVUdfT04o
cmMpOwo+ICsgICAgICAgICAgICByX29ubHkgPSBmYWxzZTsKPiArICAgICAgICB9CgpBbSBJIG1p
c3Npbmcgc29tZXRoaW5nIG9idmlvdXMsIG9yIHdvdWxkIGFsbCB0aGlzIHJfb25seSBqdWdnbGlu
ZyBiZSBmYXIKbW9yZSBlYXN5IGlmIHNldF9tbWlvX3AybV9lbnRyeSgpIGhhZCBhIHJvL3J3IGJv
b2xlYW4gcGFyYW1ldGVyPwoKQXMgdGhlc2UgZW50cmllcyBhcmUgZG9uZSBvbmUgYXQgYSB0aW1l
LCBpdCB3b3VsZCBzZWVtIHRvIGJlIGZhciBsZXNzCmVycm9yIHByb25lIHRvIGV4cGxpY2l0bHkg
Y2hvb3NlIGEgcmVhZC1vbmx5IG9yIHJlYWQtd3JpdGUgbW1pbyBtYXBwaW5nLApyYXRoZXIgdGhh
biBwbGF5aW5nIHdpdGggdGhlIGVudGlyZSBkZWZhdWx0LgoKPiArCj4gICAgICAgICAgaWYgKCAo
cmMgPSBzZXRfbW1pb19wMm1fZW50cnkoZCwgZ2ZuICsgaSwgX21mbihtZm4gKyBpKSkpICkKPiAg
ICAgICAgICAgICAgcGFuaWMoInB2aF9hZGRfbWVtX21hcHBpbmc6IGdmbjolbHggbWZuOiVseCBp
OiVsZCByYzolZFxuIiwKPiAgICAgICAgICAgICAgICAgICAgZ2ZuLCBtZm4sIGksIHJjKTsKPiAr
Cj4gKyBuZXh0Ogo+ICAgICAgICAgIGlmICggIShpICYgMHhmZmZmZikgKQo+ICAgICAgICAgICAg
ICAgICAgcHJvY2Vzc19wZW5kaW5nX3NvZnRpcnFzKCk7CgpZb3UgY291bGQgcmVtb3ZlIHRoZSBu
ZXh0IGxhYmVsIGJ5IG1vdmluZyB0aGlzIGNsYXVzZSB0byB0aGUgdG9wIGFuZAphZGRpbmcgYW4g
aSAhPSAwIGNoZWNrLgoKPiAgICAgIH0KPiArCj4gKyAgICBpZiAoIHJfb25seSApCj4gKyAgICB7
Cj4gKyAgICAgICAgLyogU2V0IHRoZSBkZWZhdWx0IGJhY2sgKi8KPiArICAgICAgICByYyA9IHAy
bV9zZXRfbWVtX2FjY2VzcyhkLCB+MHVsLCAwLCAwLCAwLCBkZWZfYWNjZXNzKTsKClRoaXMgd2ls
bCBjbG9iYmVyIHRoZSBwMm0gZGVmYXVsdCBhY2Nlc3MgdHlwZSBiYXNlZCBvbiB3aGV0aGVyIHRo
ZSBmaW5hbAptZm4gaXMgcmVhZC1vbmx5IG9yIHJlYWQtd3JpdGUuCgp+QW5kcmV3Cgo+ICsgICAg
ICAgIEJVR19PTihyYyk7Cj4gKyAgICB9Cj4gIH0KPiAgCj4gIC8qCgoKCl9fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QK
WGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==