From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1w08-0001xg-OI for qemu-devel@nongnu.org; Fri, 19 Dec 2014 06:45:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1w03-0004hu-Kp for qemu-devel@nongnu.org; Fri, 19 Dec 2014 06:45:44 -0500 Received: from relay.parallels.com ([195.214.232.42]:57742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1w03-0004Hx-88 for qemu-devel@nongnu.org; Fri, 19 Dec 2014 06:45:39 -0500 Message-ID: <54940FA0.1010606@parallels.com> Date: Fri, 19 Dec 2014 14:44:32 +0300 From: Vladimir Sementsov-Ogievskiy MIME-Version: 1.0 References: <1418298924-4173-1-git-send-email-vsementsov@parallels.com> <1418298924-4173-2-git-send-email-vsementsov@parallels.com> <5489B333.8060502@redhat.com> In-Reply-To: <5489B333.8060502@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block-migration: fix pending() return value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, den@openvz.org, stefanha@redhat.com Hi there.. Can someone review my bug fix? I'll surely fix typos in description after it. Best regards, Vladimir On 11.12.2014 18:07, Eric Blake wrote: > On 12/11/2014 04:55 AM, Vladimir Sementsov-Ogievskiy wrote: >> Because of wrong return value of .save_live_pending() in >> block-migration, migration finishes before the whole disk >> is transferred. Such situation occures when the migration > s/occures/occurs/ > >> process is fast enouth, for example when source and dest > s/enouth/enough/ > >> are on the same host. >> >> If in the bulk phase we return something < max_size, we will skip >> transferring the tail of the device. Currently we have "set pending to >> BLOCK_SIZE if it is zero" for bulk phase, but there no guarantee, that >> it will be < max_size. >> >> True approach is to return, for example, max_size+1 when we are in the >> bulk phase. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> block-migration.c | 4 ++-- > I'll let someone else review the code proper. >