From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y77Qr-0005ik-Q8 for qemu-devel@nongnu.org; Fri, 02 Jan 2015 13:58:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y77Qm-0004BA-S0 for qemu-devel@nongnu.org; Fri, 02 Jan 2015 13:58:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y77Qm-0004B6-KE for qemu-devel@nongnu.org; Fri, 02 Jan 2015 13:58:40 -0500 Message-ID: <54A6EA59.3000106@redhat.com> Date: Fri, 02 Jan 2015 13:58:33 -0500 From: John Snow MIME-Version: 1.0 References: <1419692504-29373-1-git-send-email-peter@lekensteyn.nl> <20150102141421.GM10823@stefanha-thinkpad.redhat.com> <54A6C7E5.10904@redhat.com> <7AE70E8E-E3F8-4AB2-B2E0-61B0A1FD3623@lekensteyn.nl> In-Reply-To: <7AE70E8E-E3F8-4AB2-B2E0-61B0A1FD3623@lekensteyn.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 00/10] block/dmg: (compatibility) fixes and bzip2 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Wu Cc: Kevin Wolf , Stefan Hajnoczi , qemu-devel@nongnu.org On 01/02/2015 01:46 PM, Peter Wu wrote: > FYI, I plan to make some more changes: > > - do not require offset =E2=89=A0 0 for resource fork and XML offsets. = Technically it is allowed, do you agree on this change? If you have seen this in the wild, I definitely agree. If you haven't, I=20 am not against the change, but there's likely no hurry to include it in=20 this series if the changes are not simple. > - improve offset checking https://git.lekensteyn.nl/peter/qemu/commit/?= h=3Dblock-dmg-2.3&id=3D41fd83773361923f668f54796ff563660b77e96c (squash w= ith the existing length checking patch) > > - (not part of this series, but for future consideration) read errors c= urrently return 1 (EPERM). EIO or EINVAL would probably a better choice d= epending on the error type. > > Other than that, the patches should be ready for review. Thank you in a= dvance. > > Kind regards, > Peter > https://lekensteyn.nl > (pardon my brevity, top-posting and formatting, sent from my phone) > > > On January 2, 2015 5:31:33 PM CET, John Snow wrote: >> >> >> On 01/02/2015 09:14 AM, Stefan Hajnoczi wrote: >>> On Sat, Dec 27, 2014 at 04:01:34PM +0100, Peter Wu wrote: >>>> These series improve QEMU support for DMG image files: >>> >>> Hi, >>> Thanks for this patch series. Kevin and I consider patches for >> merging >>> after they have a Reviewed-by: from at least 1 other QEMU >> contributor. >>> >>> I have CCed John Snow. >>> >>> John: If you are busy, please CC someone else or let us know so this >>> series can get reviewed. >>> >>> Stefan >>> >> >> Just recomposing myself post-vacation, I will start looking this over >> today. >> >> --John >