All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, linux-kernel@vger.kernel.org
Subject: Re: xen/x86: properly retrieve NMI reason
Date: Mon, 5 Jan 2015 10:35:04 +0000	[thread overview]
Message-ID: <54AA68D8.7050400__22250.1005548567$1420454226$gmane$org@citrix.com> (raw)
In-Reply-To: <54945D760200007800051157@mail.emea.novell.com>

On 19/12/14 16:16, Jan Beulich wrote:
> Using the native code here can't work properly, as the hypervisor would
> normally have cleared the two reason bits by the time Dom0 gets to see
> the NMI (if passed to it at all). There's a shared info field for this,
> and there's an existing hook to use - just fit the two together. Note
> that the hook can (and should) be used irrespective of whether being in
> Dom0, as accessing port 0x61 in a DomU would be even worse, while the
> shared info field would just hold zero all the time.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

This doesn't build.

In file included from
/local/davidvr/work/k.org/tip/arch/x86/xen/enlighten.c:43:0:
/local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: warning:
data definition has no type or storage class [enabled by default]
/local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: error:
type defaults to ‘int’ in declaration of ‘DEFINE_XEN_GUEST_HANDLE’
[-Werror=implicit-int]
cc1: some warnings being treated as errors

David

  parent reply	other threads:[~2015-01-05 10:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 16:16 xen/x86: properly retrieve NMI reason Jan Beulich
2014-12-19 16:45 ` Boris Ostrovsky
2014-12-19 16:45 ` Boris Ostrovsky
2014-12-23 11:01 ` David Vrabel
2014-12-23 11:01 ` [Xen-devel] " David Vrabel
2015-01-02 15:55   ` Jan Beulich
2015-01-02 15:55   ` [Xen-devel] " Jan Beulich
2015-01-05 10:35 ` David Vrabel [this message]
2015-01-05 10:35 ` David Vrabel
2015-01-06  8:53   ` Jan Beulich
2015-01-06  8:53     ` Jan Beulich
  -- strict thread matches above, loose matches on Subject: below --
2014-12-19 16:16 Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='54AA68D8.7050400__22250.1005548567$1420454226$gmane$org@citrix.com' \
    --to=david.vrabel@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.