All of lore.kernel.org
 help / color / mirror / Atom feed
* GCM aesni and 192/256-bit keys
@ 2015-01-05 10:06 Herbert Xu
  2015-01-05 17:51 ` Tadeusz Struk
  0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2015-01-05 10:06 UTC (permalink / raw)
  To: Tadeusz Struk, Linux Crypto Mailing List

Hi Tadeusz:

It appears that the GCM aesni implementation does not support
192/256-bit keys.  This is not allowed as accelerated drivers
must support everything supported by the software implementation.

Could we add 192/256-bit support to it please? If for some reason
this cannot be done then at least implement a software fallback
so that it continues to work.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: GCM aesni and 192/256-bit keys
  2015-01-05 10:06 GCM aesni and 192/256-bit keys Herbert Xu
@ 2015-01-05 17:51 ` Tadeusz Struk
  2015-01-06 23:18   ` Herbert Xu
  0 siblings, 1 reply; 3+ messages in thread
From: Tadeusz Struk @ 2015-01-05 17:51 UTC (permalink / raw)
  To: Herbert Xu, Linux Crypto Mailing List

On 01/05/2015 02:06 AM, Herbert Xu wrote:
> Hi Tadeusz:
> 
> It appears that the GCM aesni implementation does not support
> 192/256-bit keys.  This is not allowed as accelerated drivers
> must support everything supported by the software implementation.
> 
> Could we add 192/256-bit support to it please? If for some reason
> this cannot be done then at least implement a software fallback
> so that it continues to work.
> 
> Thanks,
> 

Hi Herbert,
Yes, you are right. I'll look into it.
Thanks,
Tadeusz

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: GCM aesni and 192/256-bit keys
  2015-01-05 17:51 ` Tadeusz Struk
@ 2015-01-06 23:18   ` Herbert Xu
  0 siblings, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2015-01-06 23:18 UTC (permalink / raw)
  To: Tadeusz Struk; +Cc: Linux Crypto Mailing List

On Mon, Jan 05, 2015 at 09:51:35AM -0800, Tadeusz Struk wrote:
> On 01/05/2015 02:06 AM, Herbert Xu wrote:
> > 
> > It appears that the GCM aesni implementation does not support
> > 192/256-bit keys.  This is not allowed as accelerated drivers
> > must support everything supported by the software implementation.
> > 
> > Could we add 192/256-bit support to it please? If for some reason
> > this cannot be done then at least implement a software fallback
> > so that it continues to work.

> Yes, you are right. I'll look into it.

While you're at it, can you please run some speed tests to show
that this is actually faster than the generic gcm on top of
ctr-aes-aesni and ghash-clmulni?

If it isn't any faster (it really shouldn't be as far as I can
see) then we can just kill it.

Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-06 23:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-05 10:06 GCM aesni and 192/256-bit keys Herbert Xu
2015-01-05 17:51 ` Tadeusz Struk
2015-01-06 23:18   ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.