From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v5 18/18] Documentation: ACPI for ARM64 Date: Tue, 06 Jan 2015 21:50:38 +0800 Message-ID: <54ABE82E.30308@linaro.org> References: <1413553034-20956-1-git-send-email-hanjun.guo@linaro.org> <1413553034-20956-19-git-send-email-hanjun.guo@linaro.org> <20141224171815.GD13399@e104818-lin.cambridge.arm.com> <54A90A4C.60908@linaro.org> <20150105110533.GA14967@e104818-lin.cambridge.arm.com> <54ABC2CB.6@linaro.org> <20150106112929.GB8829@e104818-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150106112929.GB8829@e104818-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Catalin Marinas Cc: Mark Rutland , "linaro-acpi@lists.linaro.org" , Will Deacon , Lv Zheng , Rob Herring , Lorenzo Pieralisi , Al Stone , Daniel Lezcano , Robert Moore , "linux-acpi@vger.kernel.org" , "jcm@redhat.com" , "grant.likely@linaro.org" , Charles Garcia-Tobin , Robert Richter , Jason Cooper , Arnd Bergmann , Marc Zyngier , Liviu Dudau , Mark Brown , Bjorn Helgaas , "linux-arm-kernel@lists.infradead.org" List-Id: linux-acpi@vger.kernel.org T24gMjAxNeW5tDAx5pyIMDbml6UgMTk6MjksIENhdGFsaW4gTWFyaW5hcyB3cm90ZToKPiBPbiBU dWUsIEphbiAwNiwgMjAxNSBhdCAxMToxMTowN0FNICswMDAwLCBIYW5qdW4gR3VvIHdyb3RlOgo+ PiBPbiAyMDE15bm0MDHmnIgwNeaXpSAxOTowNSwgQ2F0YWxpbiBNYXJpbmFzIHdyb3RlOgo+Pj4g T24gU3VuLCBKYW4gMDQsIDIwMTUgYXQgMDk6Mzk6MjRBTSArMDAwMCwgSGFuanVuIEd1byB3cm90 ZToKPj4+PiBPbiAyMDE05bm0MTLmnIgyNeaXpSAwMToxOCwgQ2F0YWxpbiBNYXJpbmFzIHdyb3Rl Ogo+Pj4+IFsuLi5dCj4+Pj4+Cj4+Pj4+IEluIGFkZGl0aW9uIHRvIHRoZSBhYm92ZSBhbmQgX0RT RCByZXF1aXJlbWVudHMvYmFubmluZywgSSB3b3VsZCBhbHNvIGFkZAo+Pj4+PiBzb21lIGNsZWFy IHN0YXRlbWVudHMgYXJvdW5kOgo+Pj4+Pgo+Pj4+PiBfT1NDOiBvbmx5IGdsb2JhbC9wdWJsaXNo ZWQgY2FwYWJpbGl0aWVzIGFyZSBhbGxvd2VkLiBGb3IKPj4+Pj4gZGV2aWNlLXNwZWNpZmljIF9P U0Mgd2UgbmVlZCBhIHByb2Nlc3Mgb3IgbWF5YmUgd2UgY2FuIGJhbiB0aGVtIGVudGlyZWx5Cj4+ Pj4+IGFuZCByZWx5IG9uIF9EU0Qgb25jZSB3ZSBjbGFyaWZ5IHRoZSBwcm9jZXNzLgo+Pj4+Pgo+ Pj4+PiBfT1NJOiBmaXJtd2FyZSBtdXN0IG5vdCBjaGVjayBmb3IgY2VydGFpbiBfT1NJIHN0cmlu Z3MuIEhlcmUgSSdtIG5vdAo+Pj4+PiBzdXJlIHdoYXQgd2Ugd291bGQgaGF2ZSB0byBkbyBmb3Ig QVJNIExpbnV4LiBSZXBvcnRpbmcgIldpbmRvd3MiIGRvZXMKPj4+Pj4gbm90IG1ha2UgYW55IHNl bnNlIGJ1dCBub3QgcmVwb3J0aW5nIGFueXRoaW5nIGNhbiwgYXMgTWF0dGhldyBHYXJyZXR0Cj4+ Pj4+IHBvaW50ZWQgb3V0LCBjYW4gYmUgaW50ZXJwcmV0ZWQgYnkgZmlybXdhcmUgYXMgIkxpbnV4 Ii4gSW4gYWRkaXRpb24gdG8KPj4+Pj4gYW55IHN0YXRlbWVudHMgaW4gdGhpcyBkb2N1bWVudCwg SSBzdWdnZXN0IHlvdSBwYXRjaAo+Pj4+PiBkcml2ZXJzL2FjcGkvYWNwaWNhL3V0b3NpLmMgYWNj b3JkaW5nbHksIG1heWJlIHJlcG9ydCAiTGludXgiIGZvciBBUk0KPj4+Pj4gYW5kIHByaW50IGEg a2VybmVsIHdhcm5pbmcgc28gdGhhdCB3ZSBub3RpY2UgZWFybGllci4KPj4+Pj4KPj4+Pj4gQUNQ SV9PU19OQU1FOiB0aGlzIGlzIGdsb2JhbGx5IGRlZmluZWQgYXMgIk1pY3Jvc29mdCBXaW5kb3dz IE5UIi4gSXQKPj4+Pj4gZG9lc24ndCBtYWtlIG11Y2ggc2Vuc2UgaW4gdGhlIEFSTSBjb250ZXh0 LiBDb3VsZCB3ZSBjaGFuZ2UgaXQgdG8KPj4+Pj4gIkxpbnV4IiB3aGVuIENPTkZJR19BUk02ND8K Pj4KPj4gSSB0aGluayB3ZSBjYW4gaW50cm9kdWNlIGEgS2NvbmZpZyBzdWNoIGFzIENPTkZJR19B Q1BJX09TX05BTUVfTElOVVgsCj4+IHNlbGVjdGVkIGJ5IEFSTTY0IGFuZCBjaGFuZ2UgQUNQSV9P U19OQU1FIHRvICJMaW51eCIgd2hlbgo+PiBDT05GSUdfQUNQSV9PU19OQU1FX0xJTlVYIGRlZmlu ZWQuICh3ZSBjYW4gbm90IGFkZCBDT05GSUdfQVJNNjQgaW4KPj4gQUNQSUNBIGNvZGUgZGlyZWN0 bHkgc2luY2UgaXQgd2lsbCBiZSB1c2VkIGJ5IHdpbmRvd3MgdG9vKQo+Pgo+PiBzb21lIGNvZGUg bGlrZSBiZWxvdzoKPgo+IFRoaXMgbG9va3MgZmluZSBmb3IgbWUgKHdpdGggc29tZSBtaW5vciBj b21tZW50cyBiZWxvdykgYnV0IEknbSBub3QgYW4KPiBBQ1BJIGV4cGVydCB0byBzYXkgdGhlcmUg d291bGRuJ3QgYmUgYW55IGlzc3Vlcy4KPgo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9LY29u ZmlnIGIvYXJjaC9hcm02NC9LY29uZmlnCj4+IGluZGV4IGIxZjlhMjAuLmRlNTY3YTMgMTAwNjQ0 Cj4+IC0tLSBhL2FyY2gvYXJtNjQvS2NvbmZpZwo+PiArKysgYi9hcmNoL2FybTY0L0tjb25maWcK Pj4gQEAgLTEsNSArMSw2IEBACj4+ICAgIGNvbmZpZyBBUk02NAo+PiAgICAgICAgICAgZGVmX2Jv b2wgeQo+PiArICAgICAgIHNlbGVjdCBBQ1BJX09TX05BTUVfTElOVVggaWYgQUNQSQo+PiAgICAg ICAgICAgc2VsZWN0IEFSQ0hfQklORk1UX0VMRl9SQU5ET01JWkVfUElFCj4+ICAgICAgICAgICBz ZWxlY3QgQVJDSF9IQVNfQVRPTUlDNjRfREVDX0lGX1BPU0lUSVZFCj4+ICAgICAgICAgICBzZWxl Y3QgQVJDSF9IQVNfR0NPVl9QUk9GSUxFX0FMTAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hY3Bp L0tjb25maWcgYi9kcml2ZXJzL2FjcGkvS2NvbmZpZwo+PiBpbmRleCA4OTUxY2VmLi4xMWExMGFj IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2FjcGkvS2NvbmZpZwo+PiArKysgYi9kcml2ZXJzL2Fj cGkvS2NvbmZpZwo+PiBAQCAtMzY5LDYgKzM2OSwxMCBAQCBjb25maWcgQUNQSV9SRURVQ0VEX0hB UkRXQVJFX09OTFkKPj4KPj4gICAgICAgICAgICAgSWYgeW91IGFyZSB1bnN1cmUgd2hhdCB0byBk bywgZG8gbm90IGVuYWJsZSB0aGlzIG9wdGlvbi4KPj4KPj4gK2NvbmZpZyBBQ1BJX09TX05BTUVf TElOVVgKPj4gKyAgICAgICBib29sICJVc2luZyBMaW51eCBmb3IgX09TIG1ldGhvZCIgaWYgRVhQ RVJUCj4+ICsgICAgICAgZGVmX2Jvb2wgbgo+Cj4gTm8gbmVlZCBmb3IgYSBkZWZhdWx0IG4sIGl0 IGlzIG9mZiBieSBkZWZhdWx0LiBBbHRlcm5hdGl2ZWx5IHlvdSBjb3VsZAo+IHNheToKPgo+IAlk ZWZhdWx0IHkgaWYgQVJNNjQKCm9rLgoKPgo+PiArCj4+ICAgIHNvdXJjZSAiZHJpdmVycy9hY3Bp L2FwZWkvS2NvbmZpZyIKPj4KPj4gICAgY29uZmlnIEFDUElfRVhUTE9HCj4+IGRpZmYgLS1naXQg YS9pbmNsdWRlL2FjcGkvYWNjb25maWcuaCBiL2luY2x1ZGUvYWNwaS9hY2NvbmZpZy5oCj4+IGlu ZGV4IDVhMGEzZTUuLmRiNWUxM2UgMTAwNjQ0Cj4+IC0tLSBhL2luY2x1ZGUvYWNwaS9hY2NvbmZp Zy5oCj4+ICsrKyBiL2luY2x1ZGUvYWNwaS9hY2NvbmZpZy5oCj4+IEBAIC02OSw3ICs2OSwxMSBA QAo+PiAgICAgKiBjb2RlIHRoYXQgd2lsbCBub3QgZXhlY3V0ZSB0aGUgX09TSSBtZXRob2QgdW5s ZXNzIF9PUyBtYXRjaGVzIHRoZQo+PiBzdHJpbmcKPj4gICAgICogYmVsb3cuICBUaGVyZWZvcmUs IGNoYW5nZSB0aGlzIHN0cmluZyBhdCB5b3VyIG93biByaXNrLgo+PiAgICAgKi8KPj4gKyNpZm5k ZWYgQUNQSV9PU19OQU1FX1VTSU5HX0xJTlVYCj4+ICAgICNkZWZpbmUgQUNQSV9PU19OQU1FICAg ICAgICAgICAgICAgICAgICAiTWljcm9zb2Z0IFdpbmRvd3MgTlQiCj4+ICsjZWxzZQo+PiArI2Rl ZmluZSBBQ1BJX09TX05BTUUgICAgICAgICAgICAgICAgICAgICJMaW51eCIKPj4gKyNlbmRpZgo+ Cj4gQ2FuIHlvdSBub3QgdXNlIENPTkZJR19BQ1BJX09TX05BTUVfTElOVVggZGlyZWN0bHkgaGVy ZSB3aXRob3V0Cj4gaW50cm9kdWNpbmcgYW5vdGhlciBtYWNybz8KCmFjY29uZmlnLmggaXMgcGFy dCBvZiBBQ1BJQ0EgY29yZSBhbmQgd2lsbCBiZSBzaGFyZWQgYnkgd2luZG93cyBhbmQKb3RoZXIg T1MsIHNvIHVzZSBDT05GSUcgZnJvbSBMaW51eCBpbiB0aGlzIGZpbGUgaXMgbm90IGFsbG93ZWQg SSB0aGluay4KCj4KPj4+PiBXZSB3aWxsIHdvcmsgb24gdGhpcyBib3RoIG9uIEFTV0cgYW5kIGxp bnV4IEFDUEkgZHJpdmVyIHNpZGUsIGFzIERvbmcKPj4+PiBhbmQgQ2hhcmxlcyBwb2ludGVkIG91 dCwgX09TSSB0aGluZ3MgY2FuIGJlIHNvbHZlZCBpbiBBQ1BJIHNwZWMsIHdoZW4KPj4+PiB0aGF0 IGlzIGRvbmUsIHdlIGNhbiBtb2RpZnkgdGhlIGtlcm5lbCBkcml2ZXIgdG8gZml4IHRoZSBwcm9i bGVtcyBhYm92ZS4KPj4+Cj4+PiBXaGljaCBkcml2ZXI/Cj4+Cj4+IHRoZSBBQ1BJQ0EgY29yZSBk cml2ZXIgYXMgeW91IHN1Z2dlc3RlZCwgc29ycnkgZm9yIHRoZSBjb25mdXNpb24uCj4+Cj4+PiBX aGF0IGFib3V0IEFDUElfT1NfTkFNRT8gV291bGQgeW91IHN1Z2dlc3QgaXQgaXMgZmluZSB0byBy ZXBvcnQKPj4+ICJNaWNyb3NvZnQgV2luZG93cyBOVCIgb24gYW4gQVJNIHN5c3RlbT8gVGhhdCBf T1NfIG5vdCBfT1NJLgo+Pgo+PiBObywgbm90IGF0IGFsbC4gSSBwcmVmZXIgIkxpbnV4Igo+PiBJ biBpbmNsdWRlL2FjcGkvYWNjb25maWcuaCwgd2hlbiBBQ1BJX09TX05BTUUgZGVmaW5lZCwgaXQg c2F5czoKPj4gIk9TIG5hbWUsIHVzZWQgZm9yIHRoZSBfT1Mgb2JqZWN0LiAgVGhlIF9PUyBvYmpl Y3QgaXMgZXNzZW50aWFsbHkKPj4gb2Jzb2xldGUsLi4uIgo+PiBmb3Igc29tZSBsZWdhY3kgcmVh c29ucywgd2UgbmVlZGVkICAiTWljcm9zb2Z0IFdpbmRvd3MgTlQiLCBidXQgQUNQSQo+PiBmb3Ig QVJNNjQgb24gbGludXggaXMgdG90YWxseSBuZXcsIEkgdGhpbmsgd2UgY2FuIGNoYW5nZSBpdCB0 bwo+PiAiTGludXgiIHdoZW4gQ09ORklHX0FSTTY0IGFzIHlvdSBzdWdnZXN0ZWQuCj4KPiBXZSBj b3VsZCBpZ25vcmUgdGhpcyBjaGFuZ2UgZm9yIG5vdyBpZiB3ZSBkb24ndCBleHBlY3QgdGhlIF9P UyBvYmplY3QgdG8KPiBiZSB1c2VkIGF0IGFsbC4gQnV0IGRvIHdlIGhhdmUgYW55IG90aGVyIHdh eSB0byBjaGVjayB0aGUgQU1MIGNvZGUgZm9yCj4gdGhpcz8gV291bGQgRldUUyBjYXRjaCBzdWNo IG9ic29sZXRlIGNhc2VzPwoKSSdtIG5vdCBzdXJlLCBJIHdpbGwgY2hlY2sgaXQgYW5kIGdldCBi YWNrIHdoZW4gSSBoYXZlIHRoZSBhbnN3ZXIuCgpUaGFua3MKSGFuanVuCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755518AbbAFNvH (ORCPT ); Tue, 6 Jan 2015 08:51:07 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:62551 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754501AbbAFNvF (ORCPT ); Tue, 6 Jan 2015 08:51:05 -0500 Message-ID: <54ABE82E.30308@linaro.org> Date: Tue, 06 Jan 2015 21:50:38 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Catalin Marinas CC: "Rafael J. Wysocki" , Mark Rutland , Olof Johansson , "grant.likely@linaro.org" , Will Deacon , "graeme.gregory@linaro.org" , Arnd Bergmann , Sudeep Holla , "jcm@redhat.com" , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "Kangkang.Shen@huawei.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , Al Stone Subject: Re: [PATCH v5 18/18] Documentation: ACPI for ARM64 References: <1413553034-20956-1-git-send-email-hanjun.guo@linaro.org> <1413553034-20956-19-git-send-email-hanjun.guo@linaro.org> <20141224171815.GD13399@e104818-lin.cambridge.arm.com> <54A90A4C.60908@linaro.org> <20150105110533.GA14967@e104818-lin.cambridge.arm.com> <54ABC2CB.6@linaro.org> <20150106112929.GB8829@e104818-lin.cambridge.arm.com> In-Reply-To: <20150106112929.GB8829@e104818-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年01月06日 19:29, Catalin Marinas wrote: > On Tue, Jan 06, 2015 at 11:11:07AM +0000, Hanjun Guo wrote: >> On 2015年01月05日 19:05, Catalin Marinas wrote: >>> On Sun, Jan 04, 2015 at 09:39:24AM +0000, Hanjun Guo wrote: >>>> On 2014年12月25日 01:18, Catalin Marinas wrote: >>>> [...] >>>>> >>>>> In addition to the above and _DSD requirements/banning, I would also add >>>>> some clear statements around: >>>>> >>>>> _OSC: only global/published capabilities are allowed. For >>>>> device-specific _OSC we need a process or maybe we can ban them entirely >>>>> and rely on _DSD once we clarify the process. >>>>> >>>>> _OSI: firmware must not check for certain _OSI strings. Here I'm not >>>>> sure what we would have to do for ARM Linux. Reporting "Windows" does >>>>> not make any sense but not reporting anything can, as Matthew Garrett >>>>> pointed out, can be interpreted by firmware as "Linux". In addition to >>>>> any statements in this document, I suggest you patch >>>>> drivers/acpi/acpica/utosi.c accordingly, maybe report "Linux" for ARM >>>>> and print a kernel warning so that we notice earlier. >>>>> >>>>> ACPI_OS_NAME: this is globally defined as "Microsoft Windows NT". It >>>>> doesn't make much sense in the ARM context. Could we change it to >>>>> "Linux" when CONFIG_ARM64? >> >> I think we can introduce a Kconfig such as CONFIG_ACPI_OS_NAME_LINUX, >> selected by ARM64 and change ACPI_OS_NAME to "Linux" when >> CONFIG_ACPI_OS_NAME_LINUX defined. (we can not add CONFIG_ARM64 in >> ACPICA code directly since it will be used by windows too) >> >> some code like below: > > This looks fine for me (with some minor comments below) but I'm not an > ACPI expert to say there wouldn't be any issues. > >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index b1f9a20..de567a3 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -1,5 +1,6 @@ >> config ARM64 >> def_bool y >> + select ACPI_OS_NAME_LINUX if ACPI >> select ARCH_BINFMT_ELF_RANDOMIZE_PIE >> select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE >> select ARCH_HAS_GCOV_PROFILE_ALL >> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig >> index 8951cef..11a10ac 100644 >> --- a/drivers/acpi/Kconfig >> +++ b/drivers/acpi/Kconfig >> @@ -369,6 +369,10 @@ config ACPI_REDUCED_HARDWARE_ONLY >> >> If you are unsure what to do, do not enable this option. >> >> +config ACPI_OS_NAME_LINUX >> + bool "Using Linux for _OS method" if EXPERT >> + def_bool n > > No need for a default n, it is off by default. Alternatively you could > say: > > default y if ARM64 ok. > >> + >> source "drivers/acpi/apei/Kconfig" >> >> config ACPI_EXTLOG >> diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h >> index 5a0a3e5..db5e13e 100644 >> --- a/include/acpi/acconfig.h >> +++ b/include/acpi/acconfig.h >> @@ -69,7 +69,11 @@ >> * code that will not execute the _OSI method unless _OS matches the >> string >> * below. Therefore, change this string at your own risk. >> */ >> +#ifndef ACPI_OS_NAME_USING_LINUX >> #define ACPI_OS_NAME "Microsoft Windows NT" >> +#else >> +#define ACPI_OS_NAME "Linux" >> +#endif > > Can you not use CONFIG_ACPI_OS_NAME_LINUX directly here without > introducing another macro? acconfig.h is part of ACPICA core and will be shared by windows and other OS, so use CONFIG from Linux in this file is not allowed I think. > >>>> We will work on this both on ASWG and linux ACPI driver side, as Dong >>>> and Charles pointed out, _OSI things can be solved in ACPI spec, when >>>> that is done, we can modify the kernel driver to fix the problems above. >>> >>> Which driver? >> >> the ACPICA core driver as you suggested, sorry for the confusion. >> >>> What about ACPI_OS_NAME? Would you suggest it is fine to report >>> "Microsoft Windows NT" on an ARM system? That _OS_ not _OSI. >> >> No, not at all. I prefer "Linux" >> In include/acpi/acconfig.h, when ACPI_OS_NAME defined, it says: >> "OS name, used for the _OS object. The _OS object is essentially >> obsolete,..." >> for some legacy reasons, we needed "Microsoft Windows NT", but ACPI >> for ARM64 on linux is totally new, I think we can change it to >> "Linux" when CONFIG_ARM64 as you suggested. > > We could ignore this change for now if we don't expect the _OS object to > be used at all. But do we have any other way to check the AML code for > this? Would FWTS catch such obsolete cases? I'm not sure, I will check it and get back when I have the answer. Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Tue, 06 Jan 2015 21:50:38 +0800 Subject: [PATCH v5 18/18] Documentation: ACPI for ARM64 In-Reply-To: <20150106112929.GB8829@e104818-lin.cambridge.arm.com> References: <1413553034-20956-1-git-send-email-hanjun.guo@linaro.org> <1413553034-20956-19-git-send-email-hanjun.guo@linaro.org> <20141224171815.GD13399@e104818-lin.cambridge.arm.com> <54A90A4C.60908@linaro.org> <20150105110533.GA14967@e104818-lin.cambridge.arm.com> <54ABC2CB.6@linaro.org> <20150106112929.GB8829@e104818-lin.cambridge.arm.com> Message-ID: <54ABE82E.30308@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?01?06? 19:29, Catalin Marinas wrote: > On Tue, Jan 06, 2015 at 11:11:07AM +0000, Hanjun Guo wrote: >> On 2015?01?05? 19:05, Catalin Marinas wrote: >>> On Sun, Jan 04, 2015 at 09:39:24AM +0000, Hanjun Guo wrote: >>>> On 2014?12?25? 01:18, Catalin Marinas wrote: >>>> [...] >>>>> >>>>> In addition to the above and _DSD requirements/banning, I would also add >>>>> some clear statements around: >>>>> >>>>> _OSC: only global/published capabilities are allowed. For >>>>> device-specific _OSC we need a process or maybe we can ban them entirely >>>>> and rely on _DSD once we clarify the process. >>>>> >>>>> _OSI: firmware must not check for certain _OSI strings. Here I'm not >>>>> sure what we would have to do for ARM Linux. Reporting "Windows" does >>>>> not make any sense but not reporting anything can, as Matthew Garrett >>>>> pointed out, can be interpreted by firmware as "Linux". In addition to >>>>> any statements in this document, I suggest you patch >>>>> drivers/acpi/acpica/utosi.c accordingly, maybe report "Linux" for ARM >>>>> and print a kernel warning so that we notice earlier. >>>>> >>>>> ACPI_OS_NAME: this is globally defined as "Microsoft Windows NT". It >>>>> doesn't make much sense in the ARM context. Could we change it to >>>>> "Linux" when CONFIG_ARM64? >> >> I think we can introduce a Kconfig such as CONFIG_ACPI_OS_NAME_LINUX, >> selected by ARM64 and change ACPI_OS_NAME to "Linux" when >> CONFIG_ACPI_OS_NAME_LINUX defined. (we can not add CONFIG_ARM64 in >> ACPICA code directly since it will be used by windows too) >> >> some code like below: > > This looks fine for me (with some minor comments below) but I'm not an > ACPI expert to say there wouldn't be any issues. > >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index b1f9a20..de567a3 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -1,5 +1,6 @@ >> config ARM64 >> def_bool y >> + select ACPI_OS_NAME_LINUX if ACPI >> select ARCH_BINFMT_ELF_RANDOMIZE_PIE >> select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE >> select ARCH_HAS_GCOV_PROFILE_ALL >> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig >> index 8951cef..11a10ac 100644 >> --- a/drivers/acpi/Kconfig >> +++ b/drivers/acpi/Kconfig >> @@ -369,6 +369,10 @@ config ACPI_REDUCED_HARDWARE_ONLY >> >> If you are unsure what to do, do not enable this option. >> >> +config ACPI_OS_NAME_LINUX >> + bool "Using Linux for _OS method" if EXPERT >> + def_bool n > > No need for a default n, it is off by default. Alternatively you could > say: > > default y if ARM64 ok. > >> + >> source "drivers/acpi/apei/Kconfig" >> >> config ACPI_EXTLOG >> diff --git a/include/acpi/acconfig.h b/include/acpi/acconfig.h >> index 5a0a3e5..db5e13e 100644 >> --- a/include/acpi/acconfig.h >> +++ b/include/acpi/acconfig.h >> @@ -69,7 +69,11 @@ >> * code that will not execute the _OSI method unless _OS matches the >> string >> * below. Therefore, change this string at your own risk. >> */ >> +#ifndef ACPI_OS_NAME_USING_LINUX >> #define ACPI_OS_NAME "Microsoft Windows NT" >> +#else >> +#define ACPI_OS_NAME "Linux" >> +#endif > > Can you not use CONFIG_ACPI_OS_NAME_LINUX directly here without > introducing another macro? acconfig.h is part of ACPICA core and will be shared by windows and other OS, so use CONFIG from Linux in this file is not allowed I think. > >>>> We will work on this both on ASWG and linux ACPI driver side, as Dong >>>> and Charles pointed out, _OSI things can be solved in ACPI spec, when >>>> that is done, we can modify the kernel driver to fix the problems above. >>> >>> Which driver? >> >> the ACPICA core driver as you suggested, sorry for the confusion. >> >>> What about ACPI_OS_NAME? Would you suggest it is fine to report >>> "Microsoft Windows NT" on an ARM system? That _OS_ not _OSI. >> >> No, not at all. I prefer "Linux" >> In include/acpi/acconfig.h, when ACPI_OS_NAME defined, it says: >> "OS name, used for the _OS object. The _OS object is essentially >> obsolete,..." >> for some legacy reasons, we needed "Microsoft Windows NT", but ACPI >> for ARM64 on linux is totally new, I think we can change it to >> "Linux" when CONFIG_ARM64 as you suggested. > > We could ignore this change for now if we don't expect the _OS object to > be used at all. But do we have any other way to check the AML code for > this? Would FWTS catch such obsolete cases? I'm not sure, I will check it and get back when I have the answer. Thanks Hanjun