From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8b0V-00007Z-Am for qemu-devel@nongnu.org; Tue, 06 Jan 2015 15:45:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8b0S-0003kK-5g for qemu-devel@nongnu.org; Tue, 06 Jan 2015 15:45:39 -0500 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:50437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8b0R-0003kD-Up for qemu-devel@nongnu.org; Tue, 06 Jan 2015 15:45:36 -0500 Received: by mail-wg0-f43.google.com with SMTP id k14so9697wgh.30 for ; Tue, 06 Jan 2015 12:45:35 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54AC496B.70501@redhat.com> Date: Tue, 06 Jan 2015 21:45:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1420550957-22337-1-git-send-email-marcel@redhat.com> <1420550957-22337-6-git-send-email-marcel@redhat.com> In-Reply-To: <1420550957-22337-6-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, agraf@suse.de, stefanha@redhat.com, lersek@redhat.com, afaerber@suse.de, rth@twiddle.net On 06/01/2015 14:29, Marcel Apfelbaum wrote: > @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine) > /* Graphics */ > if (spapr_vga_init(phb->bus)) { > spapr->has_graphics = true; > + machine->usb |= defaults_enabled(); > } Could the solution be to do this in instance_init? Then you would have patches 2, 4, 5, 6, 3 (patch 1 would not be needed anymore). Paolo