All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcel Apfelbaum <marcel@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com, agraf@suse.de,
	stefanha@redhat.com, lersek@redhat.com, afaerber@suse.de,
	rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic
Date: Wed, 07 Jan 2015 12:07:41 +0100	[thread overview]
Message-ID: <54AD137D.4030209@redhat.com> (raw)
In-Reply-To: <54AD1271.1080202@redhat.com>



On 07/01/2015 12:03, Marcel Apfelbaum wrote:
> 
> While I agree it will be better if we place this in instance_init,
> setting the machine_usb to defaults_enabled() there would be problematic
> since it depends on
>  - papr_vga_init(phb->bus) for sparpr and

That's effectively vga_interface_type == VGA_DEVICE ||
vga_interface_type == VGA_STD.

>  - (PPC_INPUT(env) == PPC_FLAGS_INPUT_970) for mac99.
>    (The env itself is set in machine_init)

Alex, why is auto-USB disabled for 6xx?  Can it use vga_interface_type
like spapr does?

Paolo

> Both of those conditions may be available only at machine_init time,
> and I am not sure how it would affect those machines.

  reply	other threads:[~2015-01-07 13:36 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 13:29 [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines Marcel Apfelbaum
2015-01-06 21:46   ` Alexander Graf
2015-01-06 13:29 ` [Qemu-devel] [PATCH 2/6] hw/machine: added machine_usb wrapper Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 3/6] hw/usb: simplified usb_enabled Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 4/6] hw/ppc/mac_newworld: QOMified mac99 machines Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic Marcel Apfelbaum
2015-01-06 20:45   ` Paolo Bonzini
2015-01-07 11:03     ` Marcel Apfelbaum
2015-01-07 11:07       ` Paolo Bonzini [this message]
2015-01-07 11:15         ` Alexander Graf
2015-01-07 11:22           ` Paolo Bonzini
2015-01-07 11:27             ` Alexander Graf
2015-01-07 11:32               ` Paolo Bonzini
2015-01-07 11:37                 ` Alexander Graf
2015-01-07 14:57                   ` Marcel Apfelbaum
2015-01-07 11:50           ` Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 6/6] hw/ppc/mac_newworld: " Marcel Apfelbaum
2015-01-06 19:48 ` [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash Paolo Bonzini
2015-01-06 20:41   ` Paolo Bonzini
2015-01-06 21:54     ` Alexander Graf
2015-01-07  5:25       ` Paolo Bonzini
2015-01-07 13:15 ` Stefan Hajnoczi
2015-01-08 13:27 ` Peter Maydell
2015-01-08 16:35   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AD137D.4030209@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=lersek@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.