Re: [libvirt test] 33157: regressions - trouble: blocked/fail/pass/preparing/queued

From: Jim Fehlig <jfehlig@suse.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xensource.com, "xen.org" <Ian.Jackson@eu.citrix.com>
Subject: Re: [libvirt test] 33157: regressions -	trouble:	blocked/fail/pass/preparing/queued
Date: Thu, 08 Jan 2015 14:56:57 -0700	[thread overview]
Message-ID: <54AEFD29.9070506@suse.com> (raw)
In-Reply-To: <54AEBB76.2060801@suse.com>

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Jim Fehlig wrote:
> Ian Campbell wrote:
>
>   
>> I must confess that I thought you already did use libxlu...
>>   
>>     
>
> No, not directly.  But I will be doing so now.  I should try to revert
> all this nonsense and use libxlu before it ends up in the next libvirt
> release.
>   

Hmm, I don't think that is going to be possible since libxlutil.h has
never been installed :-(.  I guess something like the below (untested)
patch would have been necessary long ago.  Changing libvirt to use
libxlutil would break a lot of builds where the distro's existing
xen-devel package is missing libxlutil.h.

Regards,
Jim

[-- Attachment #2: install-libxlutil.h.patch --]
[-- Type: text/x-diff, Size: 1204 bytes --]

>From 3425c1cef21d0295fa8fbf9465ea7273b717f637 Mon Sep 17 00:00:00 2001
From: Jim Fehlig <jfehlig@suse.com>
Date: Thu, 8 Jan 2015 14:43:28 -0700
Subject: [PATCH] Install libxlutil.h

libxlutil.{a,so} are installed, but not the corresponding header
file.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 tools/libxl/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index df08c8a..0fe2868 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -266,7 +266,7 @@ install: all
 	$(SYMLINK_SHLIB) libxlutil.so.$(XLUMAJOR).$(XLUMINOR) $(DESTDIR)$(LIBDIR)/libxlutil.so.$(XLUMAJOR)
 	$(SYMLINK_SHLIB) libxlutil.so.$(XLUMAJOR) $(DESTDIR)$(LIBDIR)/libxlutil.so
 	$(INSTALL_DATA) libxlutil.a $(DESTDIR)$(LIBDIR)
-	$(INSTALL_DATA) libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h _libxl_list.h libxl_utils.h libxl_uuid.h $(DESTDIR)$(INCLUDEDIR)
+	$(INSTALL_DATA) libxl.h libxl_event.h libxl_json.h _libxl_types.h _libxl_types_json.h _libxl_list.h libxl_utils.h libxl_uuid.h libxlutil.h $(DESTDIR)$(INCLUDEDIR)
 	$(INSTALL_DATA) bash-completion $(DESTDIR)$(BASH_COMPLETION_DIR)/xl.sh
 
 .PHONY: clean
-- 
1.8.0.1


[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
