From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Francesco Ruggeri <fruggeri@aristanetworks.com>,
Francesco Ruggeri <fruggeri@arista.com>
Subject: Re: [PATCH] Revert "tty: Fix pty master poll() after slave closes v2"
Date: Fri, 09 Jan 2015 17:00:55 -0500 [thread overview]
Message-ID: <54B04F97.7070200@hurleysoftware.com> (raw)
In-Reply-To: <20150109214106.GA7952@kroah.com>
On 01/09/2015 04:41 PM, Greg Kroah-Hartman wrote:
> On Tue, Dec 30, 2014 at 07:31:06AM -0500, Peter Hurley wrote:
>> On 12/30/2014 07:17 AM, Peter Hurley wrote:
>>> This reverts commit c4dc304677e8d566572c4738d95c48be150c6606.
>>> This fix is superseded by commit 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73,
>>> 'pty, n_tty: Simplify input processing on final close'.
>>>
>>> The final close now waits for input processing to complete before
>>> destroying the pty, so poll() does not need to special case this
>>> condition.
>>
>> Greg,
>>
>> As noted in this commit log, commit c4dc304677e8d566572c4738d95c48be150c6606,
>> 'tty: Fix pty master poll() after slave closes v2', is not required
>> after commit 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73,
>> 'pty, n_tty: Simplify input processing on final close'
>>
>> However, 'tty: Fix pty master poll() after slave closes v2' is appropriate
>> for stable back to v3.12.
>
> I don't understand, what needs to go to a stable tree and what doesn't?
Commit c4dc304677e8d5665 ("tty: Fix pty master poll() after slave closes v2")
goes to stable v3.12~v3.18, but not 3.19-rc1+
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-01-09 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 12:17 [PATCH] Revert "tty: Fix pty master poll() after slave closes v2" Peter Hurley
2014-12-30 12:31 ` Peter Hurley
2015-01-06 14:33 ` Jiri Slaby
2015-01-06 16:49 ` Peter Hurley
2015-01-09 21:41 ` Greg Kroah-Hartman
2015-01-09 22:00 ` Peter Hurley [this message]
2015-01-28 0:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B04F97.7070200@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=fruggeri@arista.com \
--cc=fruggeri@aristanetworks.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.