From: Eric Blake <eblake@redhat.com>
To: Ian Campbell <Ian.Campbell@citrix.com>, Jim Fehlig <jfehlig@suse.com>
Cc: libvir-list@redhat.com, xen-devel@lists.xen.org
Subject: Re: [libvirt] [PATCH 00/12] Replace Xen xl parsing/formatting impl
Date: Mon, 12 Jan 2015 09:05:04 -0700 [thread overview]
Message-ID: <54B3F0B0.4020807__41201.4046255083$1421078817$gmane$org@redhat.com> (raw)
In-Reply-To: <1421075193.26317.95.camel@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1816 bytes --]
On 01/12/2015 08:06 AM, Ian Campbell wrote:
> On Fri, 2015-01-09 at 22:03 -0700, Jim Fehlig wrote:
>> The first attempt to implement support for parsing/formatting Xen's
>> xl disk config format copied Xen's flex-based parser into libvirt, which
>> has proved to be challenging in the context of autotools. But as it turns
>> out, Xen provides an interface to the parser via libxlutil.
>>
>> This series reverts the first attempt, along with subsequent attempts to
>> fix it, and replaces it with an implementation based on libxlutil. The
>> first nine patches revert the original implementation and subsequent fixes.
>> Patch 10 provides an implemenation based on libxlutil. Patches 11 and
>> 12 are basically unchanged from patches 3 and 4 in the first attempt.
>>
>> One upshot of using libxlutil instead of copying the flex source is
>> removing the potential for source divergence.
>
> Thanks for doing this, looks good to me, FWIW.
>
> Is the presence/absence of xen-xl support exposed via virsh anywhere? If
> so then I can arrange for my Xen osstest patches for libvirt testing to
> use xen-xl when available but still fallback to xen-xm. I've had a look
> in "virsh capabilities" and "virsh help domxml-from-native" but not
> seeing xen-xm, so assuming xen-xl won't magically appear in any of those
> places either.
I'm not sure if 'virsh capabilities' can show it, but it does sound like
a nice place to enhance if possible.
Also, if 'virsh --version=long' doesn't state whether libxl support was
compiled in, it should be patched to do so; although that only shows
what the client side supports (and not necessarily what the remote
server side supports).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-01-12 16:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-10 5:03 [PATCH 00/12] Replace Xen xl parsing/formatting impl Jim Fehlig
2015-01-10 5:03 ` [PATCH 01/12] Revert "bootstrap.conf: add check for flex" Jim Fehlig
2015-01-10 5:03 ` [PATCH 02/12] Revert "src/Makefile: Fix parallel build after xen_xl_disk parser introduction" Jim Fehlig
2015-01-10 5:03 ` [PATCH 03/12] Revert "src/Makefile: move the new xen_xl_disk parser code at the correct place" Jim Fehlig
2015-01-10 5:03 ` [PATCH 04/12] Revert "Revert "src/Makefile.am: fix build breaker for xenconfig"" Jim Fehlig
2015-01-10 5:03 ` [PATCH 05/12] Revert "build: fix xenconfig VPATH builds" Jim Fehlig
2015-01-10 5:03 ` [PATCH 06/12] Revert "src/Makefile.am: fix build breaker for xenconfig" Jim Fehlig
2015-01-10 5:03 ` [PATCH 07/12] Revert "libxl: Add support for parsing/formating Xen XL config" Jim Fehlig
2015-01-10 5:03 ` [PATCH 08/12] Revert "tests: Tests for the xen-xl parser" Jim Fehlig
2015-01-10 5:03 ` [PATCH 09/12] Revert "src/xenconfig: Xen-xl parser" Jim Fehlig
2015-01-12 14:51 ` [libvirt] " John Ferlan
[not found] ` <54B3DF75.2000406@redhat.com>
2015-01-12 16:07 ` Eric Blake
[not found] ` <54B3F12C.1050406@redhat.com>
2015-01-12 17:46 ` Jim Fehlig
2015-01-10 5:03 ` [PATCH 10/12] Introduce support for parsing/formatting Xen xl config format Jim Fehlig
2015-01-12 15:27 ` [libvirt] " John Ferlan
2015-01-12 16:41 ` Jim Fehlig
2015-01-13 1:32 ` Jim Fehlig
2015-01-12 17:49 ` Eric Blake
2015-01-13 1:33 ` Jim Fehlig
2015-01-10 5:03 ` [PATCH 11/12] tests: Tests for the xen-xl parser Jim Fehlig
2015-01-10 5:03 ` [PATCH 12/12] libxl: Add support for parsing/formating Xen XL config Jim Fehlig
2015-01-12 15:06 ` [PATCH 00/12] Replace Xen xl parsing/formatting impl Ian Campbell
[not found] ` <1421075193.26317.95.camel@citrix.com>
2015-01-12 16:05 ` Eric Blake [this message]
2015-01-12 16:23 ` Jim Fehlig
2015-01-12 16:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='54B3F0B0.4020807__41201.4046255083$1421078817$gmane$org@redhat.com' \
--to=eblake@redhat.com \
--cc=Ian.Campbell@citrix.com \
--cc=jfehlig@suse.com \
--cc=libvir-list@redhat.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.