From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Blake Subject: Re: [libvirt] [PATCH 10/12] Introduce support for parsing/formatting Xen xl config format Date: Mon, 12 Jan 2015 10:49:26 -0700 Message-ID: <54B40926.4010204@redhat.com> References: <1420866224-29746-1-git-send-email-jfehlig@suse.com> <1420866224-29746-11-git-send-email-jfehlig@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0063730886653337778==" Return-path: In-Reply-To: <1420866224-29746-11-git-send-email-jfehlig@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jim Fehlig , libvir-list@redhat.com Cc: Kiarie Kahurani , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0063730886653337778== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wImH7pIptpGN55G8hcgFTIco4gxEdG0lN" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wImH7pIptpGN55G8hcgFTIco4gxEdG0lN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/09/2015 10:03 PM, Jim Fehlig wrote: > Introduce a parser/formatter for the xl config format. Since the > deprecation of xm/xend, the VM config file format has diverged as > new features are added to libxl. This patch adds support for parsing > and formating the xl config format. It supports the existing xm config= > format, plus adds support for spice graphics and xl disk config syntax.= >=20 > xl disk config is parsed with the help of xlu_disk_parse() from > libxlutil, libxl's utility library. Although the library exists > in all Xen versions supported by the libxl virt driver, only > recently has the corresponding header file been included. A check > for the header is done in configure.ac. If not found, xlu_disk_parse()= > is declared externally. >=20 > Signed-off-by: Kiarie Kahurani > Signed-off-by: Jim Fehlig > --- > configure.ac | 3 + > po/POTFILES.in | 1 + > src/Makefile.am | 4 +- > src/libvirt_xenconfig.syms | 4 + > src/xenconfig/xen_common.c | 3 +- > src/xenconfig/xen_xl.c | 492 +++++++++++++++++++++++++++++++++++++= ++++++++ > src/xenconfig/xen_xl.h | 33 +++ > 7 files changed, 538 insertions(+), 2 deletions(-) This patch fails to build on RHEL 5: http://fpaste.org/168738/84783142/ There, the version of xen is so old that there is no support for newer xenlight interaction; we still want the old xen support code to compile, but you should probably consider making things conditional so that xen_xl.c is attempted only when new-enough xenlight support exists (the same way that src/libxl is avoided when only older xen is present). It may be as simple as making the file conditional on HAVE_LIBXL, although I haven't yet tried that. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wImH7pIptpGN55G8hcgFTIco4gxEdG0lN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUtAkmAAoJEKeha0olJ0Nq+D8H/j6gEckvPIOv2HwhWu6JD/2c odg0Nkbrg49z1DNDsECm8N/SxYd5h0YQhHSOmqIHhssbQBqi4+GIe+913ZDSTRvO yT+/LhsiqNe6dyx4bUznfJ98YtgGGkjzbBWwnu33Ed8be63EU5bdM6swNL48Rcju pzC/g+G20rCtQ84gyuN0q4u3zeS1VKOSHCADZldVYVflMonCRqv4pzAjPYTpmZ9p uVfBbgeGOYL2cRm9jIRLK0ENINwRa8dwljt2XVTo+iI+DoEwSeFBS8fPlo5Q+OMa HqmX2GqsB2iKKQHEJZVn7HxGvt3Y0oz5cWz0xaz5fAU66erh/2D2EKsTvmZ8mQM= =s04p -----END PGP SIGNATURE----- --wImH7pIptpGN55G8hcgFTIco4gxEdG0lN-- --===============0063730886653337778== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0063730886653337778==--