From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 06/12] xen/arm: Introduce a generic way to describe device Date: Fri, 16 Jan 2015 15:01:32 +0000 Message-ID: <54B927CC.6060700@linaro.org> References: <1421418247-30068-1-git-send-email-julien.grall@linaro.org> <1421418247-30068-7-git-send-email-julien.grall@linaro.org> <54B935470200007800055E3E@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YC8PS-0008V4-RU for xen-devel@lists.xenproject.org; Fri, 16 Jan 2015 15:02:02 +0000 Received: by mail-we0-f169.google.com with SMTP id m14so20746225wev.0 for ; Fri, 16 Jan 2015 07:02:01 -0800 (PST) In-Reply-To: <54B935470200007800055E3E@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , ian.campbell@citrix.com, Andrew Cooper , tim@xen.org, stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org Hi Jan, On 16/01/15 14:59, Jan Beulich wrote: >>>> On 16.01.15 at 15:24, wrote: >> --- >> xen/common/device.c | 21 +++++++++++++++++++++ >> xen/common/device_tree.c | 3 +++ > > Is there a Makefile change missing here? No. The file common/device.c should not be there. I drop for my tree but somehow it stay in the patch. Sorry. [..] >> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c >> index 34a1b9e..d1c716f 100644 >> --- a/xen/common/device_tree.c >> +++ b/xen/common/device_tree.c >> @@ -1454,6 +1454,9 @@ static unsigned long __init unflatten_dt_node(const >> void *fdt, >> ((char *)pp->value)[sz - 1] = 0; >> dt_dprintk("fixed up name for %s -> %s\n", pathp, >> (char *)pp->value); >> + /* Generic device initialization */ >> + np->dev.type = DEV_DT; >> + np->dev.of_node = np; > > Why is this not device_initialize(&np->dev, DEV_DT)? Because the file containing the function has been dropped. It's a left-over of the previous version. Regards, -- Julien Grall