From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Lendacky Subject: Re: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1 Date: Fri, 16 Jan 2015 09:16:06 -0600 Message-ID: <54B92B36.6080700@amd.com> References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <20150115182346.GE2329@e104818-lin.cambridge.arm.com> <54B8BB24.2020408@linaro.org> <54B9240A.7060003@amd.com> <20150116145545.GR7091@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150116145545.GR7091@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Will Deacon Cc: Mark Rutland , linaro-acpi , Catalin Marinas , Yijing Wang , Rob Herring , Lorenzo Pieralisi , Timur Tabi , ACPI Devel Mailing List , "grant.likely@linaro.org" , Charles Garcia-Tobin , "phoenix.liyi@huawei.com" , Robert Richter , Jason Cooper , Arnd Bergmann , Marc Zyngier , "jcm@redhat.com" , Mark Brown , Bjorn Helgaas , "linux-arm-kernel@lists.infradead.org" , "graeme.gregory@linaro.org" , Randy List-Id: linux-acpi@vger.kernel.org Hi Will, On 01/16/2015 08:55 AM, Will Deacon wrote: > Hi Tom, > > On Fri, Jan 16, 2015 at 02:45:30PM +0000, Tom Lendacky wrote: >> I have tested ACPI-enablement patches for the amd-xgbe/amd-xgbe-phy >> drivers that I'm about to submit upstream with the V7 patch series >> on the AMD Seattle server platform. There does not appear to be support >> for the _CCA attribute in this patch series. The amd-xgbe driver will >> setup the device domain and cache attributes based on the presence of >> this attribute, but it requires the arch support to assign the proper >> DMA operations in order for it to all work correctly. >> >> Overriding the _CCA attribute in the driver, I was able to successfully >> test the driver and this patch series. > > Hopefully this will all be addressed when the IORT parts of ACPI have > settled down (the current proposal allows for these attributes to be > described as well as their interaction with things like IOMMUs). > > In the meantime, are you falling back to non-coherent DMA? If so, what > attributes have you settled on? We need to be really careful not to > corrupt data during cache invalidatation when mapping a non-coherent > buffer for the CPU. > The override I used in the driver was to set the device to use AxDOMAIN of 3 and AxCACHE of 0 so that the caches are not accessed. Tom > Will > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640AbbAPPbb (ORCPT ); Fri, 16 Jan 2015 10:31:31 -0500 Received: from mail-bn1bn0109.outbound.protection.outlook.com ([157.56.110.109]:45179 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752376AbbAPPb3 (ORCPT ); Fri, 16 Jan 2015 10:31:29 -0500 X-WSS-ID: 0NI9ZQZ-07-I1P-02 X-M-MSG: Message-ID: <54B92B36.6080700@amd.com> Date: Fri, 16 Jan 2015 09:16:06 -0600 From: Tom Lendacky User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Will Deacon CC: "hanjun.guo@linaro.org" , Catalin Marinas , "grant.likely@linaro.org" , Mark Rutland , linaro-acpi , Yijing Wang , "Rob Herring" , Lorenzo Pieralisi , Timur Tabi , ACPI Devel Mailing List , Charles Garcia-Tobin , "phoenix.liyi@huawei.com" , Robert Richter , Jason Cooper , Arnd Bergmann , Marc Zyngier , "jcm@redhat.com" , Mark Brown , Bjorn Helgaas , "linux-arm-kernel@lists.infradead.org" , "graeme.gregory@linaro.org" , Randy Dunlap , "Rafael J. Wysocki" , Linux Kernel Mailing List , "suravee.suthikulpanit@amd.com" , Sudeep Holla , "Olof Johansson" Subject: Re: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1 References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <20150115182346.GE2329@e104818-lin.cambridge.arm.com> <54B8BB24.2020408@linaro.org> <54B9240A.7060003@amd.com> <20150116145545.GR7091@arm.com> In-Reply-To: <20150116145545.GR7091@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Thomas.Lendacky@amd.com; X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(24454002)(479174004)(55674003)(377454003)(199003)(189002)(51704005)(92566002)(59896002)(62966003)(36756003)(110136001)(106466001)(105586002)(93886004)(2950100001)(86362001)(77156002)(68736005)(46102003)(50466002)(77096005)(23746002)(64126003)(83506001)(561944003)(87266999)(101416001)(50986999)(76176999)(97736003)(54356999)(80316001)(87936001)(64706001)(65816999)(33656002)(65956001)(65806001)(47776003);DIR:OUT;SFP:1102;SCL:1;SRVR:CO1PR02MB206;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-DmarcAction-Test: None X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(3005004);SRVR:CO1PR02MB206; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:CO1PR02MB206; X-Forefront-PRVS: 04583CED1A X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB206; X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2015 15:16:14.3766 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB206 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Will, On 01/16/2015 08:55 AM, Will Deacon wrote: > Hi Tom, > > On Fri, Jan 16, 2015 at 02:45:30PM +0000, Tom Lendacky wrote: >> I have tested ACPI-enablement patches for the amd-xgbe/amd-xgbe-phy >> drivers that I'm about to submit upstream with the V7 patch series >> on the AMD Seattle server platform. There does not appear to be support >> for the _CCA attribute in this patch series. The amd-xgbe driver will >> setup the device domain and cache attributes based on the presence of >> this attribute, but it requires the arch support to assign the proper >> DMA operations in order for it to all work correctly. >> >> Overriding the _CCA attribute in the driver, I was able to successfully >> test the driver and this patch series. > > Hopefully this will all be addressed when the IORT parts of ACPI have > settled down (the current proposal allows for these attributes to be > described as well as their interaction with things like IOMMUs). > > In the meantime, are you falling back to non-coherent DMA? If so, what > attributes have you settled on? We need to be really careful not to > corrupt data during cache invalidatation when mapping a non-coherent > buffer for the CPU. > The override I used in the driver was to set the device to use AxDOMAIN of 3 and AxCACHE of 0 so that the caches are not accessed. Tom > Will > From mboxrd@z Thu Jan 1 00:00:00 1970 From: thomas.lendacky@amd.com (Tom Lendacky) Date: Fri, 16 Jan 2015 09:16:06 -0600 Subject: [PATCH v7 00/17] Introduce ACPI for ARM64 based on ACPI 5.1 In-Reply-To: <20150116145545.GR7091@arm.com> References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <20150115182346.GE2329@e104818-lin.cambridge.arm.com> <54B8BB24.2020408@linaro.org> <54B9240A.7060003@amd.com> <20150116145545.GR7091@arm.com> Message-ID: <54B92B36.6080700@amd.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Will, On 01/16/2015 08:55 AM, Will Deacon wrote: > Hi Tom, > > On Fri, Jan 16, 2015 at 02:45:30PM +0000, Tom Lendacky wrote: >> I have tested ACPI-enablement patches for the amd-xgbe/amd-xgbe-phy >> drivers that I'm about to submit upstream with the V7 patch series >> on the AMD Seattle server platform. There does not appear to be support >> for the _CCA attribute in this patch series. The amd-xgbe driver will >> setup the device domain and cache attributes based on the presence of >> this attribute, but it requires the arch support to assign the proper >> DMA operations in order for it to all work correctly. >> >> Overriding the _CCA attribute in the driver, I was able to successfully >> test the driver and this patch series. > > Hopefully this will all be addressed when the IORT parts of ACPI have > settled down (the current proposal allows for these attributes to be > described as well as their interaction with things like IOMMUs). > > In the meantime, are you falling back to non-coherent DMA? If so, what > attributes have you settled on? We need to be really careful not to > corrupt data during cache invalidatation when mapping a non-coherent > buffer for the CPU. > The override I used in the driver was to set the device to use AxDOMAIN of 3 and AxCACHE of 0 so that the caches are not accessed. Tom > Will >