From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCBBk-000583-Vv for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:00:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YCBBg-00085G-58 for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:00:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCBBf-00085A-S6 for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:00:00 -0500 Message-ID: <54B9519C.7040905@redhat.com> Date: Fri, 16 Jan 2015 12:59:56 -0500 From: John Snow MIME-Version: 1.0 References: <1421080265-2228-1-git-send-email-jsnow@redhat.com> <1421080265-2228-10-git-send-email-jsnow@redhat.com> <54B94FF1.3090908@redhat.com> In-Reply-To: <54B94FF1.3090908@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v11 09/13] qmp: Add support of "dirty-bitmap" sync mode for drive-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 01/16/2015 12:52 PM, Max Reitz wrote: > On 2015-01-12 at 11:31, John Snow wrote: >> For "dirty-bitmap" sync mode, the block job will iterate through the >> given dirty bitmap to decide if a sector needs backup (backup all the >> dirty clusters and skip clean ones), just as allocation conditions of >> "top" sync mode. >> >> Signed-off-by: Fam Zheng >> Signed-off-by: John Snow >> --- >> block.c | 5 ++ >> block/backup.c | 120 >> ++++++++++++++++++++++++++++++++++++++-------- >> block/mirror.c | 4 ++ >> blockdev.c | 14 +++++- >> hmp.c | 3 +- >> include/block/block.h | 1 + >> include/block/block_int.h | 2 + >> qapi/block-core.json | 11 +++-- >> qmp-commands.hx | 7 +-- >> 9 files changed, 137 insertions(+), 30 deletions(-) > > Since you seem to be intending to rethink the "frozen" state, I'm just > scanning through the series from patch 8 on. > > While this patch doesn't seem to have changed much conceptually since > the last version I reviewed, with it applied to master, qemu fails to > build due to Fam's blockdev-backup series (some new calls to > backup_start() which have to be adapted). > > Max Understood. "Frozen" will still exist largely similar to what it doe s=20 now, but the proposal from fam was to simply fold "enabled/disabled"=20 into the same status, and perhaps differentiate between a simple=20 "disabled" state and a "frozen" state by the presence or absence of a=20 successor. As for the rebase onto master, here's a v11.5: https://github.com/jnsnow/qemu/commits/dbm-backup --=20 =E2=80=94js