From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756101AbbAPTYO (ORCPT ); Fri, 16 Jan 2015 14:24:14 -0500 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:56790 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbbAPTYM (ORCPT ); Fri, 16 Jan 2015 14:24:12 -0500 X-IronPort-AV: E=Sophos;i="5.09,412,1418112000"; d="scan'208";a="55160822" Message-ID: <54B96559.1010007@broadcom.com> Date: Fri, 16 Jan 2015 11:24:09 -0800 From: Ray Jui User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: =?windows-1252?Q?Uwe_Kleine-K=F6nig?= CC: Wolfram Sang , Rob Herring , Pawel Moll , Mark Rutland , "Ian Campbell" , Kumar Gala , Grant Likely , Christian Daudt , Matt Porter , Florian Fainelli , Russell King , "Scott Branden" , , , , , Subject: Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus References: <1421274213-3544-1-git-send-email-rjui@broadcom.com> <1421274213-3544-4-git-send-email-rjui@broadcom.com> <20150115084456.GO22880@pengutronix.de> In-Reply-To: <20150115084456.GO22880@pengutronix.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/15/2015 12:44 AM, Uwe Kleine-König wrote: > Hello, > > On Wed, Jan 14, 2015 at 02:23:33PM -0800, Ray Jui wrote: >> Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep >> them disabled there. Individual I2C devices can be enabled in board >> specific dts file when I2C slave devices are enabled in the future > s/$/./ > >> >> Signed-off-by: Ray Jui >> Reviewed-by: Scott Branden >> --- >> arch/arm/boot/dts/bcm-cygnus.dtsi | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi >> index 5126f9e..f7d6c1d 100644 >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi >> @@ -70,6 +70,26 @@ >> }; >> }; >> >> + i2c0: i2c@18008000 { >> + compatible = "brcm,iproc-i2c"; > in patch 2 you wrote the driver is for a family of SoCs, right? Then I'd > make this: > > compatible = "brcm,$mysoc-iproc-i2c", "brcm,iproc-i2c"; > Sorry could you please help to explain the intention here? Note the iProc I2C IP can be found in various iProc family of SoCs, but to my best knowledge, there hasn't been any changes of the IP in any of those SoCs. Is the compatible ID "brcm,$mysoc-iproc-i2c" only to clarify that it's for a specific SoC? If so, what should the compatible ID array look like? Should it be changed to the following? static const struct of_device_id bcm_iproc_i2c_of_match[] = { { .compatible = "brcm,iproc-i2c" }, { .compatible = "brcm,$mysoc-iproc-i2c" }, {}, }; > (or maybe s/$mysoc-iproc-i2c/$mysoc-i2c/). > > Best regards > Uwe > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ray Jui Subject: Re: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus Date: Fri, 16 Jan 2015 11:24:09 -0800 Message-ID: <54B96559.1010007@broadcom.com> References: <1421274213-3544-1-git-send-email-rjui@broadcom.com> <1421274213-3544-4-git-send-email-rjui@broadcom.com> <20150115084456.GO22880@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150115084456.GO22880-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?windows-1252?Q?Uwe_Kleine-K=F6nig?= Cc: Wolfram Sang , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Christian Daudt , Matt Porter , Florian Fainelli , Russell King , Scott Branden , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 1/15/2015 12:44 AM, Uwe Kleine-K=F6nig wrote: > Hello, >=20 > On Wed, Jan 14, 2015 at 02:23:33PM -0800, Ray Jui wrote: >> Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep >> them disabled there. Individual I2C devices can be enabled in board >> specific dts file when I2C slave devices are enabled in the future > s/$/./ >=20 >> >> Signed-off-by: Ray Jui >> Reviewed-by: Scott Branden >> --- >> arch/arm/boot/dts/bcm-cygnus.dtsi | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/b= cm-cygnus.dtsi >> index 5126f9e..f7d6c1d 100644 >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi >> @@ -70,6 +70,26 @@ >> }; >> }; >> =20 >> + i2c0: i2c@18008000 { >> + compatible =3D "brcm,iproc-i2c"; > in patch 2 you wrote the driver is for a family of SoCs, right? Then = I'd > make this: >=20 > compatible =3D "brcm,$mysoc-iproc-i2c", "brcm,iproc-i2c"; >=20 Sorry could you please help to explain the intention here? Note the iProc I2C IP can be found in various iProc family of SoCs, but to my best knowledge, there hasn't been any changes of the IP in any of those SoCs. Is the compatible ID "brcm,$mysoc-iproc-i2c" only to clarify that it's for a specific SoC? If so, what should the compatible ID array look like? Should it be changed to the following? static const struct of_device_id bcm_iproc_i2c_of_match[] =3D { { .compatible =3D "brcm,iproc-i2c" }, { .compatible =3D "brcm,$mysoc-iproc-i2c" }, {}, }; > (or maybe s/$mysoc-iproc-i2c/$mysoc-i2c/). >=20 > Best regards > Uwe >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: rjui@broadcom.com (Ray Jui) Date: Fri, 16 Jan 2015 11:24:09 -0800 Subject: [PATCH v4 3/3] ARM: dts: add I2C device nodes for Broadcom Cygnus In-Reply-To: <20150115084456.GO22880@pengutronix.de> References: <1421274213-3544-1-git-send-email-rjui@broadcom.com> <1421274213-3544-4-git-send-email-rjui@broadcom.com> <20150115084456.GO22880@pengutronix.de> Message-ID: <54B96559.1010007@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 1/15/2015 12:44 AM, Uwe Kleine-K?nig wrote: > Hello, > > On Wed, Jan 14, 2015 at 02:23:33PM -0800, Ray Jui wrote: >> Add I2C device nodes and its properties in bcm-cygnus.dtsi but keep >> them disabled there. Individual I2C devices can be enabled in board >> specific dts file when I2C slave devices are enabled in the future > s/$/./ > >> >> Signed-off-by: Ray Jui >> Reviewed-by: Scott Branden >> --- >> arch/arm/boot/dts/bcm-cygnus.dtsi | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi >> index 5126f9e..f7d6c1d 100644 >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi >> @@ -70,6 +70,26 @@ >> }; >> }; >> >> + i2c0: i2c at 18008000 { >> + compatible = "brcm,iproc-i2c"; > in patch 2 you wrote the driver is for a family of SoCs, right? Then I'd > make this: > > compatible = "brcm,$mysoc-iproc-i2c", "brcm,iproc-i2c"; > Sorry could you please help to explain the intention here? Note the iProc I2C IP can be found in various iProc family of SoCs, but to my best knowledge, there hasn't been any changes of the IP in any of those SoCs. Is the compatible ID "brcm,$mysoc-iproc-i2c" only to clarify that it's for a specific SoC? If so, what should the compatible ID array look like? Should it be changed to the following? static const struct of_device_id bcm_iproc_i2c_of_match[] = { { .compatible = "brcm,iproc-i2c" }, { .compatible = "brcm,$mysoc-iproc-i2c" }, {}, }; > (or maybe s/$mysoc-iproc-i2c/$mysoc-i2c/). > > Best regards > Uwe >