Hi Maciej,

On 20/01/15 23:32, Maciej W. Rozycki wrote:
>  As a side note I can see that as from a96102be, ISA flags are inclusive, 
> so the macros in <asm/cpu-features.h> can and I think should be rearranged 
> and simplified.  E.g. (indentation adjusted, we can afford it now):
> 
> #define cpu_has_mips_2_3_4_5	cpu_has_mips_2
> #define cpu_has_mips_3_4_5	cpu_has_mips_3
> 
> #define cpu_has_mips_2_3_4_5_r	cpu_has_mips_2
> 
> #define cpu_has_mips32		cpu_has_mips32r1
> #define cpu_has_mips64		cpu_has_mips64r1
> 
> #define cpu_has_mips_r		cpu_has_mips32r1

this isn't always the case. Although set_isa will do the right thing,
some platforms override these in exclusive ways, e.g.:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/include/asm/mach-cavium-octeon/cpu-feature-overrides.h#n49

David on Cc in case he'd like to justify that. IMO it seems wrong.

Cheers
James