All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 7/7] openpic: fix up loadvm under -M mac99
Date: Thu, 22 Jan 2015 14:39:12 +0100	[thread overview]
Message-ID: <54C0FD80.6010806@suse.de> (raw)
In-Reply-To: <1421856072-25026-8-git-send-email-mark.cave-ayland@ilande.co.uk>



On 21.01.15 17:01, Mark Cave-Ayland wrote:
> Issuing loadvm under -M mac99 would fail for two reasons: firstly an incorrect
> version number for openpic would cause openpic_load() to abort, and secondly
> a cut/paste error when restoring the IVPR and IDR registers caused subsequent
> vmstate sections to become misaligned and abort early.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Thanks a lot for all the work you put into this. Do you think you
understand enough to the OpenPIC code by now to be able to convert it to
VMState instead?

That would get rid of the whole class of problems altogether and make
sure we didn't overlook something subtle somewhere else in the code.


Alex

  reply	other threads:[~2015-01-22 13:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 16:01 [Qemu-devel] [PATCHv2 0/7] ppc: loadvm/savevm fixups for -M g3beige and -M mac99 Mark Cave-Ayland
2015-01-21 16:01 ` [Qemu-devel] [PATCHv2 1/7] macio.c: include parent PCIDevice state in VMStateDescription Mark Cave-Ayland
2015-01-21 16:01 ` [Qemu-devel] [PATCHv2 2/7] adb.c: include ADBDevice parent state in KBDState and MouseState Mark Cave-Ayland
2015-01-21 16:01 ` [Qemu-devel] [PATCHv2 3/7] cuda.c: include adb_poll_timer in VMStateDescription Mark Cave-Ayland
2015-01-21 16:01 ` [Qemu-devel] [PATCHv2 4/7] target-ppc: move sdr1 value change detection logic to helper_store_sdr1() Mark Cave-Ayland
2015-01-21 16:01 ` [Qemu-devel] [PATCHv2 5/7] target-ppc: force update of msr bits in cpu_post_load Mark Cave-Ayland
2015-01-22 13:37   ` Alexander Graf
2015-01-26 21:41     ` Mark Cave-Ayland
2015-01-26 21:49       ` Alexander Graf
2015-01-21 16:01 ` [Qemu-devel] [PATCHv2 6/7] openpic: fix segfault on -M mac99 savevm Mark Cave-Ayland
2015-01-21 16:01 ` [Qemu-devel] [PATCHv2 7/7] openpic: fix up loadvm under -M mac99 Mark Cave-Ayland
2015-01-22 13:39   ` Alexander Graf [this message]
2015-01-26 22:13     ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C0FD80.6010806@suse.de \
    --to=agraf@suse.de \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.