From: Paolo Bonzini <pbonzini@redhat.com>
To: Paul Bolle <pebolle@tiscali.nl>, Mario Smarduch <m.smarduch@samsung.com>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
Christoffer Dall <christoffer.dall@linaro.org>,
Gleb Natapov <gleb@kernel.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: KVM: HAVE_KVM_ARCH_DIRTY_LOG_PROTECT?
Date: Thu, 22 Jan 2015 14:57:13 +0100 [thread overview]
Message-ID: <54C101B9.1050804@redhat.com> (raw)
In-Reply-To: <1421918381.13638.43.camel@x220>
On 22/01/2015 10:19, Paul Bolle wrote:
> Your commit ba0513b5b8ff ("KVM: Add generic support for dirty page
> logging") is included in today's linux-next (ie, next-20150122). I
> noticed because a script I use to check linux-next spotted a problem
> with it.
>
> That commit added a Kconfig symbol HAVE_KVM_ARCH_DIRTY_LOG_PROTECT. But
> nothing in linux-next uses that symbol. Why was it added?
Ah, there are two Kconfig symbols added by mistake.
+config HAVE_KVM_ARCH_DIRTY_LOG_PROTECT
+ bool
+
+config KVM_GENERIC_DIRTYLOG_READ_PROTECT
+ bool
Christoffer, can you fix that in kvm-arm and also the other mistake that
Paul reported?
Paolo
next prev parent reply other threads:[~2015-01-22 13:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 9:19 KVM: HAVE_KVM_ARCH_DIRTY_LOG_PROTECT? Paul Bolle
2015-01-22 11:46 ` Paolo Bonzini
2015-01-22 17:47 ` Mario Smarduch
2015-01-22 13:57 ` Paolo Bonzini [this message]
2015-01-22 14:49 ` Paul Bolle
2015-01-22 15:32 ` Paolo Bonzini
2015-01-23 9:48 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C101B9.1050804@redhat.com \
--to=pbonzini@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.smarduch@samsung.com \
--cc=pebolle@tiscali.nl \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.