From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linhaifeng Subject: Re: [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user support Date: Fri, 23 Jan 2015 11:53:30 +0800 Message-ID: <54C1C5BA.8040801@huawei.com> References: <1418247477-13920-1-git-send-email-huawei.xie@intel.com> <1418247477-13920-9-git-send-email-huawei.xie@intel.com> <54892D4D.3060708@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit To: "Xie, Huawei" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/1/23 11:40, Xie, Huawei wrote: > > >> -----Original Message----- >> From: Linhaifeng [mailto:haifeng.lin-hv44wF8Li93QT0dZR+AlfA@public.gmane.org] >> Sent: Thursday, December 11, 2014 1:36 PM >> To: Xie, Huawei; dev-VfR2kkLFssw@public.gmane.org >> Cc: haifeng.lin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org >> Subject: Re: [dpdk-dev] [PATCH RFC v2 08/12] lib/librte_vhost: vhost-user >> support >> >> >> >> On 2014/12/11 5:37, Huawei Xie wrote: >>> vhost-user support >>> >>> >>> Signed-off-by: Huawei Xie >>> --- >>> lib/librte_vhost/Makefile | 5 +- >>> + case VHOST_USER_SET_LOG_FD: >> >> should close fd for fd leak when receive VHOST_USER_SET_LOG_FD msg? > Ok, would at least close the fd though we don't support. > Do you know how to test this? reboot VM many times then watch the number of fd with command 'ls /proc/pidof vhost/fd |wc -l' >> >>> + RTE_LOG(INFO, VHOST_CONFIG, "not implemented.\n"); >>> + >>> + case VHOST_USER_SET_VRING_ERR: >> >> should close fd for fd leak? > Would do. >> >>> + RTE_LOG(INFO, VHOST_CONFIG, "not implemented\n"); >>> + break; >>> +#endif >>> >> >> -- >> Regards, >> Haifeng > > > -- Regards, Haifeng