From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753653AbbAWGlU (ORCPT ); Fri, 23 Jan 2015 01:41:20 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:16006 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752287AbbAWGlQ (ORCPT ); Fri, 23 Jan 2015 01:41:16 -0500 X-AuditID: cbfee68e-f79b46d000002b74-a8-54c1ed0a6a55 Message-id: <54C1ED09.1080607@samsung.com> Date: Fri, 23 Jan 2015 15:41:13 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Jaewon Kim Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Inki Dae , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Chanwoo Choi , Sebastian Reichel , Mark Brown Subject: Re: [PATCH 1/6] mfd: max77843: Add max77843 MFD driver core driver References: <1421989367-32721-1-git-send-email-jaewon02.kim@samsung.com> <1421989367-32721-2-git-send-email-jaewon02.kim@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMIsWRmVeSWpSXmKPExsWyRsSkSJfr7cEQg4fbuC2mPnzCZnH9y3NW i/lHzrFa9L9ZyGpx7tVKRotJ9yewWOxoOMJq8fqFocX9r0cZLS7vmsNm8bn3CKPF0usXmSwm TF/LYtG69wi7xendJQ78HmvmrWH0uNzXy+SxcvkXNo9NqzrZPO5c28Pm0bdlFaPH501yAexR XDYpqTmZZalF+nYJXBl3/p1jKpjnWrFi+332BsZthl2MnBwSAiYSN5ffYoGwxSQu3FvP1sXI xSEksJRRYmvbSzaYos3XVjJDJKYzSmxu3gpV9ZpR4svnv2BVvAJaEvevnQKzWQRUJa7OfQ02 lk1AU+L9lCtgtqhAhMT8Y6+ZIeoFJX5MvgcWFxGIkljx4xrYUGaB08wSq/+cY+9i5OAQFvCW WN7kB7HsHKPEpW97wJo5BYIl9v4+xgRSwyygLjFlSi5ImFlAXmLzmrdgl0oITOWQ6Px/jwni IAGJb5MPsYDUSwjISmw6wAzxmaTEwRU3WCYwis1CctIshKmzkExdwMi8ilE0tSC5oDgpvchI rzgxt7g0L10vOT93EyMwrk//e9a3g/HmAetDjAIcjEo8vI1bDoYIsSaWFVfmHmI0BTpiIrOU aHI+MHnklcQbGpsZWZiamBobmVuaKYnzJkj9DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXA GOkRfycuhdtkTv7xF3evGF5ZPO3D2gXZNzmYN8/+xXam5ega1gt31nDq6BRpuByUPx/85bei ZNKUCwLTXmRGhfmLPhAOZD1ybZJ+4LrPi9vq30svWM4azNXfJLqec26v9h1RJZcFHwwij08O mNerb3csL87k1+53BTtORivsMdTnd1o+TWqfhxJLcUaioRZzUXEiAIoHPnbmAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDKsWRmVeSWpSXmKPExsVy+t9jQV2utwdDDE6GWEx9+ITN4vqX56wW 84+cY7Xof7OQ1eLcq5WMFpPuT2Cx2NFwhNXi9QtDi/tfjzJaXN41h83ic+8RRoul1y8yWUyY vpbFonXvEXaL07tLHPg91sxbw+hxua+XyWPl8i9sHptWdbJ53Lm2h82jb8sqRo/Pm+QC2KMa GG0yUhNTUosUUvOS81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgM5WUihL zCkFCgUkFhcr6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMGbc+XeOqWCea8WK7ffZGxi3GXYx cnJICJhIbL62khnCFpO4cG89WxcjF4eQwHRGic3NW6Gc14wSXz7/ZQOp4hXQkrh/7RSYzSKg KnF17msWEJtNQFPi/ZQrYLaoQITE/GOvmSHqBSV+TL4HFhcRiJJY8eMa2FBmgdPMEqv/nGPv YuTgEBbwllje5Aex7ByjxKVve8CaOQWCJfb+PsYEUsMsoC4xZUouSJhZQF5i85q3zBMYBWYh WTELoWoWkqoFjMyrGEVTC5ILipPScw31ihNzi0vz0vWS83M3MYJTxjOpHYwrGywOMQpwMCrx 8DZsORgixJpYVlyZe4hRgoNZSYS3+xFQiDclsbIqtSg/vqg0J7X4EKMpMAAmMkuJJucD01le SbyhsYmZkaWRuaGFkbG5kjivkn1biJBAemJJanZqakFqEUwfEwenVAPj6vezlvF+W/7sdTDb ZhnBfMM9H17mCoqJLY5tCJBb/Trdu/DbBJ8KWdXJocda3v1IlY7me7Y/cmLqBa/sSd6vvBzS HxmG2hSFSnyom1bxsu5AmWbh1bNVX2xWywksXz5z0Q/ZFb8uMW4I7Frz7/+zr2eYZfpYM3OT khycNH8frAu6uDyPYWqjEktxRqKhFnNRcSIAfL5oNS8DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2015 03:32 PM, Krzysztof Kozlowski wrote: > 2015-01-23 6:02 GMT+01:00 Jaewon Kim : >> This patch adds MAX77843 core/irq driver to support PMIC, >> MUIC(Micro USB Interface Controller), Charger, Fuel Gauge, >> LED and Haptic device. >> >> Cc: Lee Jones >> Signed-off-by: Beomho Seo >> Signed-off-by: Jaewon Kim >> --- >> drivers/mfd/Kconfig | 14 ++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/max77843.c | 241 ++++++++++++++++++++ >> include/linux/mfd/max77843-private.h | 410 ++++++++++++++++++++++++++++++++++ >> 4 files changed, 666 insertions(+) >> create mode 100644 drivers/mfd/max77843.c >> create mode 100644 include/linux/mfd/max77843-private.h >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index 2e6b731..0c67c79 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -442,6 +442,20 @@ config MFD_MAX77693 >> additional drivers must be enabled in order to use the functionality >> of the device. >> >> +config MFD_MAX77843 >> + bool "Maxim Semiconductor MAX77843 PMIC Support" >> + depends on I2C=y >> + select MFD_CORE >> + select REGMAP_I2C >> + select REGMAP_IRQ >> + help >> + Say yes here to add support for Maxim Semiconductor MAX77843. >> + This is companion Power Management IC with LEDs, Haptic, Charger, >> + Fuel Gauge, MUIC(Micro USB Interface Controller) controls on chip. >> + This driver provides common support for accessing the device; >> + additional drivers must be enabled in order to use the functionality >> + of the device. >> + >> config MFD_MAX8907 >> tristate "Maxim Semiconductor MAX8907 PMIC Support" >> select MFD_CORE >> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile >> index 53467e2..fe4f75c 100644 >> --- a/drivers/mfd/Makefile >> +++ b/drivers/mfd/Makefile >> @@ -117,6 +117,7 @@ obj-$(CONFIG_MFD_DA9063) += da9063.o >> obj-$(CONFIG_MFD_MAX14577) += max14577.o >> obj-$(CONFIG_MFD_MAX77686) += max77686.o >> obj-$(CONFIG_MFD_MAX77693) += max77693.o >> +obj-$(CONFIG_MFD_MAX77843) += max77843.o >> obj-$(CONFIG_MFD_MAX8907) += max8907.o >> max8925-objs := max8925-core.o max8925-i2c.o >> obj-$(CONFIG_MFD_MAX8925) += max8925.o >> diff --git a/drivers/mfd/max77843.c b/drivers/mfd/max77843.c >> new file mode 100644 >> index 0000000..d7f8b76 >> --- /dev/null >> +++ b/drivers/mfd/max77843.c >> @@ -0,0 +1,241 @@ >> +/* >> + * max77843.c - MFD core driver for the Maxim MAX77843 >> + * >> + * Copyright (C) 2014 Samsung Electrnoics >> + * Author: Jaewon Kim >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static const struct mfd_cell max77843_devs[] = { >> + { >> + .name = "max77843-muic", >> + .of_compatible = "maxim,max77843-muic", >> + }, { >> + .name = "max77843-regulator", >> + .of_compatible = "maxim,max77843-regulator", >> + }, { >> + .name = "max77843-charger", >> + .of_compatible = "maxim,max77843-charger" >> + }, { >> + .name = "max77843-fuelgauge", >> + .of_compatible = "maxim,max77843-fuelgauge", >> + }, >> +}; >> + >> +static const struct regmap_config max77843_charger_regmap_config = { >> + .reg_bits = 8, >> + .val_bits = 8, >> + .max_register = MAX77843_CHG_REG_END, >> +}; >> + >> +static const struct regmap_config max77843_regmap_config = { >> + .reg_bits = 8, >> + .val_bits = 8, >> + .max_register = MAX77843_SYS_REG_END, >> +}; >> + >> +static const struct regmap_irq max77843_irqs[] = { >> + /* TOPSYS interrupts */ >> + { .reg_offset = 0, .mask = MAX77843_SYS_IRQ_SYSUVLO_INT, }, >> + { .reg_offset = 0, .mask = MAX77843_SYS_IRQ_SYSOVLO_INT, }, >> + { .reg_offset = 0, .mask = MAX77843_SYS_IRQ_TSHDN_INT, }, >> + { .reg_offset = 0, .mask = MAX77843_SYS_IRQ_TM_INT, }, >> +}; >> + >> +static const struct regmap_irq_chip max77843_irq_chip = { >> + .name = "max77843", >> + .status_base = MAX77843_SYS_REG_SYSINTSRC, >> + .mask_base = MAX77843_SYS_REG_SYSINTMASK, >> + .mask_invert = false, >> + .num_regs = 1, >> + .irqs = max77843_irqs, >> + .num_irqs = ARRAY_SIZE(max77843_irqs), >> +}; >> + >> +static int max77843_chg_init(struct max77843 *max77843) >> +{ > > Could this function be moved to the charger driver? This way the > driver will manage its own resources instead of depending on parent > MFD driver. > Charger regulator and Charger share same resources. So I include this function core driver. >> + int ret; >> + >> + max77843->i2c_chg = i2c_new_dummy(max77843->i2c->adapter, I2C_ADDR_CHG); >> + if (!max77843->i2c_chg) { >> + dev_err(&max77843->i2c->dev, >> + "Cannot allocate I2C device for Charger\n"); >> + return PTR_ERR(max77843->i2c_chg); >> + } >> + i2c_set_clientdata(max77843->i2c_chg, max77843); >> + >> + max77843->regmap_chg = devm_regmap_init_i2c(max77843->i2c_chg, >> + &max77843_charger_regmap_config); >> + if (IS_ERR(max77843->regmap_chg)) { >> + ret = PTR_ERR(max77843->regmap_chg); >> + goto err_chg_i2c; >> + } >> + >> + return 0; >> + >> +err_chg_i2c: >> + i2c_unregister_device(max77843->i2c_chg); >> + >> + return ret; >> +} >> + >> +static int max77843_probe(struct i2c_client *i2c, >> + const struct i2c_device_id *id) >> +{ >> + struct max77843 *max77843; >> + int ret; >> + unsigned int reg_data; >> + >> + max77843 = devm_kzalloc(&i2c->dev, sizeof(*max77843), GFP_KERNEL); >> + if (!max77843) >> + return -ENOMEM; >> + >> + i2c_set_clientdata(i2c, max77843); >> + max77843->dev = &i2c->dev; >> + max77843->i2c = i2c; >> + max77843->irq = i2c->irq; >> + >> + max77843->regmap = devm_regmap_init_i2c(i2c, >> + &max77843_regmap_config); >> + if (IS_ERR(max77843->regmap)) { >> + dev_err(&i2c->dev, "Failed to allocate topsys register map\n"); >> + return PTR_ERR(max77843->regmap); >> + } >> + >> + ret = regmap_add_irq_chip(max77843->regmap, max77843->irq, >> + IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED, >> + 0, &max77843_irq_chip, &max77843->irq_data); > > Why shared IRQ? > >> + if (ret) { >> + dev_err(&i2c->dev, "Failed to add TOPSYS IRQ chip\n"); >> + return ret; >> + } >> + >> + ret = regmap_read(max77843->regmap, >> + MAX77843_SYS_REG_PMICID, ®_data); >> + if (ret < 0) { >> + dev_err(&i2c->dev, "Failed to read PMIC ID\n"); >> + goto err_pmic_id; >> + } >> + dev_info(&i2c->dev, "device ID: 0x%x\n", reg_data); >> + >> + ret = max77843_chg_init(max77843); >> + if (ret) { >> + dev_err(&i2c->dev, "Failed to init Charger\n"); >> + goto err_pmic_id; >> + } >> + >> + ret = regmap_update_bits(max77843->regmap, >> + MAX77843_SYS_REG_INTSRCMASK, >> + MAX77843_INTSRC_MASK_MASK, >> + (unsigned int)~MAX77843_INTSRC_MASK_MASK); >> + if (ret < 0) { >> + dev_err(&i2c->dev, "Failed to unmask interrupt sourece\n"); > > s/sourece/source/ > > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Beomho Seo Subject: Re: [PATCH 1/6] mfd: max77843: Add max77843 MFD driver core driver Date: Fri, 23 Jan 2015 15:41:13 +0900 Message-ID: <54C1ED09.1080607@samsung.com> References: <1421989367-32721-1-git-send-email-jaewon02.kim@samsung.com> <1421989367-32721-2-git-send-email-jaewon02.kim@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski , Jaewon Kim Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Inki Dae , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Chanwoo Choi , Sebastian Reichel , Mark Brown List-Id: devicetree@vger.kernel.org On 01/23/2015 03:32 PM, Krzysztof Kozlowski wrote: > 2015-01-23 6:02 GMT+01:00 Jaewon Kim : >> This patch adds MAX77843 core/irq driver to support PMIC, >> MUIC(Micro USB Interface Controller), Charger, Fuel Gauge, >> LED and Haptic device. >> >> Cc: Lee Jones >> Signed-off-by: Beomho Seo >> Signed-off-by: Jaewon Kim >> --- >> drivers/mfd/Kconfig | 14 ++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/max77843.c | 241 ++++++++++++++++++++ >> include/linux/mfd/max77843-private.h | 410 ++++++++++++++++++++++++++++++++++ >> 4 files changed, 666 insertions(+) >> create mode 100644 drivers/mfd/max77843.c >> create mode 100644 include/linux/mfd/max77843-private.h >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index 2e6b731..0c67c79 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -442,6 +442,20 @@ config MFD_MAX77693 >> additional drivers must be enabled in order to use the functionality >> of the device. >> >> +config MFD_MAX77843 >> + bool "Maxim Semiconductor MAX77843 PMIC Support" >> + depends on I2C=y >> + select MFD_CORE >> + select REGMAP_I2C >> + select REGMAP_IRQ >> + help >> + Say yes here to add support for Maxim Semiconductor MAX77843. >> + This is companion Power Management IC with LEDs, Haptic, Charger, >> + Fuel Gauge, MUIC(Micro USB Interface Controller) controls on chip. >> + This driver provides common support for accessing the device; >> + additional drivers must be enabled in order to use the functionality >> + of the device. >> + >> config MFD_MAX8907 >> tristate "Maxim Semiconductor MAX8907 PMIC Support" >> select MFD_CORE >> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile >> index 53467e2..fe4f75c 100644 >> --- a/drivers/mfd/Makefile >> +++ b/drivers/mfd/Makefile >> @@ -117,6 +117,7 @@ obj-$(CONFIG_MFD_DA9063) += da9063.o >> obj-$(CONFIG_MFD_MAX14577) += max14577.o >> obj-$(CONFIG_MFD_MAX77686) += max77686.o >> obj-$(CONFIG_MFD_MAX77693) += max77693.o >> +obj-$(CONFIG_MFD_MAX77843) += max77843.o >> obj-$(CONFIG_MFD_MAX8907) += max8907.o >> max8925-objs := max8925-core.o max8925-i2c.o >> obj-$(CONFIG_MFD_MAX8925) += max8925.o >> diff --git a/drivers/mfd/max77843.c b/drivers/mfd/max77843.c >> new file mode 100644 >> index 0000000..d7f8b76 >> --- /dev/null >> +++ b/drivers/mfd/max77843.c >> @@ -0,0 +1,241 @@ >> +/* >> + * max77843.c - MFD core driver for the Maxim MAX77843 >> + * >> + * Copyright (C) 2014 Samsung Electrnoics >> + * Author: Jaewon Kim >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the Free Software Foundation; either version 2 of the License, or >> + * (at your option) any later version. >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static const struct mfd_cell max77843_devs[] = { >> + { >> + .name = "max77843-muic", >> + .of_compatible = "maxim,max77843-muic", >> + }, { >> + .name = "max77843-regulator", >> + .of_compatible = "maxim,max77843-regulator", >> + }, { >> + .name = "max77843-charger", >> + .of_compatible = "maxim,max77843-charger" >> + }, { >> + .name = "max77843-fuelgauge", >> + .of_compatible = "maxim,max77843-fuelgauge", >> + }, >> +}; >> + >> +static const struct regmap_config max77843_charger_regmap_config = { >> + .reg_bits = 8, >> + .val_bits = 8, >> + .max_register = MAX77843_CHG_REG_END, >> +}; >> + >> +static const struct regmap_config max77843_regmap_config = { >> + .reg_bits = 8, >> + .val_bits = 8, >> + .max_register = MAX77843_SYS_REG_END, >> +}; >> + >> +static const struct regmap_irq max77843_irqs[] = { >> + /* TOPSYS interrupts */ >> + { .reg_offset = 0, .mask = MAX77843_SYS_IRQ_SYSUVLO_INT, }, >> + { .reg_offset = 0, .mask = MAX77843_SYS_IRQ_SYSOVLO_INT, }, >> + { .reg_offset = 0, .mask = MAX77843_SYS_IRQ_TSHDN_INT, }, >> + { .reg_offset = 0, .mask = MAX77843_SYS_IRQ_TM_INT, }, >> +}; >> + >> +static const struct regmap_irq_chip max77843_irq_chip = { >> + .name = "max77843", >> + .status_base = MAX77843_SYS_REG_SYSINTSRC, >> + .mask_base = MAX77843_SYS_REG_SYSINTMASK, >> + .mask_invert = false, >> + .num_regs = 1, >> + .irqs = max77843_irqs, >> + .num_irqs = ARRAY_SIZE(max77843_irqs), >> +}; >> + >> +static int max77843_chg_init(struct max77843 *max77843) >> +{ > > Could this function be moved to the charger driver? This way the > driver will manage its own resources instead of depending on parent > MFD driver. > Charger regulator and Charger share same resources. So I include this function core driver. >> + int ret; >> + >> + max77843->i2c_chg = i2c_new_dummy(max77843->i2c->adapter, I2C_ADDR_CHG); >> + if (!max77843->i2c_chg) { >> + dev_err(&max77843->i2c->dev, >> + "Cannot allocate I2C device for Charger\n"); >> + return PTR_ERR(max77843->i2c_chg); >> + } >> + i2c_set_clientdata(max77843->i2c_chg, max77843); >> + >> + max77843->regmap_chg = devm_regmap_init_i2c(max77843->i2c_chg, >> + &max77843_charger_regmap_config); >> + if (IS_ERR(max77843->regmap_chg)) { >> + ret = PTR_ERR(max77843->regmap_chg); >> + goto err_chg_i2c; >> + } >> + >> + return 0; >> + >> +err_chg_i2c: >> + i2c_unregister_device(max77843->i2c_chg); >> + >> + return ret; >> +} >> + >> +static int max77843_probe(struct i2c_client *i2c, >> + const struct i2c_device_id *id) >> +{ >> + struct max77843 *max77843; >> + int ret; >> + unsigned int reg_data; >> + >> + max77843 = devm_kzalloc(&i2c->dev, sizeof(*max77843), GFP_KERNEL); >> + if (!max77843) >> + return -ENOMEM; >> + >> + i2c_set_clientdata(i2c, max77843); >> + max77843->dev = &i2c->dev; >> + max77843->i2c = i2c; >> + max77843->irq = i2c->irq; >> + >> + max77843->regmap = devm_regmap_init_i2c(i2c, >> + &max77843_regmap_config); >> + if (IS_ERR(max77843->regmap)) { >> + dev_err(&i2c->dev, "Failed to allocate topsys register map\n"); >> + return PTR_ERR(max77843->regmap); >> + } >> + >> + ret = regmap_add_irq_chip(max77843->regmap, max77843->irq, >> + IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED, >> + 0, &max77843_irq_chip, &max77843->irq_data); > > Why shared IRQ? > >> + if (ret) { >> + dev_err(&i2c->dev, "Failed to add TOPSYS IRQ chip\n"); >> + return ret; >> + } >> + >> + ret = regmap_read(max77843->regmap, >> + MAX77843_SYS_REG_PMICID, ®_data); >> + if (ret < 0) { >> + dev_err(&i2c->dev, "Failed to read PMIC ID\n"); >> + goto err_pmic_id; >> + } >> + dev_info(&i2c->dev, "device ID: 0x%x\n", reg_data); >> + >> + ret = max77843_chg_init(max77843); >> + if (ret) { >> + dev_err(&i2c->dev, "Failed to init Charger\n"); >> + goto err_pmic_id; >> + } >> + >> + ret = regmap_update_bits(max77843->regmap, >> + MAX77843_SYS_REG_INTSRCMASK, >> + MAX77843_INTSRC_MASK_MASK, >> + (unsigned int)~MAX77843_INTSRC_MASK_MASK); >> + if (ret < 0) { >> + dev_err(&i2c->dev, "Failed to unmask interrupt sourece\n"); > > s/sourece/source/ > > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html