All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Kukjin Kim <kgene@kernel.org>, linux-samsung-soc@vger.kernel.org
Cc: 'Javier Martinez Canillas' <javier.martinez@collabora.co.uk>,
	jy0922.shim@samsung.com, 'Kevin Hilman' <khilman@linaro.org>,
	'Sjoerd Simons' <sjoerd.simons@collabora.co.uk>
Subject: Re: [PATCH] ARM: dts: exynos5422-odroidxu3: reduce total RAM by 22 MiB
Date: Fri, 23 Jan 2015 08:26:59 +0100	[thread overview]
Message-ID: <54C1F7C3.7050103@samsung.com> (raw)
In-Reply-To: <0b5601d036d6$d9628c80$8c27a580$@kernel.org>

Hello,

On 2015-01-23 07:35, Kukjin Kim wrote:
> Marek Szyprowski wrote:
>> Last 22 MiB is RAM is reserved by secure monitor code and cannot be
>> accessed from Linux kernel, so adjust total RAM size to 0x7EA00000
>> (2 GiB - 22 MiB). This fixes random 'imprecise kernel abort' kernel
>> failures.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5422-odroidxu3.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index f6fc9442f631..50843208860d 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -18,7 +18,7 @@
>>   	compatible = "hardkernel,odroid-xu3", "samsung,exynos5800", "samsung,exynos5";
>>
>>   	memory {
>> -		reg = <0x40000000 0x80000000>;
>> +		reg = <0x40000000 0x7EA00000>;
>>   	};
>>
>>   	chosen {
>> --
> Hi,
>
> Maybe is it related to the SoC not only for odriodxu3 board. If so, following
> would be better?
>
> ---8<------------8<---
> diff --git a/arch/arm/boot/dts/exynos5800.dtsi b/arch/arm/boot/dts/exynos5800.dtsi
> index c0bb356..54840e3 100644
> --- a/arch/arm/boot/dts/exynos5800.dtsi
> +++ b/arch/arm/boot/dts/exynos5800.dtsi
> @@ -13,6 +13,8 @@
>    * published by the Free Software Foundation.
>    */
>
> +/memreserve/ 0x80000000 0x1600000;
> +
>   #include "exynos5420.dtsi"
>
>   / {

I don't think so. It is related only to the setup done by the respective 
board's bootloader,
not the SoC itself. It is already known that exynos 5800-based 
Chromebooks uses different
bootloader setup (BL1+BL2+Trustzone) than Odroid XU3. Also please note 
that u-boot for Odroid
XU3 limits the total memory passed to Linux kernel to 0x7EA00000, so we 
should not confuse
the kernel about such 'reserved' regions. The same approach is used for 
Odroid X2/U3.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

  reply	other threads:[~2015-01-23  7:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 12:22 Marek Szyprowski
2015-01-23  6:35 ` Kukjin Kim
2015-01-23  7:26   ` Marek Szyprowski [this message]
2015-01-23  7:50     ` Kukjin Kim
2015-01-23  8:52   ` Sjoerd Simons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C1F7C3.7050103@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=jy0922.shim@samsung.com \
    --cc=kgene@kernel.org \
    --cc=khilman@linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sjoerd.simons@collabora.co.uk \
    --subject='Re: [PATCH] ARM: dts: exynos5422-odroidxu3: reduce total RAM by 22 MiB' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.