From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Fri, 23 Jan 2015 10:47:57 +0100 Subject: [U-Boot] [PATCH 07/14] arm: mx6: cm-fx6: display compulab logo In-Reply-To: <54C13478.3020802@compulab.co.il> References: <1421224974-16631-1-git-send-email-nikita@compulab.co.il> <1421224974-16631-8-git-send-email-nikita@compulab.co.il> <54C0C9C2.4030502@denx.de> <54C13478.3020802@compulab.co.il> Message-ID: <54C218CD.1050206@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Nikita, On 22/01/2015 18:33, Nikita Kiryanov wrote: >> >> This is a general question, not strictly related to the patch. You add >> with the series a way to get splash screen from multiple sources. I have >> often (I know we are talking about different things..) used splash >> screen as a way to add a logo, without the necessity to link the image >> to the code. I think also that the way with logo does not scale well, > > Why not? Well, it happens if for each maintained board there is a corresponding logo and all logos should be maintain in U-Boot repository - that is quite a mess. Logos has nothing to do with U-Boot development - they are blob data. The fact that they are linked together with U-Boot looks easy, but I do not think it is elegant. Splash images are loaded on demand by u-boot code from a storage - this is IMHO a better solution. > >> and we cannot merge in mainline tons of images - they have nothing to do >> with u-boot sources. > > Storing graphics that are part of a program in the program's repository > is a > common practice, why should U-Boot be different? Maybe due to the number of boards, and if each board wants to have its own logo. If all boards share the same logo I would not see any problem at all. >> Why is not enough for you to use the splash screen functionality ? IMHO >> it is much more flexible as using the logo, and there is no need to link >> it against the code. > > We are interested in the behavior that VIDEO_LOGO provides: that the logo > remains visible on screen and coexists with the frame buffer console, > and that > no manual installation is required. ok, you like really the logo feature, I see ;-). Added Anatolji to CC - we could let the question in background for the future. Maybe could we have a logo_load_image() near splash_load_from_*() ? Besst regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================