All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>,
	Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 7/7] fast-import: minor style fix
Date: Fri, 23 Jan 2015 13:22:36 +0100	[thread overview]
Message-ID: <54C23D0C.8020207@web.de> (raw)
In-Reply-To: <1422011323-4278-1-git-send-email-kuleshovmail@gmail.com>

On 2015-01-23 12.08, Alexander Kuleshov wrote:
..
Asterisk must be next with variable
..
But this is a function:
> -static char* make_fast_import_path(const char *path)
> +static char *make_fast_import_path(const char *path)

(Sorry when I need to read this:)

 - Fixing style violations while working on a real change as a
   preparatory clean-up step is good, but otherwise avoid useless code
   churn for the sake of conforming to the style.

   "Once it _is_ in the tree, it's not really worth the patch noise to
   go and fix it up."
   Cf. http://article.gmane.org/gmane.linux.kernel/943020

  reply	other threads:[~2015-01-23 12:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 11:06 [PATCH 0/7] Coding style fixes Alexander Kuleshov
2015-01-23 11:07 ` [PATCH 1/7] show-branch: minor style fix Alexander Kuleshov
2015-01-23 11:08 ` [PATCH 2/7] clone: " Alexander Kuleshov
2015-01-23 11:08 ` [PATCH 3/7] test-hashmap: " Alexander Kuleshov
2015-01-23 11:08 ` [PATCH 4/7] http-backend: " Alexander Kuleshov
2015-01-23 11:08 ` [PATCH 5/7] refs: " Alexander Kuleshov
2015-01-23 11:08 ` [PATCH 6/7] quote: " Alexander Kuleshov
2015-01-23 11:08 ` [PATCH 7/7] fast-import: " Alexander Kuleshov
2015-01-23 12:22   ` Torsten Bögershausen [this message]
2015-01-23 12:09 ` [PATCH 0/7] Coding style fixes Alexander Kuleshov
2015-01-23 18:36   ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C23D0C.8020207@web.de \
    --to=tboegi@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kuleshovmail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.