All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: David Howells <dhowells@redhat.com>
Cc: Michal Marek <mmarek@suse.cz>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] modsign: provide option to automatically delete the key after modules were installed
Date: Fri, 23 Jan 2015 14:35:16 +0100	[thread overview]
Message-ID: <54C24E14.60701@ahsoftware.de> (raw)
In-Reply-To: <54C24C30.8030106@ahsoftware.de>

Sorry, either I type too fast or I think too slow, so here is another 
comment:

Am 23.01.2015 um 14:27 schrieb Alexander Holler:
> Am 23.01.2015 um 13:56 schrieb David Howells:
>
>> One thing that you have to be careful of with your patch is that if
>> you turn
>> it on during development, this will drain the entropy pool from which
>> you get
>> random numbers.
>
> Hmm, I wonder how often people are compiling kernels and how much one
> turn drains the entropy pool.
>
> I would suggest to just get better in coding (and reviewing before
> compile testing) in order to not having to build kernels that often. Or
> just use a different config for development. ;)
>
> My primary use case is just what Linus described in his keynote. I'm
> building and signing all my kernels whenever a new stable kernel
> appears, throwing away the keys away immediately afterwards.
>
> And the patch avoids that I have to type the rm, and, even more usefull,
> it makes sure I don't forget to delete the keys, which would make
> signing the modules useless for me (as my kernel build directories (and
> thus the private keys) are usually residing on the machine the kernel is
> deployed afterwards).

Besides that the keys are only deleted when modules_install is called. 
And that usually is only called if the kernels execution will be tested 
in real, which should offer enough time to fill the entropy pool. If the 
kernel and the modules are just build (and not installed), the keys will 
not be deleted.

Regards,

Alexander Holler

  reply	other threads:[~2015-01-23 13:35 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23  1:20 [PATCH] modsign: provide option to automatically delete the key after modules were installed Alexander Holler
2015-01-23  9:24 ` Michal Marek
2015-01-23  9:39   ` Alexander Holler
2015-01-23 10:15     ` Alexander Holler
2015-01-23 10:55       ` Michal Marek
2015-01-23 11:43         ` Alexander Holler
2015-01-23 11:54           ` Alexander Holler
2015-01-23 12:34             ` Alexander Holler
2015-01-23 18:26               ` Alexander Holler
2015-01-23 12:56             ` David Howells
2015-01-23 13:27               ` Alexander Holler
2015-01-23 13:35                 ` Alexander Holler [this message]
2015-01-23 21:57 ` [PATCH] modsign: overwrite keys with zero before deleting them Alexander Holler
2015-01-23 22:06   ` Richard Weinberger
2015-01-23 22:16     ` Alexander Holler
2015-01-23 23:58 ` David Howells
2015-01-24  0:13   ` Alexander Holler
2015-01-24  1:27     ` Pádraig Brady
2015-01-24 10:45       ` [PATCH v2] modsign: use shred to overwrite the private key before deleting it Alexander Holler
2015-01-24 11:37         ` Alexander Holler
2015-01-24 12:09           ` Alexander Holler
2015-01-24 12:29             ` Alexander Holler
2015-01-25  2:13               ` Pádraig Brady
2015-01-25  2:43                 ` Alexander Holler
2015-01-25 10:32                   ` Alexander Holler
2015-01-25 10:57                     ` Alexander Holler
2015-01-25 11:42                       ` Alexander Holler
2015-01-25 12:04                         ` Alexander Holler
2015-01-25 12:08                         ` Richard Weinberger
2015-01-25 12:24                           ` Alexander Holler
2015-01-25 12:28                             ` Richard Weinberger
2015-01-25 12:57                               ` Alexander Holler
2015-01-25 12:36                             ` Alexander Holler
2015-01-25 13:46                               ` Alexander Holler
2015-01-29 22:39                     ` Alexander Holler
2015-07-18 21:56 ` [PATCH] modsign: provide option to automatically delete the key after modules were installed Alexander Holler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C24E14.60701@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=dhowells@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.