All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xenproject.org
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Jenny Herbert <jennifer.herbert@citrix.com>
Subject: Re: [PATCH 12/14] xen-blkback: safely unmap grants in case they are still in use
Date: Fri, 23 Jan 2015 15:41:43 +0100	[thread overview]
Message-ID: <54C25DA7.7000605@citrix.com> (raw)
In-Reply-To: <54C23865.7010404@citrix.com>

El 23/01/15 a les 13.02, David Vrabel ha escrit:
> On 19/01/15 15:51, David Vrabel wrote:
>> From: Jenny Herbert <jennifer.herbert@citrix.com>
>>
>> Use gnttab_unmap_refs_async() to wait until the mapped pages are no
>> longer in use before unmapping them.
>>
>> This allows blkback to use network storage which may retain refs to
>> pages in queued skbs after the block I/O has completed.
> 
> Roger, I'd appreciate a review of this blkback change.

Done. BTW, have you tested the patch setting:

# echo 128 > /sys/module/xen_blkback/parameters/max_persistent_grants

Without this some of the newly introduced code-paths would remain
untested (replace 128 with whatever you want, or even 0).

Roger.

  reply	other threads:[~2015-01-23 14:41 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 15:51 [PATCHv3 00/14] xen: fix many long-standing grant mapping bugs David Vrabel
2015-01-19 15:51 ` [PATCH 01/14] mm: provide a find_special_page vma operation David Vrabel
2015-01-19 15:51 ` [PATCH 02/14] mm: add 'foreign' alias for the 'pinned' page flag David Vrabel
2015-01-19 15:51 ` [PATCH 03/14] xen/grant-table: pre-populate kernel unmap ops for xen_gnttab_unmap_refs() David Vrabel
2015-01-19 15:51 ` [PATCH 04/14] xen: remove scratch frames for ballooned pages and m2p override David Vrabel
2015-01-19 15:51 ` [PATCH 05/14] x86/xen: require ballooned pages for grant maps David Vrabel
2015-01-19 15:51 ` [PATCH 06/14] xen/grant-table: add helpers for allocating pages David Vrabel
2015-01-19 15:51 ` [PATCH 07/14] xen: mark grant mapped pages as foreign David Vrabel
2015-01-19 15:51 ` [PATCH 08/14] xen-netback: use foreign page information from the pages themselves David Vrabel
2015-01-19 15:51 ` [PATCH 09/14] xen/grant-table: add a mechanism to safely unmap pages that are in use David Vrabel
2015-01-19 15:51 ` [PATCH 10/14] xen/gntdev: convert priv->lock to a mutex David Vrabel
2015-01-19 17:49   ` Stefano Stabellini
2015-01-19 17:53     ` David Vrabel
2015-01-19 18:38       ` Stefano Stabellini
2015-01-19 18:43         ` David Vrabel
2015-01-19 15:51 ` [PATCH 11/14] xen/gntdev: safely unmap grants in case they are still in use David Vrabel
2015-01-19 15:51 ` [PATCH 12/14] xen-blkback: " David Vrabel
2015-01-23 12:02   ` David Vrabel
2015-01-23 14:41     ` Roger Pau Monné [this message]
2015-01-23 14:31   ` Roger Pau Monné
2015-01-23 14:54     ` David Vrabel
2015-01-23 15:47       ` Roger Pau Monné
2015-01-23 16:00         ` David Vrabel
2015-01-26 15:00           ` David Vrabel
2015-01-24  8:57         ` Roger Pau Monné
2015-01-26 15:02   ` David Vrabel
2015-01-26 17:34     ` Jens Axboe
2015-01-19 15:51 ` [PATCH 13/14] xen/gntdev: mark userspace PTEs as special on x86 PV guests David Vrabel
2015-01-19 15:51 ` [PATCH 14/14] xen/gntdev: provide find_special_page VMA operation David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2015-01-12 15:43 [PATCHv2 00/14] xen: fix many long-standing grant mapping bugs David Vrabel
2015-01-12 15:43 ` [PATCH 12/14] xen-blkback: safely unmap grants in case they are still in use David Vrabel
2015-01-14 15:17   ` Boris Ostrovsky
2015-01-14 15:47   ` Boris Ostrovsky
2015-01-14 16:00     ` David Vrabel
2015-01-14 16:22       ` Boris Ostrovsky
2015-01-14 16:33         ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C25DA7.7000605@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=jennifer.herbert@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.