From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next v2 4/5] bonding: fix LACP PDU not sent on slave port sometimes Date: Mon, 26 Jan 2015 15:04:46 +0300 Message-ID: <54C62D5E.9030200@cogentembedded.com> References: <1422253021-3798-1-git-send-email-jtoppins@cumulusnetworks.com> <1422253021-3798-5-git-send-email-jtoppins@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Satish Ashok , Andy Gospodarek To: Jonathan Toppins , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek Return-path: Received: from mail-la0-f42.google.com ([209.85.215.42]:34850 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751910AbbAZMEt (ORCPT ); Mon, 26 Jan 2015 07:04:49 -0500 Received: by mail-la0-f42.google.com with SMTP id ms9so7228073lab.1 for ; Mon, 26 Jan 2015 04:04:48 -0800 (PST) In-Reply-To: <1422253021-3798-5-git-send-email-jtoppins@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 1/26/2015 9:17 AM, Jonathan Toppins wrote: > From: Satish Ashok > When a slave is added to a bond and it is not in full duplex mode, > AD_PORT_LACP_ENABLED flag is cleared, due to this LACP PDU is not sent s/is not/not being/. > on slave. When the duplex is changed to full, the flag needs to be set > to send LACP PDU. > Cc: Andy Gospodarek > Reviewed-by: Nikolay Aleksandrov > Signed-off-by: Satish Ashok > Signed-off-by: Jonathan Toppins > --- > drivers/net/bonding/bond_3ad.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c > index e3c96b2..cfc4a9c 100644 > --- a/drivers/net/bonding/bond_3ad.c > +++ b/drivers/net/bonding/bond_3ad.c > @@ -2219,8 +2219,10 @@ static int bond_3ad_rx_indication(struct lacpdu *lacpdu, struct slave *slave, > switch (lacpdu->subtype) { > case AD_TYPE_LACPDU: > ret = RX_HANDLER_CONSUMED; > - netdev_dbg(slave->bond->dev, "Received LACPDU on port %d\n", > - port->actor_port_number); > + netdev_dbg(slave->bond->dev, > + "Received LACPDU on port %d slave %s\n", > + port->actor_port_number, > + slave->dev->name); > /* Protect against concurrent state machines */ > spin_lock(&slave->bond->mode_lock); > ad_rx_machine(lacpdu, port); > @@ -2312,7 +2314,10 @@ void bond_3ad_adapter_duplex_changed(struct slave *slave) > port->actor_admin_port_key &= ~AD_DUPLEX_KEY_MASKS; > port->actor_oper_port_key = port->actor_admin_port_key |= > __get_duplex(port); > - netdev_dbg(slave->bond->dev, "Port %d changed duplex\n", port->actor_port_number); > + netdev_dbg(slave->bond->dev, "Port %d slave %s changed duplex\n", > + port->actor_port_number, slave->dev->name); The above 2 changes seem unrelated/undocumented in the change log... [...] WBR, Sergei