From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52797)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YFwTW-0000Zp-Mz
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 22:06:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YFwTR-0007TF-QM
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 22:05:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52586)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1YFwTR-0007T3-Ig
	for qemu-devel@nongnu.org; Mon, 26 Jan 2015 22:05:53 -0500
Message-ID: <54C7008C.8090007@redhat.com>
Date: Mon, 26 Jan 2015 20:05:48 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1422284444-12529-1-git-send-email-mreitz@redhat.com>
	<1422284444-12529-7-git-send-email-mreitz@redhat.com>
In-Reply-To: <1422284444-12529-7-git-send-email-mreitz@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="iIUcmkAMNwcX4DXoeAhqebaVLXQf8iRCm"
Subject: Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in
 img_rebase()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--iIUcmkAMNwcX4DXoeAhqebaVLXQf8iRCm
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 01/26/2015 08:00 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  qemu-img.c | 57 ++++++++++++++++++++++++------------------------------=
---
>  1 file changed, 24 insertions(+), 33 deletions(-)
>=20

> -
>      /* For safe rebasing we need to compare old and new backing file *=
/
>      if (!unsafe) {
>          char backing_name[PATH_MAX];
> +        QDict *options =3D NULL;
> +
> +        if (!unsafe && bs->backing_format[0] !=3D '\0') {

Useless conditional ('!unsafe' is always true here).

With that fixed,
Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--iIUcmkAMNwcX4DXoeAhqebaVLXQf8iRCm
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJUxwCMAAoJEKeha0olJ0NqYxsH/AndZ5yDe3Zr712xWcvb1wiB
a5vkk8bXvGqogIqPhL8NCZOvPsrmpuZKwWy3N7YpD/FxoGkplfSmURqsVDU0i8Bl
FSC1cVy2sCIUKhQZjCVt+TSvWKlnq0rU+wGImMYhkR/EANIOZrEkUub6IClHHsII
/X4dE4V8g8wMp6fQVSZRwjSXw339fVcxhcc9ApypeBiM0clSEEP59PMraMFbS9JO
OluobDeNDXorf/vU72hrJ0SXQaJWh6XIwVSXD05Ru4CCxdcLZsTqwpx4+OHUIqb5
kWeITOWv7OGmklT8fdYyO05VUMySnMyyaL+QfsPQ0xYaJ6dWYGCVgDTK7f1SlNU=
=brDK
-----END PGP SIGNATURE-----

--iIUcmkAMNwcX4DXoeAhqebaVLXQf8iRCm--