From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Tue, 27 Jan 2015 09:01:25 +0100 Subject: [U-Boot] [PATCH v2 07/10] dm: i2c: s3c24x0: adjust to dm-i2c api In-Reply-To: References: <1420716524-15969-1-git-send-email-p.marczak@samsung.com> <1422285706-22000-1-git-send-email-p.marczak@samsung.com> <1422285706-22000-8-git-send-email-p.marczak@samsung.com> Message-ID: <54C745D5.5000800@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On 01/27/2015 04:13 AM, Simon Glass wrote: > Hi Przemyslaw, > > On 26 January 2015 at 08:21, Przemyslaw Marczak wrote: >> This commit adjusts the s3c24x0 driver to new i2c api >> based on driver-model. The driver supports standard >> and high-speed i2c as previous. >> >> Tested on Trats2, Odroid U3, Arndale, Odroid XU3 >> >> Signed-off-by: Przemyslaw Marczak >> Cc: Simon Glass >> Cc: Heiko Schocher >> Cc: Minkyu Kang >> > > Tested on snow: > > Tested-by: Simon Glass > > This looks right to me, but I have a number of nits, mostly code that > can be deleted, Please see below. > > If you can respin this I will pick it up. > Thank you for the review, I will fix the issues and resend this today. Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com