From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emil Medve Subject: Re: [PATCH 4/4] iommu/fsl: Use %pa to print phys_addr_t Date: Tue, 27 Jan 2015 04:40:35 -0600 Message-ID: <54C76B23.3010809@Freescale.com> References: <1422316230-18893-1-git-send-email-joro@8bytes.org> <1422316230-18893-5-git-send-email-joro@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422316230-18893-5-git-send-email-joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org Cc: Sethi Varun-B16395 , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, jroedel-l3A5Bk7waGM@public.gmane.org List-Id: iommu@lists.linux-foundation.org Hello Joerg, On 01/26/2015 05:50 PM, Joerg Roedel wrote: > From: Joerg Roedel > > Fix two compile warnings. > > Signed-off-by: Joerg Roedel > --- > drivers/iommu/fsl_pamu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c > index 80ac68d..e63904b 100644 > --- a/drivers/iommu/fsl_pamu.c > +++ b/drivers/iommu/fsl_pamu.c > @@ -352,7 +352,7 @@ int pamu_config_ppaace(int liodn, phys_addr_t win_addr, phys_addr_t win_size, > unsigned long fspi; > > if ((win_size & (win_size - 1)) || win_size < PAMU_PAGE_SIZE) { > - pr_debug("window size too small or not a power of two %llx\n", win_size); > + pr_debug("window size too small or not a power of two %pa\n", &win_size); > return -EINVAL; > } Somewhere around line 1124 there another opportunity for this fix: > 1124 dev_dbg(&pdev->dev, "ppaact virt=%p phys=0x%llx\n", ppaact, > 1125 (unsigned long long) ppaact_phys); Cheers, > @@ -1138,7 +1138,7 @@ static int __init fsl_pamu_probe(struct platform_device *pdev) > > if (csd_port_id) { > dev_dbg(&pdev->dev, "creating coherency subdomain at address " > - "0x%llx, size %zu, port id 0x%08x", ppaact_phys, > + "%pa, size %zu, port id 0x%08x", &ppaact_phys, > mem_size, csd_port_id); > > ret = create_csd(ppaact_phys, mem_size, csd_port_id);