From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9es-000437-6o for qemu-devel@nongnu.org; Tue, 27 Jan 2015 12:10:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG9eo-0005aL-4i for qemu-devel@nongnu.org; Tue, 27 Jan 2015 12:10:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9en-0005aF-UE for qemu-devel@nongnu.org; Tue, 27 Jan 2015 12:10:30 -0500 Message-ID: <54C7C682.2080609@redhat.com> Date: Tue, 27 Jan 2015 10:10:26 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422284444-12529-1-git-send-email-mreitz@redhat.com> <1422284444-12529-11-git-send-email-mreitz@redhat.com> <54C7C40C.8040601@redhat.com> <54C7C524.4030509@redhat.com> In-Reply-To: <54C7C524.4030509@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N3Hku8590xSICpD1TvDWoNsJOvj7uCxJW" Subject: Re: [Qemu-devel] [PATCH v3 10/14] qemu-io: Remove "growable" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , Stefano Stabellini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N3Hku8590xSICpD1TvDWoNsJOvj7uCxJW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 10:04 AM, Max Reitz wrote: > On 2015-01-27 at 11:59, Eric Blake wrote: >> On 01/26/2015 08:00 AM, Max Reitz wrote: >>> Remove "growable" option from the "open" command and from the qemu-io= >>> command line. qemu-io is about to be converted to BlockBackend which >>> will make sure that no request exceeds the image size, so the only wa= y >>> to keep "growable" would be to use BlockBackend if it is not given an= d >>> to directly access the BDS if it is. >>> >>> qemu-io is a debugging tool, therefore removing a rarely used option >>> will have only a very small impact, if any. There was only one >>> qemu-iotest which used the option; since it is not critical, this pat= ch >>> just removes it. >>> >>> Signed-off-by: Max Reitz >>> --- >> Reviewed-by: Eric Blake >> >> Do we want to ever reuse the test number that you are deleting? >=20 > Good question, I think I have talked about that with Kevin before. It > would not hurt too much if we were to accidentally reuse the test case > number, most certainly not here in upstream. >=20 > However, for all downstream versions of qemu, this might make adding th= e > new test 16 difficult; but certainly not impossible (if someone is > affected by this issue, he/she can just use 999 or something). So we ma= y > want to keep in mind not to reuse number 16, but if someone does, so be= it. Is it worth a placeholder file that has a comment mentioning that the test number is intentionally reserved (and if someone attempts to run, always passes)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --N3Hku8590xSICpD1TvDWoNsJOvj7uCxJW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUx8aCAAoJEKeha0olJ0NqJHgIAIyFxhgPJe2Fp7Roi2Z2fIiB XVDfblr0qYYiFJqkF7QUhkdLnB1P5aR6V+ePOqMpU92HcIcFsV3RBucqUQezbYzf bZCjpm/2ZUd6iPKnKKg2KrOVM8ySD0NHUpgsJjc4zKk7/6aDxYBqKjAVPW5twjzW EZWRgp6oSqnTLff/BPd2ASneDmLCnvJGodsLQGVAfev9UeE52bMuQihTjNfhflhh Ommeusa1s8WW4S9JKqrHxqOZrk6BkCz8UPCpumaJ2ksrhOF4bX7BZSSht3IZT7LT f++le6FAxNPO1r4VpUn9XeLUu08bZj300iaAbvBALUzc1pX7dYyoJ/jo1DjW5qc= =ObIA -----END PGP SIGNATURE----- --N3Hku8590xSICpD1TvDWoNsJOvj7uCxJW--