From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9xQ-0007kz-AS for qemu-devel@nongnu.org; Tue, 27 Jan 2015 12:29:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YG9xN-00037u-19 for qemu-devel@nongnu.org; Tue, 27 Jan 2015 12:29:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YG9xM-00037o-Ov for qemu-devel@nongnu.org; Tue, 27 Jan 2015 12:29:40 -0500 Message-ID: <54C7CAFF.7030907@redhat.com> Date: Tue, 27 Jan 2015 10:29:35 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422284444-12529-1-git-send-email-mreitz@redhat.com> <1422284444-12529-14-git-send-email-mreitz@redhat.com> In-Reply-To: <1422284444-12529-14-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QewgNSVUCJRrl8NntBHJt5InA5FFfkgaA" Subject: Re: [Qemu-devel] [PATCH v3 13/14] block: Remove "growable" from BDS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , Stefano Stabellini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QewgNSVUCJRrl8NntBHJt5InA5FFfkgaA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 08:00 AM, Max Reitz wrote: > Now that request clamping is done in the BlockBackend, the "growable" > field can be removed from the BlockDriverState. All BDSs are now treate= d > as being "growable" (that is, they are allowed to grow; they are not > necessarily actually able to). >=20 > Signed-off-by: Max Reitz > --- > +++ b/include/block/block_int.h > @@ -369,9 +369,6 @@ struct BlockDriverState { > /* I/O Limits */ > BlockLimits bl; > =20 > - /* Whether the disk can expand beyond total_sectors */ > - int growable; > - Yay - getting rid of an 'int' that was only used to hold 'bool' values :)= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QewgNSVUCJRrl8NntBHJt5InA5FFfkgaA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUx8r/AAoJEKeha0olJ0NqNdYIAKh4hRPySV0Qkth2xMBFt1EL etlanaLGwa4k/CzIP5gsA2ZkvuyBdiDsaaGRgGpzr3SvV+G+Oe82/7cR7k6j/na7 EEk85f5Y58rNRwDuhk0haMvvQJ6eszDI8QA+WdthZKQ0iWRRzMdqzeQ0XL9yognT pG157Ib4C18pHhw+6U9Y1P5jHcoJQ3TugJkwv4taemUqFqMEv5G7yDeIHz4sf69N DKQyHQxm6yliyeBJEHK7GqKjkuDrExrouazZvP1ycwQr6CRwwYZpwy8BzjpR2EjV +XWixTXIdgfx4B+DcGTMMdnkDVhiQMCsJRtYywQz/t6faOm5klafrs6jUPm8/7Q= =8PD8 -----END PGP SIGNATURE----- --QewgNSVUCJRrl8NntBHJt5InA5FFfkgaA--