From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGAgj-0003VG-HQ for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:16:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGAge-0005Sh-Hk for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:16:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGAge-0005S6-6z for qemu-devel@nongnu.org; Tue, 27 Jan 2015 13:16:28 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RIGRuv029353 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 27 Jan 2015 13:16:27 -0500 Message-ID: <54C7D5FA.8050509@redhat.com> Date: Tue, 27 Jan 2015 11:16:26 -0700 From: Eric Blake MIME-Version: 1.0 References: <51cf53611ea22a2c1ca0d55ad5e8ab13dcdea26f.1422285793.git.pkrempa@redhat.com> In-Reply-To: <51cf53611ea22a2c1ca0d55ad5e8ab13dcdea26f.1422285793.git.pkrempa@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NPDtbCUVrMBcWRNde1s6M1n8DAxBHRC1J" Subject: Re: [Qemu-devel] [PATCH 2/2] pc: memory: Validate alignment of maxram_size to page size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa , qemu-devel@nongnu.org Cc: Igor Mammedov This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NPDtbCUVrMBcWRNde1s6M1n8DAxBHRC1J Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 08:31 AM, Peter Krempa wrote: > If the maxram_size is not aligned and dimm devices were added on the > command line qemu would terminate with a rather unhelpful message: >=20 > ERROR:hw/mem/pc-dimm.c:150:pc_dimm_get_free_addr: assertion failed: > (QEMU_ALIGN_UP(address_space_size, align) =3D=3D address_space_size) >=20 > In case no dimm device was originally added on the commandline qemu > exits on the assertion failure. >=20 > Signed-off-by: Peter Krempa > --- > hw/i386/pc.c | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NPDtbCUVrMBcWRNde1s6M1n8DAxBHRC1J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUx9X6AAoJEKeha0olJ0Nq/wcH/R2mZGtmIG3x4M5uYEkEabL1 LjVOUKQAzi8nMcqRZs70i0iYpuSKkmRsxUyjpRb7b+b2ZRwJXDakjLwV93kraQyh yrUaf9TrQhS1+XiPgzpJtU/AhdVzVwx6QFHpb3AU8rNb0+Y4b6iJwYsBfqyToVs4 eIt3p6/WM5E7l4u9FnOKppl3wG80JasX1vIjcRyZx0rcvPR4qSBGIoBJn7GrQr/U BDwSnvOE2qgTlXFgEmtFGWoHeimh2AgaTVLqW5oa6SyPN7gBIxtEX9AdZMCyhl5n lXfaYyISycGRdypuyaH2XpGzy7sI8ShRTldUghPSyJLvyyKy6u8QaeNQScJLhLs= =9jKe -----END PGP SIGNATURE----- --NPDtbCUVrMBcWRNde1s6M1n8DAxBHRC1J--