From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGFoX-0002Fc-N8 for qemu-devel@nongnu.org; Tue, 27 Jan 2015 18:44:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGFoT-0000V5-OO for qemu-devel@nongnu.org; Tue, 27 Jan 2015 18:44:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGFoT-0000V1-Fo for qemu-devel@nongnu.org; Tue, 27 Jan 2015 18:44:53 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0RNiq1Z002214 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 27 Jan 2015 18:44:52 -0500 Message-ID: <54C822F3.4030900@redhat.com> Date: Tue, 27 Jan 2015 16:44:51 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-23-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-23-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dOnFNBDcdqVx1FENwSWGdWrXAMUo5oXAl" Subject: Re: [Qemu-devel] [PATCH RESEND 22/50] blockdev: Check BB validity in drive-backup TA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dOnFNBDcdqVx1FENwSWGdWrXAMUo5oXAl Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 12:45 PM, Max Reitz wrote: > In the drive-backup transaction, call blk_is_available() before using > blk_bs() to obtain the root BlockDriverState behind the BlockBackend. Took me a while to figure that TA meant transaction in the subject. Either spell it out, or just drop 'TA' entirely (the shorter subject would still make sense). (21/50 as well). >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dOnFNBDcdqVx1FENwSWGdWrXAMUo5oXAl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyCLzAAoJEKeha0olJ0Nq5fAH/RCfdj2NPKTaztCiCKx745Tq EHg5lmhuU0m6OyeFcTa0p6yCVvL3x2JWGg/UnZkTWtrz0TYJQxIvZX4ie/c0kDVJ Sfg88Ms1/yAW5JrNrNDiQ8fJxgFgn6EO/NiU2+4pEBXKWzrIyh7PTpZbRXbWZo3L SLGBx7u9Gd2qPplQqnHAlmEGn3YRnkcbYRMF/Uzm+Avy4qZESsLVgytwd1jtScqp SDtJJDxEXPBHH8S7mTTvtT3TZYkeSb761P5+ViJTLtPRoGcXi24CIrRrnLpU2WSE 6I3v41dUeD/Rn58nEEpj+7bIWlv5g75TZlZxBDmTElGyyEU8HrHVau8VcsfXkkU= =4pdB -----END PGP SIGNATURE----- --dOnFNBDcdqVx1FENwSWGdWrXAMUo5oXAl--