All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: EFI GetNextVariableName crashes when running under Xen, but not under Linux. efi-rs=0 works. No memmap issues
Date: Wed, 28 Jan 2015 08:40:44 +0000	[thread overview]
Message-ID: <54C8AE9C020000780005A31D@mail.emea.novell.com> (raw)
In-Reply-To: <20150127182028.GB3678@x230.dumpdata.com>

>>> On 27.01.15 at 19:20, <konrad.wilk@oracle.com> wrote:
> On Tue, Jan 27, 2015 at 04:17:05PM +0000, Jan Beulich wrote:
>> Again - apart from mapping the range, did you also make sure it
>> didn't get passed to the allocator (and hence couldn't have got
>> overwritten)?
> 
> Yes, see patch:

Oh, sorry, I must have not looked closely enough.

> Also see attached of the code with what Linux sees and what Xen sees
> (Linux first).

Indeed this

  8b:	44 38 2d c2 10 00 00 	cmp    %r13b,0x10c2(%rip)        # 0x115 [01 01 00 00 00 00 00 00][00 01 00 00 00 00 00 00
  92:	75 12                	jne    0xa6

causes the code in question to be skipped under Linux.

> I am thinking that the firmware is under the assumption
> that if SetVirtualAddressMap is not called then you MUST be still
> before ExitBootServices has been called. Going to verify that by
> implementing an GetNextVariableName before calling ExitBootServices)

Not sure how exactly you envision to do this, but I'm having a hard
time seeing how this would prove anything, in particular because
calling runtime services functions prior to exiting boot services must
be possible anyway.

And iirc you had already tried calling the function prior to doing much
else (namely, prior to loading Dom0), and it still crashed? Did you
investigate when the memory type of that region changes (in an
earlier mail you said dmem from the EFI shell reported it as Boot
Services, albeit it's not fully clear what that tagging is supposed to
be telling us)?

Jan

  reply	other threads:[~2015-01-28  8:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26 16:27 EFI GetNextVariableName crashes when running under Xen, but not under Linux. efi-rs=0 works. No memmap issues Konrad Rzeszutek Wilk
2015-01-26 16:36 ` Andrew Cooper
2015-01-26 17:28   ` Konrad Rzeszutek Wilk
     [not found] ` <54C680C90200007800059907@mail.emea.novell.com>
     [not found]   ` <20150127000247.GU3473@olila.local.net-space.pl>
     [not found]     ` <54C6DCB7.3060206@citrix.com>
2015-01-27  7:54       ` Jan Beulich
2015-01-27 14:26         ` Konrad Rzeszutek Wilk
2015-01-27 16:17           ` Jan Beulich
2015-01-27 18:20             ` Konrad Rzeszutek Wilk
2015-01-28  8:40               ` Jan Beulich [this message]
2015-01-28 16:03                 ` Konrad Rzeszutek Wilk
2015-01-28 16:12                   ` Konrad Rzeszutek Wilk
2015-01-28 16:17                   ` Daniel Kiper
2015-01-28 16:56                     ` Jan Beulich
2015-01-28 17:20                       ` Konrad Rzeszutek Wilk
2015-01-29 10:35                         ` Jan Beulich
2015-01-30 14:17                           ` Is: kexec & EFI Was: " Konrad Rzeszutek Wilk
2015-01-30 14:40                             ` David Vrabel
2015-01-30 14:52                               ` Konrad Rzeszutek Wilk
2015-01-30 14:57                                 ` David Vrabel
2015-01-30 15:09                                   ` Daniel Kiper
2015-01-30 15:34                                     ` Jan Beulich
2015-01-30 16:24                                       ` Daniel Kiper
2015-01-30 16:41                                         ` Jan Beulich
2015-01-27 20:18         ` Daniel Kiper
2015-01-27 21:48           ` Konrad Rzeszutek Wilk
2015-01-28  8:43           ` Jan Beulich
2015-01-28 12:57             ` Daniel Kiper
2015-01-28 14:02               ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C8AE9C020000780005A31D@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=daniel.kiper@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.