From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759409AbbA1WPi (ORCPT ); Wed, 28 Jan 2015 17:15:38 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:56136 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754773AbbA1UPB (ORCPT ); Wed, 28 Jan 2015 15:15:01 -0500 Message-ID: <54C91DC3.4020101@ti.com> Date: Wed, 28 Jan 2015 12:34:59 -0500 From: Murali Karicheri User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Rob Herring CC: Catalin Marinas , Robin Murphy , "devicetree@vger.kernel.org" , Russell King , Arnd Bergmann , "linux-pci@vger.kernel.org" , Joerg Roedel , Will Deacon , "linux-kernel@vger.kernel.org" , "grant.likely@linaro.org" , "iommu@lists.linux-foundation.org" , Rob Herring , "suravee.suthikulpanit@amd.com" , Bjorn Helgaas , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 3/6] of: fix size when dma-range is not used References: <1422052359-12384-1-git-send-email-m-karicheri2@ti.com> <1422052359-12384-4-git-send-email-m-karicheri2@ti.com> <54C77616.80301@arm.com> <54C7DF13.20402@ti.com> <20150128110523.GC6646@e104818-lin.cambridge.arm.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/28/2015 10:45 AM, Rob Herring wrote: > On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas > wrote: >> On Tue, Jan 27, 2015 at 06:55:15PM +0000, Murali Karicheri wrote: >>> On 01/27/2015 06:27 AM, Robin Murphy wrote: >>>> On 23/01/15 22:32, Murali Karicheri wrote: >>>>> Fix the dma-range size when the DT attribute is missing. i.e set size to >>>>> dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. To detect >>>>> overflow when mask is set to max of u64, add a check, log error and >>>>> return. >>>>> Some platform use mask format for size in DTS. So add a work around to >>>>> catch this and fix. >>>>> >>>>> Cc: Joerg Roedel >>>>> Cc: Grant Likely >>>>> Cc: Rob Herring >>>>> Cc: Bjorn Helgaas >>>>> Cc: Will Deacon >>>>> Cc: Russell King >>>>> Cc: Arnd Bergmann >>>>> Cc: Suravee Suthikulpanit >>>>> >>>>> Signed-off-by: Murali Karicheri >>>>> --- >>>>> drivers/of/device.c | 14 +++++++++++++- >>>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/of/device.c b/drivers/of/device.c >>>>> index 2de320d..0a5ff54 100644 >>>>> --- a/drivers/of/device.c >>>>> +++ b/drivers/of/device.c >>>>> @@ -105,12 +105,24 @@ void of_dma_configure(struct device *dev, struct >>>>> device_node *np) >>>>> ret = of_dma_get_range(np,&dma_addr,&paddr,&size); >>>>> if (ret< 0) { >>>>> dma_addr = offset = 0; >>>>> - size = dev->coherent_dma_mask; >>>>> + size = dev->coherent_dma_mask + 1; >>>>> } else { >>>>> offset = PFN_DOWN(paddr - dma_addr); >>>>> + /* >>>>> + * Add a work around to treat the size as mask + 1 in case >>>>> + * it is defined in DT as a mask. >>>>> + */ >>>>> + if (size& 1) >>>>> + size = size + 1; >>>>> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", offset); >>>>> } >>>>> >>>>> + /* if size is 0, we have an overflow of u64 */ >>>>> + if (!size) { >>>>> + dev_err(dev, "invalid size\n"); >>>>> + return; >>>>> + } >>>>> + >>>> >>>> This seems potentially fragile to dodgy DTs given that we might also be >>>> using size to make a mask later. Would it make sense to double-up a >>>> sanity check as mask-format detection? Something like: >>>> >>>> if is_power_of_2(size) >>>> // use size >>>> else if is_power_of_2(size + 1) >>>> // use size + 1 >>>> else >>>> // cry >>> >>> How about having the logic like this? >>> >>> ret = of_dma_get_range(np,&dma_addr,&paddr,&size); >>> if (ret< 0) { >>> dma_addr = offset = 0; >>> size = dev->coherent_dma_mask + 1; >>> } else { >>> offset = PFN_DOWN(paddr - dma_addr); >>> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", offset); >>> } >>> >>> if (is_power_of_2(size + 1)) >>> size = size + 1; >>> else if (!is_power_of_2(size)) >>> { >>> dev_err(dev, "invalid size\n"); >>> return; >>> } >> >> In of_dma_configure(), we currently assume that the default coherent >> mask is 32-bit. In this thread: >> >> http://article.gmane.org/gmane.linux.kernel/1835096 >> >> we talked about setting the coherent mask based on size automatically. >> I'm not sure about the size but I think we can assume is 32-bit mask + 1 >> if it is not specified in the DT. Instead of just assuming a default >> mask, let's assume a default size and create the mask based on this >> (untested): >> >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >> index 5b33c6a21807..9ff8d1286b44 100644 >> --- a/drivers/of/platform.c >> +++ b/drivers/of/platform.c >> @@ -170,10 +170,10 @@ static void of_dma_configure(struct device *dev) >> struct iommu_ops *iommu; >> >> /* >> - * Set default dma-mask to 32 bit. Drivers are expected to setup >> - * the correct supported dma_mask. >> + * Set default size to cover the 32-bit. Drivers are expected to setup >> + * the correct size and dma_mask. >> */ >> - dev->coherent_dma_mask = DMA_BIT_MASK(32); >> + size = 1ULL<< 32; >> >> /* >> * Set it to coherent_dma_mask by default if the architecture >> @@ -185,13 +185,24 @@ static void of_dma_configure(struct device *dev) >> ret = of_dma_get_range(dev->of_node,&dma_addr,&paddr,&size); >> if (ret< 0) { >> dma_addr = offset = 0; >> - size = dev->coherent_dma_mask; > > Are we assuming dma_addr, paddr and size are not touched on error? If > so, we can get rid of this clause entirely. Checking the code for of_dma_get_range() I see paddr is modified on error case, but is used only for success case in this function. dma_addr and size are not modified. So setting dma_addr and offset to zero before hand like size might work as below dma_addr = offset = 0; size = 1ULL << 32; ret = of_dma_get_range(dev->of_node,&dma_addr,&paddr,&size); if (!ret) { offset = PFN_DOWN(paddr - dma_addr); } .. rest of the code. Murali > >> } else { >> offset = PFN_DOWN(paddr - dma_addr); >> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset); >> } >> dev->dma_pfn_offset = offset; >> >> + /* >> + * Workaround for DTs setting the size to a mask or 0. >> + */ >> + if (is_power_of_2(size + 1)) >> + size += 1; > > As I mentioned, I think power of 2 is too restrictive (from a DT > perspective even though the kernel may require a power of 2 here for > the mask). Just checking bit0 set should be enough. > > Also, we need a WARN here so DTs get fixed. > >> + >> + /* >> + * Coherent DMA masks larger than 32-bit must be explicitly set by the >> + * driver. >> + */ >> + dev->coherent_dma_mask = min(DMA_BIT_MASK(32), DMA_BIT_MASK(ilog2(size))); >> + >> coherent = of_dma_is_coherent(dev->of_node); >> dev_dbg(dev, "device is%sdma coherent\n", >> coherent ? " " : " not "); >> >> -- >> Catalin -- Murali Karicheri Linux Kernel, Texas Instruments From mboxrd@z Thu Jan 1 00:00:00 1970 From: Murali Karicheri Subject: Re: [PATCH v4 3/6] of: fix size when dma-range is not used Date: Wed, 28 Jan 2015 12:34:59 -0500 Message-ID: <54C91DC3.4020101@ti.com> References: <1422052359-12384-1-git-send-email-m-karicheri2@ti.com> <1422052359-12384-4-git-send-email-m-karicheri2@ti.com> <54C77616.80301@arm.com> <54C7DF13.20402@ti.com> <20150128110523.GC6646@e104818-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Rob Herring Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Russell King , Arnd Bergmann , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Will Deacon , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Bjorn Helgaas , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , Rob Herring , Catalin Marinas , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On 01/28/2015 10:45 AM, Rob Herring wrote: > On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas > wrote: >> On Tue, Jan 27, 2015 at 06:55:15PM +0000, Murali Karicheri wrote: >>> On 01/27/2015 06:27 AM, Robin Murphy wrote: >>>> On 23/01/15 22:32, Murali Karicheri wrote: >>>>> Fix the dma-range size when the DT attribute is missing. i.e set size to >>>>> dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. To detect >>>>> overflow when mask is set to max of u64, add a check, log error and >>>>> return. >>>>> Some platform use mask format for size in DTS. So add a work around to >>>>> catch this and fix. >>>>> >>>>> Cc: Joerg Roedel >>>>> Cc: Grant Likely >>>>> Cc: Rob Herring >>>>> Cc: Bjorn Helgaas >>>>> Cc: Will Deacon >>>>> Cc: Russell King >>>>> Cc: Arnd Bergmann >>>>> Cc: Suravee Suthikulpanit >>>>> >>>>> Signed-off-by: Murali Karicheri >>>>> --- >>>>> drivers/of/device.c | 14 +++++++++++++- >>>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/of/device.c b/drivers/of/device.c >>>>> index 2de320d..0a5ff54 100644 >>>>> --- a/drivers/of/device.c >>>>> +++ b/drivers/of/device.c >>>>> @@ -105,12 +105,24 @@ void of_dma_configure(struct device *dev, struct >>>>> device_node *np) >>>>> ret = of_dma_get_range(np,&dma_addr,&paddr,&size); >>>>> if (ret< 0) { >>>>> dma_addr = offset = 0; >>>>> - size = dev->coherent_dma_mask; >>>>> + size = dev->coherent_dma_mask + 1; >>>>> } else { >>>>> offset = PFN_DOWN(paddr - dma_addr); >>>>> + /* >>>>> + * Add a work around to treat the size as mask + 1 in case >>>>> + * it is defined in DT as a mask. >>>>> + */ >>>>> + if (size& 1) >>>>> + size = size + 1; >>>>> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", offset); >>>>> } >>>>> >>>>> + /* if size is 0, we have an overflow of u64 */ >>>>> + if (!size) { >>>>> + dev_err(dev, "invalid size\n"); >>>>> + return; >>>>> + } >>>>> + >>>> >>>> This seems potentially fragile to dodgy DTs given that we might also be >>>> using size to make a mask later. Would it make sense to double-up a >>>> sanity check as mask-format detection? Something like: >>>> >>>> if is_power_of_2(size) >>>> // use size >>>> else if is_power_of_2(size + 1) >>>> // use size + 1 >>>> else >>>> // cry >>> >>> How about having the logic like this? >>> >>> ret = of_dma_get_range(np,&dma_addr,&paddr,&size); >>> if (ret< 0) { >>> dma_addr = offset = 0; >>> size = dev->coherent_dma_mask + 1; >>> } else { >>> offset = PFN_DOWN(paddr - dma_addr); >>> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", offset); >>> } >>> >>> if (is_power_of_2(size + 1)) >>> size = size + 1; >>> else if (!is_power_of_2(size)) >>> { >>> dev_err(dev, "invalid size\n"); >>> return; >>> } >> >> In of_dma_configure(), we currently assume that the default coherent >> mask is 32-bit. In this thread: >> >> http://article.gmane.org/gmane.linux.kernel/1835096 >> >> we talked about setting the coherent mask based on size automatically. >> I'm not sure about the size but I think we can assume is 32-bit mask + 1 >> if it is not specified in the DT. Instead of just assuming a default >> mask, let's assume a default size and create the mask based on this >> (untested): >> >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >> index 5b33c6a21807..9ff8d1286b44 100644 >> --- a/drivers/of/platform.c >> +++ b/drivers/of/platform.c >> @@ -170,10 +170,10 @@ static void of_dma_configure(struct device *dev) >> struct iommu_ops *iommu; >> >> /* >> - * Set default dma-mask to 32 bit. Drivers are expected to setup >> - * the correct supported dma_mask. >> + * Set default size to cover the 32-bit. Drivers are expected to setup >> + * the correct size and dma_mask. >> */ >> - dev->coherent_dma_mask = DMA_BIT_MASK(32); >> + size = 1ULL<< 32; >> >> /* >> * Set it to coherent_dma_mask by default if the architecture >> @@ -185,13 +185,24 @@ static void of_dma_configure(struct device *dev) >> ret = of_dma_get_range(dev->of_node,&dma_addr,&paddr,&size); >> if (ret< 0) { >> dma_addr = offset = 0; >> - size = dev->coherent_dma_mask; > > Are we assuming dma_addr, paddr and size are not touched on error? If > so, we can get rid of this clause entirely. Checking the code for of_dma_get_range() I see paddr is modified on error case, but is used only for success case in this function. dma_addr and size are not modified. So setting dma_addr and offset to zero before hand like size might work as below dma_addr = offset = 0; size = 1ULL << 32; ret = of_dma_get_range(dev->of_node,&dma_addr,&paddr,&size); if (!ret) { offset = PFN_DOWN(paddr - dma_addr); } .. rest of the code. Murali > >> } else { >> offset = PFN_DOWN(paddr - dma_addr); >> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset); >> } >> dev->dma_pfn_offset = offset; >> >> + /* >> + * Workaround for DTs setting the size to a mask or 0. >> + */ >> + if (is_power_of_2(size + 1)) >> + size += 1; > > As I mentioned, I think power of 2 is too restrictive (from a DT > perspective even though the kernel may require a power of 2 here for > the mask). Just checking bit0 set should be enough. > > Also, we need a WARN here so DTs get fixed. > >> + >> + /* >> + * Coherent DMA masks larger than 32-bit must be explicitly set by the >> + * driver. >> + */ >> + dev->coherent_dma_mask = min(DMA_BIT_MASK(32), DMA_BIT_MASK(ilog2(size))); >> + >> coherent = of_dma_is_coherent(dev->of_node); >> dev_dbg(dev, "device is%sdma coherent\n", >> coherent ? " " : " not "); >> >> -- >> Catalin -- Murali Karicheri Linux Kernel, Texas Instruments From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from comal.ext.ti.com ([198.47.26.152]:56136 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754773AbbA1UPB (ORCPT ); Wed, 28 Jan 2015 15:15:01 -0500 Message-ID: <54C91DC3.4020101@ti.com> Date: Wed, 28 Jan 2015 12:34:59 -0500 From: Murali Karicheri MIME-Version: 1.0 To: Rob Herring CC: Catalin Marinas , Robin Murphy , "devicetree@vger.kernel.org" , Russell King , Arnd Bergmann , "linux-pci@vger.kernel.org" , Joerg Roedel , Will Deacon , "linux-kernel@vger.kernel.org" , "grant.likely@linaro.org" , "iommu@lists.linux-foundation.org" , Rob Herring , "suravee.suthikulpanit@amd.com" , Bjorn Helgaas , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 3/6] of: fix size when dma-range is not used References: <1422052359-12384-1-git-send-email-m-karicheri2@ti.com> <1422052359-12384-4-git-send-email-m-karicheri2@ti.com> <54C77616.80301@arm.com> <54C7DF13.20402@ti.com> <20150128110523.GC6646@e104818-lin.cambridge.arm.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-pci-owner@vger.kernel.org List-ID: On 01/28/2015 10:45 AM, Rob Herring wrote: > On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas > wrote: >> On Tue, Jan 27, 2015 at 06:55:15PM +0000, Murali Karicheri wrote: >>> On 01/27/2015 06:27 AM, Robin Murphy wrote: >>>> On 23/01/15 22:32, Murali Karicheri wrote: >>>>> Fix the dma-range size when the DT attribute is missing. i.e set size to >>>>> dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. To detect >>>>> overflow when mask is set to max of u64, add a check, log error and >>>>> return. >>>>> Some platform use mask format for size in DTS. So add a work around to >>>>> catch this and fix. >>>>> >>>>> Cc: Joerg Roedel >>>>> Cc: Grant Likely >>>>> Cc: Rob Herring >>>>> Cc: Bjorn Helgaas >>>>> Cc: Will Deacon >>>>> Cc: Russell King >>>>> Cc: Arnd Bergmann >>>>> Cc: Suravee Suthikulpanit >>>>> >>>>> Signed-off-by: Murali Karicheri >>>>> --- >>>>> drivers/of/device.c | 14 +++++++++++++- >>>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/of/device.c b/drivers/of/device.c >>>>> index 2de320d..0a5ff54 100644 >>>>> --- a/drivers/of/device.c >>>>> +++ b/drivers/of/device.c >>>>> @@ -105,12 +105,24 @@ void of_dma_configure(struct device *dev, struct >>>>> device_node *np) >>>>> ret = of_dma_get_range(np,&dma_addr,&paddr,&size); >>>>> if (ret< 0) { >>>>> dma_addr = offset = 0; >>>>> - size = dev->coherent_dma_mask; >>>>> + size = dev->coherent_dma_mask + 1; >>>>> } else { >>>>> offset = PFN_DOWN(paddr - dma_addr); >>>>> + /* >>>>> + * Add a work around to treat the size as mask + 1 in case >>>>> + * it is defined in DT as a mask. >>>>> + */ >>>>> + if (size& 1) >>>>> + size = size + 1; >>>>> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", offset); >>>>> } >>>>> >>>>> + /* if size is 0, we have an overflow of u64 */ >>>>> + if (!size) { >>>>> + dev_err(dev, "invalid size\n"); >>>>> + return; >>>>> + } >>>>> + >>>> >>>> This seems potentially fragile to dodgy DTs given that we might also be >>>> using size to make a mask later. Would it make sense to double-up a >>>> sanity check as mask-format detection? Something like: >>>> >>>> if is_power_of_2(size) >>>> // use size >>>> else if is_power_of_2(size + 1) >>>> // use size + 1 >>>> else >>>> // cry >>> >>> How about having the logic like this? >>> >>> ret = of_dma_get_range(np,&dma_addr,&paddr,&size); >>> if (ret< 0) { >>> dma_addr = offset = 0; >>> size = dev->coherent_dma_mask + 1; >>> } else { >>> offset = PFN_DOWN(paddr - dma_addr); >>> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", offset); >>> } >>> >>> if (is_power_of_2(size + 1)) >>> size = size + 1; >>> else if (!is_power_of_2(size)) >>> { >>> dev_err(dev, "invalid size\n"); >>> return; >>> } >> >> In of_dma_configure(), we currently assume that the default coherent >> mask is 32-bit. In this thread: >> >> http://article.gmane.org/gmane.linux.kernel/1835096 >> >> we talked about setting the coherent mask based on size automatically. >> I'm not sure about the size but I think we can assume is 32-bit mask + 1 >> if it is not specified in the DT. Instead of just assuming a default >> mask, let's assume a default size and create the mask based on this >> (untested): >> >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >> index 5b33c6a21807..9ff8d1286b44 100644 >> --- a/drivers/of/platform.c >> +++ b/drivers/of/platform.c >> @@ -170,10 +170,10 @@ static void of_dma_configure(struct device *dev) >> struct iommu_ops *iommu; >> >> /* >> - * Set default dma-mask to 32 bit. Drivers are expected to setup >> - * the correct supported dma_mask. >> + * Set default size to cover the 32-bit. Drivers are expected to setup >> + * the correct size and dma_mask. >> */ >> - dev->coherent_dma_mask = DMA_BIT_MASK(32); >> + size = 1ULL<< 32; >> >> /* >> * Set it to coherent_dma_mask by default if the architecture >> @@ -185,13 +185,24 @@ static void of_dma_configure(struct device *dev) >> ret = of_dma_get_range(dev->of_node,&dma_addr,&paddr,&size); >> if (ret< 0) { >> dma_addr = offset = 0; >> - size = dev->coherent_dma_mask; > > Are we assuming dma_addr, paddr and size are not touched on error? If > so, we can get rid of this clause entirely. Checking the code for of_dma_get_range() I see paddr is modified on error case, but is used only for success case in this function. dma_addr and size are not modified. So setting dma_addr and offset to zero before hand like size might work as below dma_addr = offset = 0; size = 1ULL << 32; ret = of_dma_get_range(dev->of_node,&dma_addr,&paddr,&size); if (!ret) { offset = PFN_DOWN(paddr - dma_addr); } .. rest of the code. Murali > >> } else { >> offset = PFN_DOWN(paddr - dma_addr); >> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset); >> } >> dev->dma_pfn_offset = offset; >> >> + /* >> + * Workaround for DTs setting the size to a mask or 0. >> + */ >> + if (is_power_of_2(size + 1)) >> + size += 1; > > As I mentioned, I think power of 2 is too restrictive (from a DT > perspective even though the kernel may require a power of 2 here for > the mask). Just checking bit0 set should be enough. > > Also, we need a WARN here so DTs get fixed. > >> + >> + /* >> + * Coherent DMA masks larger than 32-bit must be explicitly set by the >> + * driver. >> + */ >> + dev->coherent_dma_mask = min(DMA_BIT_MASK(32), DMA_BIT_MASK(ilog2(size))); >> + >> coherent = of_dma_is_coherent(dev->of_node); >> dev_dbg(dev, "device is%sdma coherent\n", >> coherent ? " " : " not "); >> >> -- >> Catalin -- Murali Karicheri Linux Kernel, Texas Instruments From mboxrd@z Thu Jan 1 00:00:00 1970 From: m-karicheri2@ti.com (Murali Karicheri) Date: Wed, 28 Jan 2015 12:34:59 -0500 Subject: [PATCH v4 3/6] of: fix size when dma-range is not used In-Reply-To: References: <1422052359-12384-1-git-send-email-m-karicheri2@ti.com> <1422052359-12384-4-git-send-email-m-karicheri2@ti.com> <54C77616.80301@arm.com> <54C7DF13.20402@ti.com> <20150128110523.GC6646@e104818-lin.cambridge.arm.com> Message-ID: <54C91DC3.4020101@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/28/2015 10:45 AM, Rob Herring wrote: > On Wed, Jan 28, 2015 at 5:05 AM, Catalin Marinas > wrote: >> On Tue, Jan 27, 2015 at 06:55:15PM +0000, Murali Karicheri wrote: >>> On 01/27/2015 06:27 AM, Robin Murphy wrote: >>>> On 23/01/15 22:32, Murali Karicheri wrote: >>>>> Fix the dma-range size when the DT attribute is missing. i.e set size to >>>>> dev->coherent_dma_mask + 1 instead of dev->coherent_dma_mask. To detect >>>>> overflow when mask is set to max of u64, add a check, log error and >>>>> return. >>>>> Some platform use mask format for size in DTS. So add a work around to >>>>> catch this and fix. >>>>> >>>>> Cc: Joerg Roedel >>>>> Cc: Grant Likely >>>>> Cc: Rob Herring >>>>> Cc: Bjorn Helgaas >>>>> Cc: Will Deacon >>>>> Cc: Russell King >>>>> Cc: Arnd Bergmann >>>>> Cc: Suravee Suthikulpanit >>>>> >>>>> Signed-off-by: Murali Karicheri >>>>> --- >>>>> drivers/of/device.c | 14 +++++++++++++- >>>>> 1 file changed, 13 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/of/device.c b/drivers/of/device.c >>>>> index 2de320d..0a5ff54 100644 >>>>> --- a/drivers/of/device.c >>>>> +++ b/drivers/of/device.c >>>>> @@ -105,12 +105,24 @@ void of_dma_configure(struct device *dev, struct >>>>> device_node *np) >>>>> ret = of_dma_get_range(np,&dma_addr,&paddr,&size); >>>>> if (ret< 0) { >>>>> dma_addr = offset = 0; >>>>> - size = dev->coherent_dma_mask; >>>>> + size = dev->coherent_dma_mask + 1; >>>>> } else { >>>>> offset = PFN_DOWN(paddr - dma_addr); >>>>> + /* >>>>> + * Add a work around to treat the size as mask + 1 in case >>>>> + * it is defined in DT as a mask. >>>>> + */ >>>>> + if (size& 1) >>>>> + size = size + 1; >>>>> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", offset); >>>>> } >>>>> >>>>> + /* if size is 0, we have an overflow of u64 */ >>>>> + if (!size) { >>>>> + dev_err(dev, "invalid size\n"); >>>>> + return; >>>>> + } >>>>> + >>>> >>>> This seems potentially fragile to dodgy DTs given that we might also be >>>> using size to make a mask later. Would it make sense to double-up a >>>> sanity check as mask-format detection? Something like: >>>> >>>> if is_power_of_2(size) >>>> // use size >>>> else if is_power_of_2(size + 1) >>>> // use size + 1 >>>> else >>>> // cry >>> >>> How about having the logic like this? >>> >>> ret = of_dma_get_range(np,&dma_addr,&paddr,&size); >>> if (ret< 0) { >>> dma_addr = offset = 0; >>> size = dev->coherent_dma_mask + 1; >>> } else { >>> offset = PFN_DOWN(paddr - dma_addr); >>> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", offset); >>> } >>> >>> if (is_power_of_2(size + 1)) >>> size = size + 1; >>> else if (!is_power_of_2(size)) >>> { >>> dev_err(dev, "invalid size\n"); >>> return; >>> } >> >> In of_dma_configure(), we currently assume that the default coherent >> mask is 32-bit. In this thread: >> >> http://article.gmane.org/gmane.linux.kernel/1835096 >> >> we talked about setting the coherent mask based on size automatically. >> I'm not sure about the size but I think we can assume is 32-bit mask + 1 >> if it is not specified in the DT. Instead of just assuming a default >> mask, let's assume a default size and create the mask based on this >> (untested): >> >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >> index 5b33c6a21807..9ff8d1286b44 100644 >> --- a/drivers/of/platform.c >> +++ b/drivers/of/platform.c >> @@ -170,10 +170,10 @@ static void of_dma_configure(struct device *dev) >> struct iommu_ops *iommu; >> >> /* >> - * Set default dma-mask to 32 bit. Drivers are expected to setup >> - * the correct supported dma_mask. >> + * Set default size to cover the 32-bit. Drivers are expected to setup >> + * the correct size and dma_mask. >> */ >> - dev->coherent_dma_mask = DMA_BIT_MASK(32); >> + size = 1ULL<< 32; >> >> /* >> * Set it to coherent_dma_mask by default if the architecture >> @@ -185,13 +185,24 @@ static void of_dma_configure(struct device *dev) >> ret = of_dma_get_range(dev->of_node,&dma_addr,&paddr,&size); >> if (ret< 0) { >> dma_addr = offset = 0; >> - size = dev->coherent_dma_mask; > > Are we assuming dma_addr, paddr and size are not touched on error? If > so, we can get rid of this clause entirely. Checking the code for of_dma_get_range() I see paddr is modified on error case, but is used only for success case in this function. dma_addr and size are not modified. So setting dma_addr and offset to zero before hand like size might work as below dma_addr = offset = 0; size = 1ULL << 32; ret = of_dma_get_range(dev->of_node,&dma_addr,&paddr,&size); if (!ret) { offset = PFN_DOWN(paddr - dma_addr); } .. rest of the code. Murali > >> } else { >> offset = PFN_DOWN(paddr - dma_addr); >> dev_dbg(dev, "dma_pfn_offset(%#08lx)\n", dev->dma_pfn_offset); >> } >> dev->dma_pfn_offset = offset; >> >> + /* >> + * Workaround for DTs setting the size to a mask or 0. >> + */ >> + if (is_power_of_2(size + 1)) >> + size += 1; > > As I mentioned, I think power of 2 is too restrictive (from a DT > perspective even though the kernel may require a power of 2 here for > the mask). Just checking bit0 set should be enough. > > Also, we need a WARN here so DTs get fixed. > >> + >> + /* >> + * Coherent DMA masks larger than 32-bit must be explicitly set by the >> + * driver. >> + */ >> + dev->coherent_dma_mask = min(DMA_BIT_MASK(32), DMA_BIT_MASK(ilog2(size))); >> + >> coherent = of_dma_is_coherent(dev->of_node); >> dev_dbg(dev, "device is%sdma coherent\n", >> coherent ? " " : " not "); >> >> -- >> Catalin -- Murali Karicheri Linux Kernel, Texas Instruments