From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGZC4-0001eG-Vn for qemu-devel@nongnu.org; Wed, 28 Jan 2015 15:26:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGZC1-0004oa-EY for qemu-devel@nongnu.org; Wed, 28 Jan 2015 15:26:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGZC1-0004oR-5n for qemu-devel@nongnu.org; Wed, 28 Jan 2015 15:26:29 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SKQRw3007331 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 28 Jan 2015 15:26:28 -0500 Message-ID: <54C945F2.3050707@redhat.com> Date: Wed, 28 Jan 2015 13:26:26 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422387983-32153-1-git-send-email-mreitz@redhat.com> <1422387983-32153-43-git-send-email-mreitz@redhat.com> In-Reply-To: <1422387983-32153-43-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jj6S4S4lgwIABdHN1C1JwCVwGQma6UljU" Subject: Re: [Qemu-devel] [PATCH RESEND 42/50] blockdev: Implement eject with basic operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Jeff Cody , Markus Armbruster , Stefan Hajnoczi , John Snow This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jj6S4S4lgwIABdHN1C1JwCVwGQma6UljU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/27/2015 12:46 PM, Max Reitz wrote: > Implement 'eject' by calling blockdev-open-tray and > blockdev-remove-medium. >=20 > Signed-off-by: Max Reitz > --- > blockdev.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Hmm. If you decide to enforce node-name only on the low-level command, but still want this high-level command to support BDS->BB lookup for convenience, you might need additional code here. I don't know if that is an argument in favor or against supporting BDS->BB as convenience at the low level. I don't have a strong enough opinion towards either decision, so I'll let others chime in or let your original choice be good enough. Therefore: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Jj6S4S4lgwIABdHN1C1JwCVwGQma6UljU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUyUXyAAoJEKeha0olJ0Nq1YIIAIMaN+xva6Cig9mpzYeb6kRT oG7wdscn+gfzLHfU7ZGKWrY6TXe0zEfI5ZKNN4KuCPZyeF0K6dQo9pEpTbG8hDrV fB0tx3gFHlJTHlqN44gp2Bn1SGdSedLoTl0boMI38kqetKizo1qnHpj2NXnIqbu8 duaxcax+n4sDJZHc7Oy5cQWeVdOSTKCp4OBGez5gbuTjPz7J3SxlngDzHlZZhgl3 4wcykY7DGRdhiFEVIrFlhzY23mjDase+MRDIty3PcTH4YlDG3aQuCdfEomJr94+9 yvVGEbku2GJJeIuTbsnwrg9HXemwok0BC1oEB/X7WL42JGvhqlftOtzgSIgfJm0= =cNdj -----END PGP SIGNATURE----- --Jj6S4S4lgwIABdHN1C1JwCVwGQma6UljU--