From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57029)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGa9m-0000cH-Ud
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:28:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGa9m-0006V7-2s
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:28:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42810)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YGa9l-0006Uk-Rr
	for qemu-devel@nongnu.org; Wed, 28 Jan 2015 16:28:14 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0SLSDq3013255
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 28 Jan 2015 16:28:13 -0500
Message-ID: <54C9546B.9060203@redhat.com>
Date: Wed, 28 Jan 2015 16:28:11 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1422387983-32153-1-git-send-email-mreitz@redhat.com>
	<1422387983-32153-50-git-send-email-mreitz@redhat.com>
	<54C95439.60508@redhat.com>
In-Reply-To: <54C95439.60508@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RESEND 49/50] iotests: More options for
	VM.add_drive()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Jeff Cody <jcody@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, John Snow <jsnow@redhat.com>

On 2015-01-28 at 16:27, Eric Blake wrote:
> On 01/27/2015 12:46 PM, Max Reitz wrote:
>> This patch allows specifying the interface to be used for the drive, and
>> makes specifying a path optional (if the path is None, the "file" option
>> will be omitted, thus creating an empty drive).
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/iotests.py | 9 ++++++---
>>   1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> +
>> +        if not path is None:
>> +            options.append('file=%s' % path)
> Works, but it is more idiomatic to use 'if path is not None:', based on
> a grep of the source tree.

Did I ever mention I don't know Python very well?

That sounds a lot better, will do, thanks.

> With that minor switch,
> Reviewed-by: Eric Blake <eblake@redhat.com>

On to the last patch! :-)

Max