From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 22/24] tools/libxl: arm: Use an higher value for the GIC phandle Date: Thu, 29 Jan 2015 12:05:02 +0000 Message-ID: <54CA21EE.9050407@linaro.org> References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org> <1421159133-31526-23-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YGnqm-0008JN-8y for xen-devel@lists.xenproject.org; Thu, 29 Jan 2015 12:05:32 +0000 Received: by mail-wi0-f182.google.com with SMTP id n3so23529970wiv.3 for ; Thu, 29 Jan 2015 04:05:30 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini Cc: Wei Liu , ian.campbell@citrix.com, tim@xen.org, Ian Jackson , stefano.stabellini@citrix.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 29/01/15 11:07, Stefano Stabellini wrote: > On Tue, 13 Jan 2015, Julien Grall wrote: >> The partial device tree may contains phandle. The Device Tree Compiler >> tends to allocate the phandle from 1. >> >> Reserve the ID 65000 for the GIC phandle. I think we can safely assume >> that the partial device tree will never contain a such ID. >> >> Signed-off-by: Julien Grall >> Cc: Ian Jackson >> Cc: Wei Liu >> > > Shouldn't we at least check that the partial device tree doesn't contain > a conflicting phandle? I don't think so. This will unlikely happen, and if it happens the guest will crash with an obvious error. Regards, -- Julien Grall