From: Ian Abbott <abbotti@mev.co.uk>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used
Date: Thu, 29 Jan 2015 14:46:03 +0000 [thread overview]
Message-ID: <54CA47AB.5070505@mev.co.uk> (raw)
In-Reply-To: <1422484660-9399-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On 28/01/15 22:37, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/ni_mio_cs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_mio_cs.c b/drivers/staging/comedi/drivers/ni_mio_cs.c
> index 9b201e4..b152330 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_cs.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_cs.c
> @@ -163,7 +163,6 @@ static int mio_cs_auto_attach(struct comedi_device *dev,
> {
> struct pcmcia_device *link = comedi_to_pcmcia_dev(dev);
> static const struct ni_board_struct *board;
> - struct ni_private *devpriv;
> int ret;
>
> board = ni_getboardtype(dev, link);
> @@ -188,8 +187,6 @@ static int mio_cs_auto_attach(struct comedi_device *dev,
> if (ret)
> return ret;
>
> - devpriv = dev->private;
> -
> return ni_E_init(dev, 0, 1);
> }
>
>
Yes, devpriv is not needed here.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2015-01-29 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 22:37 [PATCH] staging: comedi: drivers: ni_mio_cs: Removed variables that is never used Rickard Strandqvist
2015-01-29 14:46 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CA47AB.5070505@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.