From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36044) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGw0g-0007Fl-Ni for qemu-devel@nongnu.org; Thu, 29 Jan 2015 15:48:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGw0d-0004nM-Gv for qemu-devel@nongnu.org; Thu, 29 Jan 2015 15:48:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGw0d-0004nF-7J for qemu-devel@nongnu.org; Thu, 29 Jan 2015 15:48:15 -0500 Message-ID: <54CA9C8C.7030906@redhat.com> Date: Thu, 29 Jan 2015 13:48:12 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422543997-22808-1-git-send-email-dgilbert@redhat.com> <1422543997-22808-2-git-send-email-dgilbert@redhat.com> <20150129151527.GE1102@redhat.com> <54CA500E.8030608@redhat.com> <20150129155425.GE2391@work-vm> <54CA594E.5030605@redhat.com> <20150129162815.GG2391@work-vm> <54CA71CD.3090304@redhat.com> <20150129202154.GH2391@work-vm> In-Reply-To: <20150129202154.GH2391@work-vm> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9t2cOHIjtXs94XIvwpJkM0OPIGP1Kal1J" Subject: Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: amit.shah@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9t2cOHIjtXs94XIvwpJkM0OPIGP1Kal1J Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: > * Eric Blake (eblake@redhat.com) wrote: >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: >>> >>> So what would the .args_type look like in qmp-commands.hx; something = like this? >>> >>> .args-type =3D "type:s,port:-i,host:-s,command:-s" >> >> No, it would be more like the blockdev-add interface, where one comman= d >> accepts a dictionary object containing a union of valid values, where >> the set of valid values is determined by the discriminator field. >> .args_type =3D "options:q". >=20 > What causes the parser to generate a 'BlockdevOptions' as opposed to an= y > standard options type for the parameter of qmp_blockdev_add? Kevin Wolf has the most experience here, as he was the one that figured out how to correlate command line and QMP as part of adding blockdev-add.= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9t2cOHIjtXs94XIvwpJkM0OPIGP1Kal1J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUypyMAAoJEKeha0olJ0Nq92UH/3govUHSCbqpYDSuRzK8XmA1 8eQKGptqLONwP2F3/Cz+96ss7lJSg7CiP+n4Fa8dTOW2voiyfvXV/6IvEOC0fn/m NTzHI0MBLDn/cSd/fxlgVxzbXMhRcqqbnCezxpJoiWrp1LJ2Po+DsnJfa8H9e1qm KIN7OCBzX24xboKeGCX+A5LwUxytONOkmAphvZETaBZe3t7z6y09SYMatEtXDVHc qEBg0P2cq1XL66ehwYfWdMIt54iGDOJqmVY9mV6l6p8oxovDVFj7+Bu/INfiAnOC 9xXn+F/CgcY+uMlnE585qwsDhzsVtvmn+xktI2M+SGxmDCNTXiT1vko0SXK76CQ= =gONZ -----END PGP SIGNATURE----- --9t2cOHIjtXs94XIvwpJkM0OPIGP1Kal1J--