From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758283AbbA2VO5 (ORCPT ); Thu, 29 Jan 2015 16:14:57 -0500 Received: from mail-ig0-f176.google.com ([209.85.213.176]:52496 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758215AbbA2VOz (ORCPT ); Thu, 29 Jan 2015 16:14:55 -0500 Message-ID: <54CAA2CD.2050903@kernel.dk> Date: Thu, 29 Jan 2015 13:14:53 -0800 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Sudip Mukherjee CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] blk-mq: use BUG_ON() References: <1422553582-4792-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1422553582-4792-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/29/2015 09:46 AM, Sudip Mukherjee wrote: > use BUG_ON() instead of using if(condition) BUG() > > Signed-off-by: Sudip Mukherjee > --- > block/blk-mq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 8107962..d8f0922 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -337,8 +337,7 @@ EXPORT_SYMBOL(__blk_mq_end_request); > > void blk_mq_end_request(struct request *rq, int error) > { > - if (blk_update_request(rq, error, blk_rq_bytes(rq))) > - BUG(); > + BUG_ON(blk_update_request(rq, error, blk_rq_bytes(rq))); > __blk_mq_end_request(rq, error); This makes it less readable than it was before, so no. -- Jens Axboe