From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGynx-0000XU-IK for qemu-devel@nongnu.org; Thu, 29 Jan 2015 18:47:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGynu-00081z-Cs for qemu-devel@nongnu.org; Thu, 29 Jan 2015 18:47:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGynu-00081i-3p for qemu-devel@nongnu.org; Thu, 29 Jan 2015 18:47:18 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0TNlGn5032284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 29 Jan 2015 18:47:17 -0500 Message-ID: <54CAC683.1060600@redhat.com> Date: Thu, 29 Jan 2015 16:47:15 -0700 From: Eric Blake MIME-Version: 1.0 References: <1422300468-16216-1-git-send-email-mreitz@redhat.com> <1422300468-16216-9-git-send-email-mreitz@redhat.com> In-Reply-To: <1422300468-16216-9-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jKqD5u13m95KRobK2Lrx8Elbet4C75wvR" Subject: Re: [Qemu-devel] [PATCH 08/21] block: Make bdrv_close() static List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jKqD5u13m95KRobK2Lrx8Elbet4C75wvR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2015 12:27 PM, Max Reitz wrote: > There are no users of bdrv_close() left, except for one of bdrv_open()'= s > failure paths, bdrv_close_all() and bdrv_delete(), and that is good. > Make bdrv_close() static so nobody makes the mistake of directly using > bdrv_close() again. >=20 > Signed-off-by: Max Reitz > --- > block.c | 4 +++- > include/block/block.h | 1 - > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jKqD5u13m95KRobK2Lrx8Elbet4C75wvR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUysaDAAoJEKeha0olJ0NqIVEH/RkHO/I97LX8LYwidyxPEpha t7OV8B9El44+vyFHTMML9yuLh3qBt9huiSv3FUljiU/MWrp02zdXNtp+dDRKm+Iv 4aiq+TwkO95CXc3pYBf2n8BEE7WNe3TrSoMVgki3qiDjTmm8tuNsjxc8V7GX4nhx hwtufzyESpERlwStwZwPF+ZIpGIO1XRVMw1+QxrWxA1KKh0SmwporQ4ud3cCe8cd DIMTTxPkUtM1WXrnNxYOXNqT245uzmtTc4d4ham1NmL9/ai0vMET3a0UUqiqcZ1F cT6o0jBPFb8rsfdBI7dq0/cpmmgeKLZlClaUfA6AlJI4x2O+pA/5/PDMCXHy/4o= =JMJO -----END PGP SIGNATURE----- --jKqD5u13m95KRobK2Lrx8Elbet4C75wvR--