From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47917)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YGzaV-0007sA-05
	for qemu-devel@nongnu.org; Thu, 29 Jan 2015 19:37:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YGzaR-0005vE-H2
	for qemu-devel@nongnu.org; Thu, 29 Jan 2015 19:37:30 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:63446)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YGzaQ-0005uW-Um
	for qemu-devel@nongnu.org; Thu, 29 Jan 2015 19:37:27 -0500
Message-ID: <54CAD231.5050709@huawei.com>
Date: Fri, 30 Jan 2015 08:37:05 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1422535966-9948-1-git-send-email-arei.gonglei@huawei.com>
	<1422535966-9948-2-git-send-email-arei.gonglei@huawei.com>
	<54CA5C52.3070303@terremark.com>
In-Reply-To: <54CA5C52.3070303@terremark.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] vnc: fix qemu crash when not configure
 vnc option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <dslutz@verizon.com>
Cc: "Huangpeng (Peter)" <peter.huangpeng@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "kraxel@redhat.com" <kraxel@redhat.com>

On 2015/1/30 0:14, Don Slutz wrote:

> On 01/29/15 07:52, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> Reproducer:
>> $ x86_64-softmmu/qemu-system-x86_64
>> qemu-system-x86_64: Invalid parameter 'to'
>> Segmentation fault (core dumped)
>>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> ---
>>  ui/vnc.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/ui/vnc.c b/ui/vnc.c
>> index a742c90..08b8b24 100644
>> --- a/ui/vnc.c
>> +++ b/ui/vnc.c
>> @@ -3276,6 +3276,15 @@ static QemuOptsList qemu_vnc_opts = {
>>              .name = "connections",
>>              .type = QEMU_OPT_NUMBER,
>>          },{
>> +            .name = "to",
>> +            .type = QEMU_OPT_NUMBER,
>> +        },{
>> +            .name = "ipv4",
>> +            .type = QEMU_OPT_BOOL,
>> +        },{
>> +            .name = "ipv6",
>> +            .type = QEMU_OPT_BOOL,
>> +        },{
>>              .name = "password",
>>              .type = QEMU_OPT_BOOL,
>>          },{
>>
> 
> The code change looks good, but does more then the commit message says.
> 
> Maybe include something like "Add missing vnc options: to, ipv4, ipv6".
> 

Will do, thanks.

Regards,
-Gonglei