From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760047AbbA3Iuz (ORCPT ); Fri, 30 Jan 2015 03:50:55 -0500 Received: from mail-we0-f170.google.com ([74.125.82.170]:57663 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754549AbbA3Iuy (ORCPT ); Fri, 30 Jan 2015 03:50:54 -0500 Message-ID: <54CB45E8.3030901@redhat.com> Date: Fri, 30 Jan 2015 09:50:48 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Joe Perches , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Nadav Amit , Gleb Natapov Subject: Re: [PATCH 1/8] KVM: x86: return bool from kvm_apic_match*() References: <1422568135-28402-1-git-send-email-rkrcmar@redhat.com> <1422568135-28402-2-git-send-email-rkrcmar@redhat.com> <1422569401.16326.2.camel@perches.com> In-Reply-To: <1422569401.16326.2.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/01/2015 23:10, Joe Perches wrote: > On Thu, 2015-01-29 at 22:48 +0100, Radim Krčmář wrote: >> And don't export the internal ones while at it. > [] >> -int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda) >> +static bool kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda) >> { >> int result = 0; >> u32 logical_id; >> @@ -626,7 +626,7 @@ int kvm_apic_match_logical_addr(struct kvm_lapic *apic, u32 mda) >> return result; >> } >> >> -int kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source, >> +bool kvm_apic_match_dest(struct kvm_vcpu *vcpu, struct kvm_lapic *source, >> int short_hand, unsigned int dest, int dest_mode) >> { >> int result = 0; > > Perhaps these result variables should be bool. See patch 2. Paolo