From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760527AbbA3KWl (ORCPT ); Fri, 30 Jan 2015 05:22:41 -0500 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:40063 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758533AbbA3KWi (ORCPT ); Fri, 30 Jan 2015 05:22:38 -0500 X-Sender-Id: abbotti@mev.co.uk Message-ID: <54CB5B6B.1020607@mev.co.uk> Date: Fri, 30 Jan 2015 10:22:35 +0000 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Rickard Strandqvist , H Hartley Sweeten CC: Greg Kroah-Hartman , Heena Sirwani , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: comedi: drivers: mite: Removed variables that is never used References: <1422570351-7965-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1422570351-7965-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/01/15 22:25, Rickard Strandqvist wrote: > Variable was assigned a value that was never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/comedi/drivers/mite.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c > index ffc9e61..1e537a5 100644 > --- a/drivers/staging/comedi/drivers/mite.c > +++ b/drivers/staging/comedi/drivers/mite.c > @@ -494,9 +494,7 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub); > unsigned mite_dma_tcr(struct mite_channel *mite_chan) > { > struct mite_struct *mite = mite_chan->mite; > - int lkar; > > - lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel)); > return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel)); > } > EXPORT_SYMBOL_GPL(mite_dma_tcr); > Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-