From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 30 Jan 2015 11:24:05 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:4010 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010822AbbA3KYCjtCKn (ORCPT ); Fri, 30 Jan 2015 11:24:02 +0100 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 3545E351B4EE2; Fri, 30 Jan 2015 10:23:55 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 30 Jan 2015 10:23:57 +0000 Received: from [192.168.154.96] (192.168.154.96) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Fri, 30 Jan 2015 10:23:56 +0000 Message-ID: <54CB5BBC.6050902@imgtec.com> Date: Fri, 30 Jan 2015 10:23:56 +0000 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Paul Burton CC: Matthew Fortune , "linux-mips@linux-mips.org" , "Maciej W. Rozycki (macro@linux-mips.org)" Subject: Re: [PATCH RFC v2 68/70] MIPS: kernel: elf: Improve the overall ABI and FPU mode checks References: <1421405389-15512-1-git-send-email-markos.chandras@imgtec.com> <1421405389-15512-69-git-send-email-markos.chandras@imgtec.com> <6D39441BF12EF246A7ABCE6654B0235320FAAEED@LEMAIL01.le.imgtec.org> <54BCF5D7.1020907@imgtec.com> <20150129232222.GJ6116@NP-P-BURTON> In-Reply-To: <20150129232222.GJ6116@NP-P-BURTON> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.96] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 45559 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 01/29/2015 11:22 PM, Paul Burton wrote: > On Mon, Jan 19, 2015 at 12:17:27PM +0000, Markos Chandras wrote: >>> Is it worth updating the CONFIG_MIPS_O32_FP64_SUPPORT option to no longer >>> be experimental and also default on? This option could then guard the new >>> logic from this patch as a safety measure. Once the code has been proven >>> I'd suggest removing the option and making the code unconditional. >> >> Paul? >> >> Initially thought of having 32-bit R6 select this symbol but then I >> dropped it. But maybe it make sense now? > > Personally I'd rather leave it default to off until it gets through a > release cycle without any complaints. Perhaps having r6 select it, or > "default y if CONFIG_CPU_MIPSR6" would make sense though, given that you > won't be able to use the FPU for r6 userland without it. > > Paul > Thanks I add a patch to have CPU_MIPS32_R6 select MIPS_O32_FP64_SUPPORT -- markos